From 3d9398a1a611635826d28a6c97f7dfabda0046dd Mon Sep 17 00:00:00 2001 From: Chuck Date: Sun, 8 Mar 2026 21:17:36 -0400 Subject: [PATCH] fix(f1): resolve ScrollHelper.reset AttributeError Replace scroll_helper.reset() with scroll_helper.reset_scroll() in F1 and UFC plugins; ScrollHelper exposes reset_scroll(), not reset(). This was causing 'ScrollHelper' object has no attribute 'reset' and prevented qualifying/standings from displaying after track overview. - f1-scoreboard/scroll_display.py: fix both call sites - ufc-scoreboard/scroll_display.py: fix reset call for consistency - f1-scoreboard manifest: bump to 1.2.3, sync plugins.json Made-with: Cursor --- plugins.json | 6 +++--- plugins/f1-scoreboard/manifest.json | 9 +++++++-- plugins/f1-scoreboard/scroll_display.py | 4 ++-- plugins/ufc-scoreboard/scroll_display.py | 2 +- 4 files changed, 13 insertions(+), 8 deletions(-) diff --git a/plugins.json b/plugins.json index 024704b..f122eac 100644 --- a/plugins.json +++ b/plugins.json @@ -1,6 +1,6 @@ { "version": "1.0.0", - "last_updated": "2026-03-09", + "last_updated": "2026-03-08", "plugins": [ { "id": "hello-world", @@ -644,10 +644,10 @@ "plugin_path": "plugins/f1-scoreboard", "stars": 0, "downloads": 0, - "last_updated": "2026-02-25", + "last_updated": "2026-03-08", "verified": true, "screenshot": "", - "latest_version": "1.2.2" + "latest_version": "1.2.3" }, { "id": "pga-tour-leaderboard", diff --git a/plugins/f1-scoreboard/manifest.json b/plugins/f1-scoreboard/manifest.json index 99a4c21..2d6b26d 100644 --- a/plugins/f1-scoreboard/manifest.json +++ b/plugins/f1-scoreboard/manifest.json @@ -1,7 +1,7 @@ { "id": "f1-scoreboard", "name": "F1 Scoreboard", - "version": "1.2.2", + "version": "1.2.3", "author": "ChuckBuilds", "class_name": "F1ScoreboardPlugin", "entry_point": "manager.py", @@ -29,6 +29,11 @@ "f1_calendar" ], "versions": [ + { + "version": "1.2.3", + "ledmatrix_min": "2.0.0", + "released": "2026-03-08" + }, { "version": "1.2.2", "ledmatrix_min": "2.0.0", @@ -50,7 +55,7 @@ "released": "2026-02-17" } ], - "last_updated": "2026-03-02", + "last_updated": "2026-03-08", "stars": 0, "downloads": 0, "verified": true, diff --git a/plugins/f1-scoreboard/scroll_display.py b/plugins/f1-scoreboard/scroll_display.py index 05ac208..bac47fa 100644 --- a/plugins/f1-scoreboard/scroll_display.py +++ b/plugins/f1-scoreboard/scroll_display.py @@ -126,7 +126,7 @@ def display_scroll_frame(self, force_clear: bool = False) -> bool: return True if force_clear: - self.scroll_helper.reset() + self.scroll_helper.reset_scroll() self.scroll_helper.update_scroll_position() visible = self.scroll_helper.get_visible_portion() @@ -145,7 +145,7 @@ def display_scroll_frame(self, force_clear: bool = False) -> bool: def reset(self): """Reset scroll position to beginning.""" if self.scroll_helper: - self.scroll_helper.reset() + self.scroll_helper.reset_scroll() def is_prepared(self) -> bool: """Check if content has been prepared for scrolling.""" diff --git a/plugins/ufc-scoreboard/scroll_display.py b/plugins/ufc-scoreboard/scroll_display.py index ae980ec..68292a2 100644 --- a/plugins/ufc-scoreboard/scroll_display.py +++ b/plugins/ufc-scoreboard/scroll_display.py @@ -386,4 +386,4 @@ def reset(self) -> None: self._vegas_content_items = [] self._frame_count = 0 if self.scroll_helper: - self.scroll_helper.reset() + self.scroll_helper.reset_scroll()