From f487a108b68aca0a0ef99d07994e4d84a9f202ec Mon Sep 17 00:00:00 2001 From: auxfuse Date: Wed, 21 Oct 2020 11:45:13 +0100 Subject: [PATCH 1/2] Set error logging in save function of Profile model --- accounts/models.py | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/accounts/models.py b/accounts/models.py index ac3aad9f..46b75105 100644 --- a/accounts/models.py +++ b/accounts/models.py @@ -6,6 +6,10 @@ from allauth.account.signals import user_signed_up from .lists import USER_TYPES_CHOICES, LMS_MODULES_CHOICES +import logging + +# Initialise instance of a logger to handle error logging +logger = logging.getLogger(__name__) class Profile(models.Model): @@ -52,7 +56,7 @@ def save(self, *args, **kwargs): self.slack_display_name = self.user.profile.slack_display_name self.user_type = self.user.profile.user_type self.current_lms_module = self.user.profile.current_lms_module - + logger.exception(KeyError) super(Profile, self).save(*args, **kwargs) def __str__(self): From 6dcffca202f74eac1281da29ce822ab59454da24 Mon Sep 17 00:00:00 2001 From: auxfuse Date: Wed, 21 Oct 2020 13:32:32 +0100 Subject: [PATCH 2/2] Refactored try/except statement for missing indent and added str type conversion to KeyError log, also linked nav Accountlinks and included if else check for user authenticated or otherwise --- accounts/models.py | 2 +- templates/includes/navbar.html | 12 +++++++----- 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/accounts/models.py b/accounts/models.py index 46b75105..de41cb0d 100644 --- a/accounts/models.py +++ b/accounts/models.py @@ -56,7 +56,7 @@ def save(self, *args, **kwargs): self.slack_display_name = self.user.profile.slack_display_name self.user_type = self.user.profile.user_type self.current_lms_module = self.user.profile.current_lms_module - logger.exception(KeyError) + logger.exception(str(KeyError)) super(Profile, self).save(*args, **kwargs) def __str__(self): diff --git a/templates/includes/navbar.html b/templates/includes/navbar.html index 11949531..2fdba975 100644 --- a/templates/includes/navbar.html +++ b/templates/includes/navbar.html @@ -39,11 +39,13 @@ My Account