Create IBC light clients in IBC scenario#222
Merged
majecty merged 10 commits intoCodeChain-io:ics-pocfrom Mar 3, 2020
Merged
Conversation
added 8 commits
March 2, 2020 17:46
The default deserialized format of Vec<u8> is hard to use. It is an array of numbers like [249, 1, 148, ...]. Change RPCs to return hex string instead.
Each chain in IBC scenario will use its own keystore.
The same config will be used in the IBC scenario.
We created the HelloWorld variable to explain how to use the common code in the ibc.ts directory.
We will add queryRawHeader in the Chain class. To make code clear, I renamed the queryHeader.
To create a light client we need raw bytes of a header. It will be included in the CreateClient datagram.
25 tasks
majecty
force-pushed
the
f/ics-create-client
branch
from
cdfd183 to
bac8a56
Compare
junha1
requested changes
Mar 2, 2020
ibc.ts/src/scenario/index.ts
Outdated
| ); | ||
| debug(`rawHeader is ${counterpartyRawHeader}`); | ||
|
|
||
| assert(counterpartyRawHeader, "headet should not empty"); |
Contributor
There was a problem hiding this comment.
"header should not be empty"
majecty
force-pushed
the
f/ics-create-client
branch
from
bac8a56 to
0fe2a4f
Compare
majecty
force-pushed
the
f/ics-create-client
branch
from
0fe2a4f to
cf70921
Compare
junha1
approved these changes
Mar 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.