From 060c9c11840a02aa2a9cb1aba402efdb042676fc Mon Sep 17 00:00:00 2001 From: CJ Yuan Date: Mon, 19 May 2025 15:25:05 +0100 Subject: [PATCH 1/4] Add a "review not required" note --- README.md | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/README.md b/README.md index acb927df..219ad1b0 100644 --- a/README.md +++ b/README.md @@ -9,3 +9,9 @@ Can you help him to fix or improve the answers to his homework? 3. Create a branch with an appropriate name for the task you're on 3. Fix the errors in Linus's homework in `homework.md` 4. Create a Pull Request back to this repository with the correct answers. Make sure your Pull Request is created in CodeYourFuture's fork, not your personal fork. + + +## How to check your work? +If you have correctly submitted your PR, you can find it in https://github.com/CodeYourFuture/GitHomeworkFixErrors/pulls. + +Please note that your PR will not undergo an official review, as none is required. From d633615bd71c1aea4ca33cce9a5d8447f640f3fa Mon Sep 17 00:00:00 2001 From: CJ Yuan Date: Mon, 19 May 2025 17:06:30 +0100 Subject: [PATCH 2/4] Add new instructions to PR template --- .github/pull_request_template.md | 33 +++++++++++++++++++++----------- 1 file changed, 22 insertions(+), 11 deletions(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 032b8606..ca662155 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -2,24 +2,35 @@ You must title your PR like this: -COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK +REGION | COHORT_NAME | FIRST_NAME LAST_NAME | PROJ_NAME For example, -ITP-OCT-24 | Carol Owen | GitHomeworkFixErrors | Week1 + London | May-2025 | Carol Owen | Sprint-1 -Complete the task list below this message. -If your PR is rejected, check the task list. +--> + +## Learners, PR Template + + -# Your Details +Self checklist + +- [ ] I have titled my PR with REGION | COHORT_NAME | FIRST_NAME LAST_NAME | PROJ_NAME +- [ ] My changes meet the requirements outlined in the `README.md` of this task -- Your Name: -- Your City: -- Your Slack Name: +## Changelist -# Homework Details + +Briefly explain your PR. From 00265b50f183adfc543cf160913517c03e1ce7a9 Mon Sep 17 00:00:00 2001 From: CJ Yuan Date: Mon, 19 May 2025 17:27:35 +0100 Subject: [PATCH 3/4] Update pull_request_template.md --- .github/pull_request_template.md | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index ca662155..c3e0510b 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -11,13 +11,12 @@ For example, --> ## Learners, PR Template - Self checklist @@ -31,6 +30,6 @@ Self checklist When you submit a PR, you're submitting changes you made to your own copy (fork) of the repository and requesting a review of those changes. It is best practice to leave a brief description of the changes you have made. - You must replace "Brief explain your PR." with a brief description of the changes you have made. + You must replace "Briefly explain your PR." with a brief description of the changes you have made. --> Briefly explain your PR. From 589c1a405ee3fb2631614d396be23fb873e9b7e0 Mon Sep 17 00:00:00 2001 From: CJ Yuan Date: Mon, 19 May 2025 17:56:46 +0100 Subject: [PATCH 4/4] Apply Daniel's suggestion Co-authored-by: Daniel Wagner-Hall --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 219ad1b0..f158d4a8 100644 --- a/README.md +++ b/README.md @@ -14,4 +14,4 @@ Can you help him to fix or improve the answers to his homework? ## How to check your work? If you have correctly submitted your PR, you can find it in https://github.com/CodeYourFuture/GitHomeworkFixErrors/pulls. -Please note that your PR will not undergo an official review, as none is required. +Please note that your PR will not undergo an official review, as none is required. Most PRs at CodeYourFuture get reviewed, but this one is just for you to practice creating them.