From 5a20e9db2ae5663752da3b0862744e78ae4d11ac Mon Sep 17 00:00:00 2001 From: sai Date: Fri, 28 Dec 2018 18:33:03 +0530 Subject: [PATCH 1/3] fix(Checkbox): Fix checkbox design bugs --- .../common/componentData/Checkbox/theme.scss | 8 ++++---- lib/checkbox/theme.module.scss | 11 ++++++++--- 2 files changed, 12 insertions(+), 7 deletions(-) diff --git a/doc/src/components/common/componentData/Checkbox/theme.scss b/doc/src/components/common/componentData/Checkbox/theme.scss index a953d911..71eac0e7 100644 --- a/doc/src/components/common/componentData/Checkbox/theme.scss +++ b/doc/src/components/common/componentData/Checkbox/theme.scss @@ -3,16 +3,16 @@ } :local(.checkbox) { - border-color: #6b76ff; + border-color: #8b104e; .check-item { - border-color: #6b76ff !important; + border-color: #8b104e !important; } } :local(.inverted) { - background-color: #0b409c !important; + background-color: #8b104e !important; .check-item { - border-color: #f18a9b !important; + border-color: #fefefe !important; } } \ No newline at end of file diff --git a/lib/checkbox/theme.module.scss b/lib/checkbox/theme.module.scss index e86e2765..95c7cbcc 100644 --- a/lib/checkbox/theme.module.scss +++ b/lib/checkbox/theme.module.scss @@ -1,14 +1,20 @@ @import '../globals/theme.scss'; :local(.checkbox) { + display: inline-block; background-color: $secondary-white; padding: 2px; - border: 1px solid $secondary-blue; + border: 2px solid $secondary-blue; + height: 25px; + width: 25px; + box-sizing: border-box; + border-radius: 3px; &:hover { cursor: pointer; } input { /* Disable the HTML input */ opacity: 0; + margin: 0; } /* Fixes width issue in safari */ @media not all and (min-resolution:.001dpcm) { @@ -24,14 +30,13 @@ } :local(.checked) { - height: 200px; position: relative; .check-item { /* Check Item adds the tick */ /* Builds a rectange with border width and rotates it 45 Degree */ position: absolute; left: 32%; - top: 12%; + top: 10%; width: 5px; height: 12px; border: solid $secondary-blue; From 8112cdfdee8cdfde9a885e48570d6817701b595f Mon Sep 17 00:00:00 2001 From: sai Date: Mon, 31 Dec 2018 10:51:11 +0530 Subject: [PATCH 2/3] fix(Checkbox): fix cursor pointer issue on checkbox #287 --- lib/checkbox/theme.module.scss | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/lib/checkbox/theme.module.scss b/lib/checkbox/theme.module.scss index 95c7cbcc..36690a14 100644 --- a/lib/checkbox/theme.module.scss +++ b/lib/checkbox/theme.module.scss @@ -8,13 +8,12 @@ width: 25px; box-sizing: border-box; border-radius: 3px; - &:hover { - cursor: pointer; - } + cursor: pointer; input { /* Disable the HTML input */ opacity: 0; margin: 0; + cursor: pointer; } /* Fixes width issue in safari */ @media not all and (min-resolution:.001dpcm) { From d9faff5bd19daffb99d5f480a6d838916d74f2ec Mon Sep 17 00:00:00 2001 From: sai Date: Mon, 31 Dec 2018 16:28:35 +0530 Subject: [PATCH 3/3] fix(Checkbox): fix checked state position --- lib/checkbox/theme.module.scss | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/checkbox/theme.module.scss b/lib/checkbox/theme.module.scss index 36690a14..3975e89e 100644 --- a/lib/checkbox/theme.module.scss +++ b/lib/checkbox/theme.module.scss @@ -35,7 +35,7 @@ /* Builds a rectange with border width and rotates it 45 Degree */ position: absolute; left: 32%; - top: 10%; + top: 5%; width: 5px; height: 12px; border: solid $secondary-blue;