From e3da43945c9266a0979a73364340a9b18c42bea9 Mon Sep 17 00:00:00 2001 From: girishkrishaweb Date: Mon, 26 Apr 2021 14:32:51 +0530 Subject: [PATCH 1/2] Fix PHP 8 warning #795 --- classes/Visualizer/Source.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/classes/Visualizer/Source.php b/classes/Visualizer/Source.php index 879e73cc5..4dd801add 100644 --- a/classes/Visualizer/Source.php +++ b/classes/Visualizer/Source.php @@ -335,7 +335,7 @@ public static final function get_date_formats_if_exists( $series, $data ) { * * @return string|null */ - private static final function determine_date_format( $value, $type ) { + private static function determine_date_format( $value, $type ) { if ( version_compare( phpversion(), '5.3.0', '<' ) ) { do_action( 'themeisle_log_event', Visualizer_Plugin::NAME, sprintf( 'PHP version %s not supported', phpversion() ), 'error', __FILE__, __LINE__ ); return null; From 86a741012bc49c3c685d470f2291be69346e2782 Mon Sep 17 00:00:00 2001 From: girishkrishaweb Date: Tue, 4 May 2021 18:24:50 +0530 Subject: [PATCH 2/2] Fix undefined array index warning in PHP 8 #795 --- classes/Visualizer/Render/Sidebar/Google.php | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/classes/Visualizer/Render/Sidebar/Google.php b/classes/Visualizer/Render/Sidebar/Google.php index af55567a2..77d0d43fe 100644 --- a/classes/Visualizer/Render/Sidebar/Google.php +++ b/classes/Visualizer/Render/Sidebar/Google.php @@ -208,7 +208,7 @@ protected function _renderGeneralSettings() { self::_renderSelectItem( esc_html__( 'Position', 'visualizer' ), 'legend[position]', - $this->legend['position'], + isset( $this->legend['position'] ) ? $this->legend['position'] : '', $this->_legendPositions, esc_html__( 'Determines where to place the legend, compared to the chart area.', 'visualizer' ) ); @@ -216,7 +216,7 @@ protected function _renderGeneralSettings() { self::_renderSelectItem( esc_html__( 'Alignment', 'visualizer' ), 'legend[alignment]', - $this->legend['alignment'], + isset( $this->legend['alignment'] ) ? $this->legend['alignment'] : '', $this->_alignments, esc_html__( 'Determines the alignment of the legend.', 'visualizer' ) ); @@ -393,10 +393,12 @@ protected function _renderViewSettings() { echo ''; echo ''; echo ''; echo ''; echo ''; echo '
'; - echo ''; + $chartarea_left = isset( $this->chartArea['left'] ) ? $this->chartArea['left'] : ''; + echo ''; echo ''; - echo ''; + $chartarea_top = isset( $this->chartArea['top'] ) ? $this->chartArea['top'] : ''; + echo ''; echo '
';