From 4f88479a2115c9ccc9dfc4df89d00c0c425eac0c Mon Sep 17 00:00:00 2001
From: michael-hawker <24302614+michael-hawker@users.noreply.github.com>
Date: Thu, 3 Aug 2023 10:32:47 -0700
Subject: [PATCH] Another fix for the Converters ProjectReference logic

We need to add the Converters when running in Single Component mode,
as it's only included in the all-up sample app locally (when source defined).

We also need to exclude if we're building the Converters project itself.

However, if a component itself relies on the converters and we try and to build
on Linux we'll hit the original issue. Workaround for now there is to build
all-up sample app instead...

Tested locally that the Converters and another component both could be built now.
---
 ProjectHeads/App.Head.props | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

diff --git a/ProjectHeads/App.Head.props b/ProjectHeads/App.Head.props
index 08f3326b..ec58a459 100644
--- a/ProjectHeads/App.Head.props
+++ b/ProjectHeads/App.Head.props
@@ -29,13 +29,16 @@
         <PackageReference Include="CommunityToolkit.$(DependencyVariant).Converters" Version="8.0.230801-preview"/>
       </ItemGroup>
     </When>
-    <Otherwise>
+    <!-- This is tripping up the linux build using dotnet build as we have a duplicate reference 
+        auto-generated in tooling/MultiTarget/Generated when building the all-up sample app -->
+    <!-- See: https://github.com/dotnet/msbuild/issues/2688 -->
+    <!-- TODO: We need to handle a case where a component itself references the converter package... -->
+    <!-- Only add Converters reference if we're in a single experiment that's not the Converters project itself -->
+    <When Condition="'$(IsSingleExperimentHead)' == 'true' and $(MSBuildProjectName.StartsWith('Converters')) == 'false'">
       <ItemGroup>
-        <!-- This is tripping up the linux build using dotnet build as we have a duplicate reference auto-generated in tooling/MultiTarget/Generated -->
-        <!-- See: https://github.com/dotnet/msbuild/issues/2688 -->
-        <!--<ProjectReference Include="$(ToolkitConvertersSourceProject)"/>-->
+        <ProjectReference Include="$(ToolkitConvertersSourceProject)"/>
       </ItemGroup>
-    </Otherwise>
+    </When>
   </Choose>
 
   <!-- See https://github.com/CommunityToolkit/Labs-Windows/issues/142 -->