From 09871d6e9a00bec4f635671b7f0ff83dbec51c29 Mon Sep 17 00:00:00 2001 From: Vojtech Polasek Date: Thu, 4 Feb 2021 15:40:06 +0100 Subject: [PATCH 1/2] fix wrong list declaration --- release_tools/content_gh.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/release_tools/content_gh.py b/release_tools/content_gh.py index 38d595123020..e9d9b5731f1b 100755 --- a/release_tools/content_gh.py +++ b/release_tools/content_gh.py @@ -82,8 +82,9 @@ def close_milestone(milestone): def get_closed_prs(repo, milestone): closed_issues = repo.get_issues(milestone=milestone, state="closed", sort="updated") issues_with_prs = [i for i in closed_issues if i.pull_request is not None] - merged_prs = - [i.as_pull_request() for i in issues_with_prs if i.as_pull_request().merged is True] + merged_prs = [ + i.as_pull_request() for i in issues_with_prs if i.as_pull_request().merged is True + ] return merged_prs From c103175d6230b9cfec3a92c9ae0b53ee4a308077 Mon Sep 17 00:00:00 2001 From: Vojtech Polasek Date: Thu, 4 Feb 2021 15:49:06 +0100 Subject: [PATCH 2/2] fix typos --- release_tools/README.md | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/release_tools/README.md b/release_tools/README.md index 23c0b0e7210f..40d1f15021a9 100644 --- a/release_tools/README.md +++ b/release_tools/README.md @@ -149,18 +149,18 @@ Everything necessary for the release is built in Jenkins: You can run `python3 release_content.py build` again to check status of the jobs. NOTE: As of July-20th 2019, it takes about 44 minutes for all the - builds finish. + builds to finish. While Jenkins performs the builds you can generate and review the release notes: - Run `python3 release_content.py release_notes` -Format of the release notes are as follows: +Format of the release notes is as follows: At the top Highlighted PRs will be listed, followed by list of product’s profiles that changed since last release. -Followed by a list of *relevant* changes, genereated from the Pull -Requests mereged in this release. +Followed by a list of *relevant* changes, generated from the Pull +Requests merged in this release. Not all PRs have an entry to avoid over cluttering. To determine the *relevant* PRs a few heuristics are applied: @@ -184,9 +184,9 @@ reviewed. We move on to creating the release entry in GitHub: - Run `python3 release_content.py release` - It will create the next milestone (if it doens’t exist yet), move + It will create the next milestone (if it doesn’t exist yet), move any open issues and PRs from current - milestone to next milesone, and close current release’s milestone. + milestone to next milestone, and close current release’s milestone. The assets from Jenkins builds and the release notes will be used to create the git release. **Review the Git Release** and publish it.