From 824e784a41a2b7a1908778dbd7576642e5bae9fd Mon Sep 17 00:00:00 2001 From: MinHo Lim Date: Thu, 24 Jul 2025 15:32:10 +0900 Subject: [PATCH 1/3] fix applyRaws --- src/display/mixins/Base.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/display/mixins/Base.js b/src/display/mixins/Base.js index 8d53010c..166fb913 100644 --- a/src/display/mixins/Base.js +++ b/src/display/mixins/Base.js @@ -131,7 +131,7 @@ export const Base = (superClass) => { _applyRaw(attrs, mergeStrategy) { for (const [key, value] of Object.entries(attrs)) { if (value === undefined) { - if (key !== 'id') { + if (key !== 'id' && key !== 'label') { delete this[key]; } continue; From 07b741ecbd768f4ac87e732a742759956dc258d2 Mon Sep 17 00:00:00 2001 From: MinHo Lim Date: Thu, 24 Jul 2025 15:44:00 +0900 Subject: [PATCH 2/3] fix --- src/display/mixins/Base.js | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/display/mixins/Base.js b/src/display/mixins/Base.js index 166fb913..b5baa4c6 100644 --- a/src/display/mixins/Base.js +++ b/src/display/mixins/Base.js @@ -134,10 +134,7 @@ export const Base = (superClass) => { if (key !== 'id' && key !== 'label') { delete this[key]; } - continue; - } - - if (key === 'x' || key === 'y') { + } else if (key === 'x' || key === 'y') { const x = key === 'x' ? value : (attrs?.x ?? this.x); const y = key === 'y' ? value : (attrs?.y ?? this.y); this.position.set(x, y); From 25b71406aa70b957745aa62e925d0947cf413c5a Mon Sep 17 00:00:00 2001 From: MinHo Lim Date: Thu, 24 Jul 2025 15:52:00 +0900 Subject: [PATCH 3/3] fix --- src/display/mixins/Base.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/display/mixins/Base.js b/src/display/mixins/Base.js index b5baa4c6..e896e354 100644 --- a/src/display/mixins/Base.js +++ b/src/display/mixins/Base.js @@ -131,7 +131,7 @@ export const Base = (superClass) => { _applyRaw(attrs, mergeStrategy) { for (const [key, value] of Object.entries(attrs)) { if (value === undefined) { - if (key !== 'id' && key !== 'label') { + if (!['id', 'label'].includes(key)) { delete this[key]; } } else if (key === 'x' || key === 'y') {