From 6c0d2c347386fbe3fdb78a316879512c39123414 Mon Sep 17 00:00:00 2001 From: Ahmad Mudaafi Date: Wed, 7 Feb 2024 04:58:03 +0800 Subject: [PATCH 1/2] fix autocomplete tests due to schema change --- tests/modules/test_autocomplete.py | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/tests/modules/test_autocomplete.py b/tests/modules/test_autocomplete.py index 6b7dea8..4b0315d 100644 --- a/tests/modules/test_autocomplete.py +++ b/tests/modules/test_autocomplete.py @@ -117,11 +117,16 @@ def test_with_valid_query_and_filters(): filters = { 'keywords': ['battery-powered'] } autocomplete = ConstructorIO(VALID_OPTIONS).autocomplete response = autocomplete.get_autocomplete_results(QUERY, { 'filters': filters }) + expected_filters = filters.copy() + expected_filters['Content'] = filters + expected_filters['Search Suggestions'] = filters + expected_filters['Products'] = filters assert isinstance(response.get('request'), dict) assert isinstance(response.get('sections'), dict) assert isinstance(response.get('result_id'), str) - assert response.get('request').get('filters') == filters + assert response.get('request').get('filters') == expected_filters + print(response) def test_with_valid_query_and_multiple_filters(): '''Should return a response with a valid query and multiple filters''' @@ -129,11 +134,15 @@ def test_with_valid_query_and_multiple_filters(): filters = { 'group_id': ['All'], 'Brand': ['XYZ'] } autocomplete = ConstructorIO(VALID_OPTIONS).autocomplete response = autocomplete.get_autocomplete_results(QUERY, { 'filters': filters }) + expected_filters = filters.copy() + expected_filters['Content'] = filters + expected_filters['Search Suggestions'] = filters + expected_filters['Products'] = filters assert isinstance(response.get('request'), dict) assert isinstance(response.get('sections'), dict) assert isinstance(response.get('result_id'), str) - assert response.get('request').get('filters') == filters + assert response.get('request').get('filters') == expected_filters assert len(response.get('sections').get('Products')) >= 1 def test_with_valid_query_and_user_ip(): From b422adb70324e8e5944f415102e615430d3ebf99 Mon Sep 17 00:00:00 2001 From: Ahmad Mudaafi Date: Wed, 7 Feb 2024 06:01:19 +0800 Subject: [PATCH 2/2] lint --- tests/modules/test_autocomplete.py | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/modules/test_autocomplete.py b/tests/modules/test_autocomplete.py index 4b0315d..787ade9 100644 --- a/tests/modules/test_autocomplete.py +++ b/tests/modules/test_autocomplete.py @@ -126,7 +126,6 @@ def test_with_valid_query_and_filters(): assert isinstance(response.get('sections'), dict) assert isinstance(response.get('result_id'), str) assert response.get('request').get('filters') == expected_filters - print(response) def test_with_valid_query_and_multiple_filters(): '''Should return a response with a valid query and multiple filters'''