From 4c5350ec22256d4d48418bd780a40a413de70747 Mon Sep 17 00:00:00 2001 From: Enes Kutay SEZEN Date: Tue, 20 Aug 2024 16:08:57 +0300 Subject: [PATCH 1/2] Update quiz_version_id tests --- tests/modules/test_quizzes.py | 19 ++++++++++++++----- 1 file changed, 14 insertions(+), 5 deletions(-) diff --git a/tests/modules/test_quizzes.py b/tests/modules/test_quizzes.py index e6e3fed..5bfcab1 100644 --- a/tests/modules/test_quizzes.py +++ b/tests/modules/test_quizzes.py @@ -11,7 +11,6 @@ TEST_API_KEY = environ['TEST_REQUEST_API_KEY'] TEST_API_TOKEN = environ['TEST_API_TOKEN'] QUIZ_ID = 'test-quiz' -QUIZ_VERSION_ID = 'e03210db-0cc6-459c-8f17-bf014c4f554d' QUIZ_SESSION_ID = 'ca380401-3805-4ded-8f28-638e5a4baa92' VALID_QUIZ_ANS = [[1], [1, 2], ['seen']] VALID_OPTIONS = { 'api_key': TEST_API_KEY, 'api_token': TEST_API_TOKEN} @@ -31,13 +30,18 @@ def test_get_quiz_next_question_should_respond_with_matching_parameters(): '''Should return a response with a matching quiz_id, quiz_version_id, quiz_session_id''' quizzes = ConstructorIO(VALID_OPTIONS).quizzes + initial_response = quizzes.get_quiz_next_question(QUIZ_ID, { + 'quiz_session_id': QUIZ_SESSION_ID + }) + quiz_version_id = initial_response.get('quiz_version_id') + response = quizzes.get_quiz_next_question(QUIZ_ID, { - 'quiz_version_id': QUIZ_VERSION_ID, + 'quiz_version_id': quiz_version_id, 'quiz_session_id': QUIZ_SESSION_ID }) assert response.get('quiz_id') == QUIZ_ID - assert response.get('quiz_version_id') == QUIZ_VERSION_ID + assert response.get('quiz_version_id') == quiz_version_id assert response.get('quiz_session_id') == QUIZ_SESSION_ID def test_get_quiz_next_question_with_answer_parameter(): @@ -109,13 +113,18 @@ def test_get_quiz_results_should_respond_with_matching_parameters(): '''Should return a response with a matching quiz_id, quiz_version_id, quiz_session_id''' quizzes = ConstructorIO(VALID_OPTIONS).quizzes + initial_response = quizzes.get_quiz_next_question(QUIZ_ID, { + 'quiz_session_id': QUIZ_SESSION_ID + }) + quiz_version_id = initial_response.get('quiz_version_id') + res = quizzes.get_quiz_results(QUIZ_ID, { 'answers': VALID_QUIZ_ANS, - 'quiz_version_id': QUIZ_VERSION_ID, + 'quiz_version_id': quiz_version_id, 'quiz_session_id': QUIZ_SESSION_ID}) assert res.get('quiz_id') == QUIZ_ID - assert res.get('quiz_version_id') == QUIZ_VERSION_ID + assert res.get('quiz_version_id') == quiz_version_id assert res.get('quiz_session_id') == QUIZ_SESSION_ID def test_get_quiz_results_with_no_quiz_id(): From 011166b4d09fb0bdcceb52dd8c7afd0ed13e4b7e Mon Sep 17 00:00:00 2001 From: Enes Kutay SEZEN Date: Tue, 20 Aug 2024 16:17:49 +0300 Subject: [PATCH 2/2] Update failing test --- tests/modules/test_browse.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/modules/test_browse.py b/tests/modules/test_browse.py index ef09488..507aca3 100644 --- a/tests/modules/test_browse.py +++ b/tests/modules/test_browse.py @@ -326,7 +326,7 @@ def test_get_browse_results_with_valid_filter_name_filter_value_and_hidden_facet assert isinstance(response.get('response'), dict) assert isinstance(response.get('result_id'), str) assert response.get('request').get('fmt_options').get('hidden_facets') == hidden_facets - assert response.get('response').get('facets')[0].get('name') == hidden_facets[0] + assert any(facet.get('name') == hidden_facets[0] for facet in response.get('response').get('facets')) def test_get_browse_results_with_valid_filter_name_filter_value_and_variations_map(): '''Should return a response with a valid filter_name, filter_value, section, and variations_map''' # pylint: disable=line-too-long