fix(mcp): clear type field during transport switching

Fix partial update bug where type field is not cleared when switching
between command-based and URL-based server configurations. Ensure type
field is updated to match the new transport configuration.

When switching from command to URL: type changes from 'stdio' to 'sse'
When switching from URL to command: type changes from 'sse' to 'stdio'

Includes 2 new tests validating type field updates and 2 modified tests
adding type field assertions to existing switching tests.

Fixes: Issue 1 - Type field not updated during transport switching

Author: LittleCoinCoin

hatch/cli_hatch.py

@@ -733,11 +733,13 @@ def handle_mcp_configure(host: str, server_name: str, command: str, args: list,
             if url is not None and existing_config.command is not None:
                 existing_data.pop('command', None)
                 existing_data.pop('args', None)
+                existing_data.pop('type', None)  # Clear type field when switching transports (Issue 1)
 
             # If switching from URL to command: clear URL-based fields
             if command is not None and existing_config.url is not None:
                 existing_data.pop('url', None)
                 existing_data.pop('headers', None)
+                existing_data.pop('type', None)  # Clear type field when switching transports (Issue 1)
 
             # Merge: new values override existing values
             merged_data = {**existing_data, **omni_config_data}

tests/test_mcp_cli_partial_updates.py

@@ -460,9 +460,9 @@ def test_configure_switch_command_to_url(self):
             mock_manager.configure_server.return_value = MagicMock(success=True)
 
             with patch('hatch.cli_hatch.print') as mock_print:
-                # Execute: Switch to URL-based
+                # Execute: Switch to URL-based (use gemini which supports URL)
                 result = handle_mcp_configure(
-                    host="claude-desktop",
+                    host="gemini",
                     server_name="test-server",
                     command=None,
                     args=None,
@@ -493,6 +493,8 @@ def test_configure_switch_command_to_url(self):
                 # Command-based fields cleared
                 self.assertIsNone(omni_config.command)
                 self.assertIsNone(omni_config.args)
+                # Type field updated to 'sse' (Issue 1)
+                self.assertEqual(omni_config.type, "sse")
 
     @regression_test
     def test_configure_switch_url_to_command(self):
@@ -511,9 +513,9 @@ def test_configure_switch_url_to_command(self):
             mock_manager.configure_server.return_value = MagicMock(success=True)
 
             with patch('hatch.cli_hatch.print') as mock_print:
-                # Execute: Switch to command-based
+                # Execute: Switch to command-based (use gemini which supports both)
                 result = handle_mcp_configure(
-                    host="claude-desktop",
+                    host="gemini",
                     server_name="test-server",
                     command="node",  # Provide command
                     args=["server.js"],  # Provide args
@@ -544,6 +546,8 @@ def test_configure_switch_url_to_command(self):
                 # URL-based fields cleared
                 self.assertIsNone(omni_config.url)
                 self.assertIsNone(omni_config.headers)
+                # Type field updated to 'stdio' (Issue 1)
+                self.assertEqual(omni_config.type, "stdio")
 
 
 class TestPartialUpdateIntegration(unittest.TestCase):
@@ -746,6 +750,110 @@ def test_error_messages_remain_clear(self):
                 )
 
 
+class TestTypeFieldUpdating(unittest.TestCase):
+    """Test suite for type field updates during transport switching (Issue 1)."""
+
+    @regression_test
+    def test_type_field_updates_command_to_url(self):
+        """Test type field updates from 'stdio' to 'sse' when switching to URL."""
+        # Setup: Create existing command-based server with type='stdio'
+        existing_server = MCPServerConfig(
+            name="test-server",
+            type="stdio",
+            command="python",
+            args=["server.py"]
+        )
+
+        with patch('hatch.cli_hatch.MCPHostConfigurationManager') as mock_manager_class:
+            mock_manager = MagicMock()
+            mock_manager_class.return_value = mock_manager
+            mock_manager.get_server_config.return_value = existing_server
+            mock_manager.configure_server.return_value = MagicMock(success=True)
+
+            with patch('hatch.cli_hatch.print'):
+                # Execute: Switch to URL-based configuration
+                result = handle_mcp_configure(
+                    host='gemini',
+                    server_name='test-server',
+                    command=None,
+                    args=None,
+                    env=None,
+                    url='http://localhost:8080',
+                    headers=None,
+                    timeout=None,
+                    trust=False,
+                    cwd=None,
+                    env_file=None,
+                    http_url=None,
+                    include_tools=None,
+                    exclude_tools=None,
+                    inputs=None,
+                    no_backup=False,
+                    dry_run=False,
+                    auto_approve=True
+                )
+
+                # Validate: Should succeed
+                self.assertEqual(result, 0)
+
+                # Validate: Type field updated to 'sse'
+                call_args = mock_manager.configure_server.call_args
+                server_config = call_args.kwargs['server_config']
+                self.assertEqual(server_config.type, "sse")
+                self.assertIsNone(server_config.command)
+                self.assertEqual(server_config.url, "http://localhost:8080")
+
+    @regression_test
+    def test_type_field_updates_url_to_command(self):
+        """Test type field updates from 'sse' to 'stdio' when switching to command."""
+        # Setup: Create existing URL-based server with type='sse'
+        existing_server = MCPServerConfig(
+            name="test-server",
+            type="sse",
+            url="http://localhost:8080",
+            headers={"Authorization": "Bearer token"}
+        )
+
+        with patch('hatch.cli_hatch.MCPHostConfigurationManager') as mock_manager_class:
+            mock_manager = MagicMock()
+            mock_manager_class.return_value = mock_manager
+            mock_manager.get_server_config.return_value = existing_server
+            mock_manager.configure_server.return_value = MagicMock(success=True)
+
+            with patch('hatch.cli_hatch.print'):
+                # Execute: Switch to command-based configuration
+                result = handle_mcp_configure(
+                    host='gemini',
+                    server_name='test-server',
+                    command='python',
+                    args=['server.py'],
+                    env=None,
+                    url=None,
+                    headers=None,
+                    timeout=None,
+                    trust=False,
+                    cwd=None,
+                    env_file=None,
+                    http_url=None,
+                    include_tools=None,
+                    exclude_tools=None,
+                    inputs=None,
+                    no_backup=False,
+                    dry_run=False,
+                    auto_approve=True
+                )
+
+                # Validate: Should succeed
+                self.assertEqual(result, 0)
+
+                # Validate: Type field updated to 'stdio'
+                call_args = mock_manager.configure_server.call_args
+                server_config = call_args.kwargs['server_config']
+                self.assertEqual(server_config.type, "stdio")
+                self.assertEqual(server_config.command, "python")
+                self.assertIsNone(server_config.url)
+
+
 if __name__ == '__main__':
     unittest.main()