From cbc848ed35047a465c70fac21fc08520481a7466 Mon Sep 17 00:00:00 2001 From: Douglas J Hunley Date: Wed, 16 Jun 2021 09:54:58 -0400 Subject: [PATCH 1/7] fix: typo spotted by @pgguru --- .github/CODEOWNERS | 2 +- .github/ISSUE_TEMPLATE/bug_report.md | 12 ++++++------ .github/ISSUE_TEMPLATE/feature_request.md | 2 +- .github/pull_request_template.md | 15 ++++++++------- 4 files changed, 16 insertions(+), 15 deletions(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index d82eae68..7c1964c6 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -1 +1 @@ -* @hunleyd @keithf4 @sharmay +* @hunleyd @keithf4 @pgguru @sharmay diff --git a/.github/ISSUE_TEMPLATE/bug_report.md b/.github/ISSUE_TEMPLATE/bug_report.md index a9ebcb84..2f5b804a 100644 --- a/.github/ISSUE_TEMPLATE/bug_report.md +++ b/.github/ISSUE_TEMPLATE/bug_report.md @@ -2,7 +2,7 @@ name: Bug report about: Create a report to help us improve title: '' -labels: 'STATUS: UNCONFIRMED' +labels: 'UNCONFIRMED' assignees: '' --- @@ -14,9 +14,9 @@ assignees: '' **Tell us about your environment:** -- pgMonitor Version: -- PostgreSQL Version: - Operating System: -- Exporter in use: -- Virtualization: -- Any customization: +- PostgreSQL Version: +- Ansible Version: +- Roles version or branch: +- Inventory and Playbook (names): +- Changes to stock Roles, Inventory, Playbook: diff --git a/.github/ISSUE_TEMPLATE/feature_request.md b/.github/ISSUE_TEMPLATE/feature_request.md index aa488a64..c0373a7f 100644 --- a/.github/ISSUE_TEMPLATE/feature_request.md +++ b/.github/ISSUE_TEMPLATE/feature_request.md @@ -2,7 +2,7 @@ name: Feature request about: Suggest an enhancement for this project title: '' -labels: 'STATUS: UNCONFIRMED' +labels: 'UNCONFIRMED' assignees: '' --- diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 14c68239..b64a2c76 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -2,9 +2,9 @@ Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change. -Fixes (issue) # +Fixes # -Depends on (issue) # +Depends on # ## Type of change Please check all options that are relevant @@ -14,16 +14,17 @@ Please check all options that are relevant - [ ] Documentation update only # How Has This Been Tested? - **Tested Configuration**: -- [ ] CentOS, Specify version(s): -- [ ] PostgreQL, Specify version(s): -- [ ] docs tested with hugo <0.60 +- [ ] Ansible, Specify version(s): +- [ ] Specify Distro & version(s): +- [ ] Specify Repo Distro & version(s): +- [ ] PostgreSQL, Specify version(s): +- [ ] docs tested with hugo version(s): Tested with playbook(s): # Checklist: +- [ ] My changes generate no new lint warnings - I have made corresponding changes to: - [ ] the documentation - [ ] the release notes - [ ] the upgrade doc - From 10dd7d61631f1f79c1f7e70bf1294a713b1bc214 Mon Sep 17 00:00:00 2001 From: Douglas J Hunley Date: Wed, 16 Jun 2021 10:01:49 -0400 Subject: [PATCH 2/7] fix: feedback from keith and yogesh --- .github/ISSUE_TEMPLATE/bug_report.md | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/bug_report.md b/.github/ISSUE_TEMPLATE/bug_report.md index 2f5b804a..6e51ef30 100644 --- a/.github/ISSUE_TEMPLATE/bug_report.md +++ b/.github/ISSUE_TEMPLATE/bug_report.md @@ -14,9 +14,12 @@ assignees: '' **Tell us about your environment:** -- Operating System: +- pgMonitor version: +- Container or non-container: +- Container name / image: +- Operating System for non-container: - PostgreSQL Version: -- Ansible Version: -- Roles version or branch: -- Inventory and Playbook (names): -- Changes to stock Roles, Inventory, Playbook: +- Exporter in use: +- Prometheus version: +- AlertManager version: +- Grafana version: From 9825fd03e89dc32697a4691f6a714e11d43056bc Mon Sep 17 00:00:00 2001 From: Douglas J Hunley Date: Mon, 21 Jun 2021 10:28:25 -0400 Subject: [PATCH 3/7] fix: feedback from keith --- .github/pull_request_template.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index b64a2c76..f5f6f3d1 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -17,7 +17,7 @@ Please check all options that are relevant **Tested Configuration**: - [ ] Ansible, Specify version(s): - [ ] Specify Distro & version(s): -- [ ] Specify Repo Distro & version(s): +- [ ] Specify Package distro & version(s): - [ ] PostgreSQL, Specify version(s): - [ ] docs tested with hugo version(s): From 6f5934d723a253adc080ca0c0a3685d85fe6af50 Mon Sep 17 00:00:00 2001 From: Douglas J Hunley Date: Mon, 21 Jun 2021 10:29:42 -0400 Subject: [PATCH 4/7] fix: feedback from keith --- .github/pull_request_template.md | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index f5f6f3d1..ba8dc261 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -18,6 +18,7 @@ Please check all options that are relevant - [ ] Ansible, Specify version(s): - [ ] Specify Distro & version(s): - [ ] Specify Package distro & version(s): +- [ ] Packages compiled from source & their version: - [ ] PostgreSQL, Specify version(s): - [ ] docs tested with hugo version(s): From f286a8b1bb3b644133a554dcb0d27b854bec8c23 Mon Sep 17 00:00:00 2001 From: Douglas J Hunley Date: Tue, 22 Jun 2021 08:20:02 -0400 Subject: [PATCH 5/7] fix: pr feedback --- .github/pull_request_template.md | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index ba8dc261..96acbe48 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -16,13 +16,17 @@ Please check all options that are relevant # How Has This Been Tested? **Tested Configuration**: - [ ] Ansible, Specify version(s): -- [ ] Specify Distro & version(s): -- [ ] Specify Package distro & version(s): -- [ ] Packages compiled from source & their version: +- Installation method: + - [ ] Binary install from source, version: + - [ ] OS ackage repository, distro and version: + - [ ] Local package session, version: + - [ ] Custom-built package, version: + - [ ] Other: - [ ] PostgreSQL, Specify version(s): - [ ] docs tested with hugo version(s): Tested with playbook(s): + # Checklist: - [ ] My changes generate no new lint warnings - I have made corresponding changes to: From 57e57cd6ed0e214190c612539169f271bb54ee4c Mon Sep 17 00:00:00 2001 From: Douglas J Hunley Date: Wed, 23 Jun 2021 09:08:37 -0400 Subject: [PATCH 6/7] fix: pr feedback --- .github/pull_request_template.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 96acbe48..cd1127d0 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -18,8 +18,8 @@ Please check all options that are relevant - [ ] Ansible, Specify version(s): - Installation method: - [ ] Binary install from source, version: - - [ ] OS ackage repository, distro and version: - - [ ] Local package session, version: + - [ ] OS package repository, distro, and version: + - [ ] Local package server, version: - [ ] Custom-built package, version: - [ ] Other: - [ ] PostgreSQL, Specify version(s): From 3d2d0f09265148bbb0c3358af50e1011fe6afda1 Mon Sep 17 00:00:00 2001 From: Douglas J Hunley Date: Fri, 23 Jul 2021 11:06:06 -0400 Subject: [PATCH 7/7] fix: feedback from yogesh --- .github/ISSUE_TEMPLATE/bug_report.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/bug_report.md b/.github/ISSUE_TEMPLATE/bug_report.md index 6e51ef30..0b65e821 100644 --- a/.github/ISSUE_TEMPLATE/bug_report.md +++ b/.github/ISSUE_TEMPLATE/bug_report.md @@ -19,7 +19,7 @@ assignees: '' - Container name / image: - Operating System for non-container: - PostgreSQL Version: -- Exporter in use: +- Exporter(s) in use (incl. version): - Prometheus version: - AlertManager version: - Grafana version: