From 1757cf407a967b4c5a9d35fa061aa854e5c6ff78 Mon Sep 17 00:00:00 2001 From: Alex Noir Date: Sun, 26 Jan 2025 23:34:38 +0300 Subject: [PATCH 1/2] Fix advtools convo using the wrong talk_choice_type for creating new convo option, resulting in a nil value being passed --- internal/advtools/convo.lua | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/internal/advtools/convo.lua b/internal/advtools/convo.lua index d8b9b06a37..2b66a4ed66 100644 --- a/internal/advtools/convo.lua +++ b/internal/advtools/convo.lua @@ -81,7 +81,7 @@ local function addWhereaboutsChoice(race, name, target_id, heard_of) if heard_of then title = title .. " (Heard of)" end - local choice = new_choice(df.talk_choice_type.AskWhereabouts, title, dfhack.translation.translateName(name):split()) + local choice = new_choice(df.talk_choice_type.AskForDirectionsToHF, title, dfhack.translation.translateName(name):split()) -- insert before the last choice, which is usually "back" adventure.conversation.conv_choice_info:insert(#adventure.conversation.conv_choice_info-1, choice) choice.choice.invocation_target_hfid = target_id From 791096c5425b03ce293991f05fe90db6159213b2 Mon Sep 17 00:00:00 2001 From: Myk Date: Sun, 26 Jan 2025 20:21:51 -0800 Subject: [PATCH 2/2] Update changelog --- changelog.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/changelog.txt b/changelog.txt index fe674b7019..f28a5bbcbb 100644 --- a/changelog.txt +++ b/changelog.txt @@ -27,12 +27,12 @@ Template for new versions: # Future ## New Tools - - `autocheese`: automatically make cheese using barrels that have accumulated sufficient milk ## New Features ## Fixes +- `advtools`: fix dfhack-added conversation options not appearing in the ask whereabouts conversation tree ## Misc Improvements - `assign-preferences`: new ``--show`` option to display the preferences of the selected unit