From d4ce473dad1393b85fe809694145e58ef58b89f0 Mon Sep 17 00:00:00 2001 From: Sascha Doemer Date: Sun, 19 Dec 2021 13:11:30 +0100 Subject: [PATCH 1/2] Remove log4j to reduce external dependencies (regarding implementations). Switch to SLF4J to use a top level logging interface. --- agrirouter-sdk-java-api/pom.xml | 8 ------ ...gingEnabledService.java => HasLogger.java} | 28 +++++++------------ .../api/service/ParameterValidation.java | 18 +++--------- .../api/service/RequestLogging.java | 8 ++---- .../agrirouter/impl/EnvironmentalService.java | 4 +-- .../impl/NonEnvironmentalService.java | 4 +-- .../signing/SecurityKeyCreationService.java | 4 +-- .../common/ssl/KeyStoreCreationService.java | 4 +-- .../impl/messaging/MessageEncoder.java | 4 +-- .../onboard/AbstractOnboardingService.java | 5 ---- .../impl/validation/ResponseValidator.java | 27 ++++++++---------- pom.xml | 20 +++++++------ 12 files changed, 49 insertions(+), 85 deletions(-) rename agrirouter-sdk-java-api/src/main/java/com/dke/data/agrirouter/api/service/{LoggingEnabledService.java => HasLogger.java} (50%) diff --git a/agrirouter-sdk-java-api/pom.xml b/agrirouter-sdk-java-api/pom.xml index 3a73b0c9..281c7bc8 100644 --- a/agrirouter-sdk-java-api/pom.xml +++ b/agrirouter-sdk-java-api/pom.xml @@ -44,14 +44,6 @@ org.junit.jupiter junit-jupiter-api - - org.apache.logging.log4j - log4j-api - - - org.apache.logging.log4j - log4j-core - com.google.code.gson gson diff --git a/agrirouter-sdk-java-api/src/main/java/com/dke/data/agrirouter/api/service/LoggingEnabledService.java b/agrirouter-sdk-java-api/src/main/java/com/dke/data/agrirouter/api/service/HasLogger.java similarity index 50% rename from agrirouter-sdk-java-api/src/main/java/com/dke/data/agrirouter/api/service/LoggingEnabledService.java rename to agrirouter-sdk-java-api/src/main/java/com/dke/data/agrirouter/api/service/HasLogger.java index 678e621b..b4b3d782 100644 --- a/agrirouter-sdk-java-api/src/main/java/com/dke/data/agrirouter/api/service/LoggingEnabledService.java +++ b/agrirouter-sdk-java-api/src/main/java/com/dke/data/agrirouter/api/service/HasLogger.java @@ -1,10 +1,9 @@ package com.dke.data.agrirouter.api.service; -import org.apache.logging.log4j.LogManager; -import org.apache.logging.log4j.Logger; -import org.apache.logging.log4j.Marker; -import org.apache.logging.log4j.MarkerManager; -import org.apache.logging.log4j.message.ObjectArrayMessage; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; +import org.slf4j.Marker; +import org.slf4j.MarkerFactory; /** * Interface to encapsulate logging capabilities. Logging will be done using LOG4J2, ruleset should @@ -12,7 +11,6 @@ * *