[test-optimization] [SDTEST-2144] Fix it.failing in combination with EFD (#5857)

Author: Mariovido

integration-tests/ci-visibility/jest/failing-test.js

@@ -0,0 +1,11 @@
+const { expect } = require('chai')
+
+describe('failing', () => {
+  it.failing('can report failed tests', () => {
+    expect(1 + 2).to.equal(4)
+  })
+
+  it.failing('can report failing tests as failures', () => {
+    expect(1 + 2).to.equal(3) // this passes but it should fail! So the test.status should be fail
+  })
+})

integration-tests/jest/jest.spec.js

@@ -2365,6 +2365,68 @@ describe('jest CommonJS', () => {
         }).catch(done)
       })
     })
+
+    it('does not retry when it.failing is used', (done) => {
+      receiver.setInfoResponse({ endpoints: ['/evp_proxy/v4'] })
+      const NUM_RETRIES_EFD = 3
+      receiver.setSettings({
+        early_flake_detection: {
+          enabled: true,
+          slow_test_retries: {
+            '5s': NUM_RETRIES_EFD
+          },
+          faulty_session_threshold: 100
+        },
+        known_tests_enabled: true
+      })
+      const eventsPromise = receiver
+        .gatherPayloadsMaxTimeout(({ url }) => url.endsWith('/api/v2/citestcycle'), (payloads) => {
+          const events = payloads.flatMap(({ payload }) => payload.events)
+
+          const testSession = events.find(event => event.type === 'test_session_end').content
+          assert.propertyVal(testSession.meta, TEST_EARLY_FLAKE_ENABLED, 'true')
+
+          const tests = events.filter(event => event.type === 'test').map(event => event.content)
+
+          const newTests = tests.filter(test =>
+            test.meta[TEST_SUITE] === 'ci-visibility/jest/failing-test.js'
+          )
+          newTests.forEach(test => {
+            assert.notProperty(test.meta, TEST_IS_NEW)
+          })
+          assert.equal(newTests.length, 2)
+
+          const passingTests = tests.filter(test =>
+            test.meta[TEST_NAME] === 'failing can report failed tests'
+          )
+          const failingTests = tests.filter(test =>
+            test.meta[TEST_NAME] === 'failing can report failing tests as failures'
+          )
+          passingTests.forEach(test => {
+            assert.equal(test.meta[TEST_STATUS], 'pass')
+          })
+          failingTests.forEach(test => {
+            assert.equal(test.meta[TEST_STATUS], 'fail')
+          })
+
+          const retriedTests = newTests.filter(test => test.meta[TEST_IS_RETRY] === 'true')
+          assert.equal(retriedTests.length, 0)
+        })
+
+      childProcess = exec(
+        runTestsWithCoverageCommand,
+        {
+          cwd,
+          env: { ...getCiVisEvpProxyConfig(receiver.port), TESTS_TO_RUN: 'jest/failing-test' },
+          stdio: 'inherit'
+        }
+      )
+      childProcess.on('exit', () => {
+        eventsPromise.then(() => {
+          done()
+        }).catch(done)
+      })
+    })
   })
 
   context('flaky test retries', () => {

packages/datadog-instrumentations/src/jest.js

@@ -425,6 +425,10 @@ function getWrappedEnvironment (BaseEnvironment, jestVersion) {
       if (event.name === 'add_test') {
         const originalTestName = this.getTestNameFromAddTestEvent(event, state)
 
+        if (event.failing) {
+          return
+        }
+
         const isSkipped = event.mode === 'todo' || event.mode === 'skip'
         if (this.isTestManagementTestsEnabled) {
           const isAttemptToFix = this.testManagementTestsForThisSuite?.attemptToFix?.includes(originalTestName)