refactor: enable prefer-object-spread rule for all files (#7488)

Move prefer-object-spread ESLint rule from restricted section
to main rules to apply it across all files. Update codebase to
use object spread syntax ({ ...obj }) instead of Object.assign()
calls.

Author: watson

benchmark/sirun/get-results.js

@@ -23,10 +23,11 @@ const artifactsUrl = num =>
 function get (url, headers) {
   return new Promise((resolve, reject) => {
     https.get(url, {
-      headers: Object.assign({
+      headers: {
         'user-agent': 'dd-results-retriever',
         accept: 'application/json',
-      }, headers),
+        ...headers,
+      },
     }, async res => {
       if (res.statusCode >= 300 && res.statusCode < 400) {
         resolve(get(res.headers.location))

benchmark/sirun/run-all-variants.js

@@ -11,13 +11,13 @@ process.env.DD_INSTRUMENTATION_TELEMETRY_ENABLED = 'false'
 require('./squash-affinity')
 
 const metaJson = require(path.join(process.cwd(), 'meta.json'))
-const env = Object.assign({}, process.env, { DD_TRACE_STARTUP_LOGS: 'false' })
+const env = { ...process.env, DD_TRACE_STARTUP_LOGS: 'false' }
 
 ;(async () => {
   if (metaJson.variants) {
     const variants = metaJson.variants
     for (const variant in variants) {
-      const variantEnv = Object.assign({}, env, { SIRUN_VARIANT: variant })
+      const variantEnv = { ...env, SIRUN_VARIANT: variant }
       await exec('sirun', ['meta-temp.json'], { env: variantEnv, stdio })
     }
   } else {

benchmark/sirun/run-one-variant.js

@@ -6,6 +6,6 @@ const { exec, stdio } = require('./run-util')
 
 process.env.DD_INSTRUMENTATION_TELEMETRY_ENABLED = 'false'
 
-const env = Object.assign({}, process.env, { DD_TRACE_STARTUP_LOGS: 'false' })
+const env = { ...process.env, DD_TRACE_STARTUP_LOGS: 'false' }
 
 exec('sirun', ['meta-temp.json'], { env, stdio })

eslint.config.mjs

@@ -394,6 +394,7 @@ export default [
       'no-console': 'error',
       'no-prototype-builtins': 'off', // Override (turned on by @eslint/js/recommended)
       'no-var': 'error',
+      'prefer-object-spread': 'error',
       'require-await': 'error',
       strict: 'error',
     },
@@ -458,7 +459,6 @@ export default [
       'operator-assignment': 'error',
       'prefer-exponentiation-operator': 'error',
       'prefer-object-has-own': 'error',
-      'prefer-object-spread': 'error',
 
       // Too strict for now. Slowly migrate to this rule by using rest parameters.
       // 'prefer-rest-params': 'error',

packages/datadog-plugin-fs/test/index.spec.js

@@ -7,7 +7,7 @@ const util = require('node:util')
 
 const { channel } = require('dc-polyfill')
 const { after, afterEach, before, beforeEach, describe, it } = require('mocha')
-const realFS = Object.assign({}, require('node:fs'))
+const realFS = { ...require('node:fs') }
 
 const agent = require('../../dd-trace/test/plugins/agent')
 const { expectSomeSpan } = require('../../dd-trace/test/plugins/helpers')
@@ -1937,12 +1937,13 @@ describe('Plugin', () => {
 })
 
 function mkExpected (props) {
-  const meta = Object.assign({ component: 'fs', 'span.kind': 'internal' }, props.meta)
-  const expected = Object.assign({
+  const meta = { component: 'fs', 'span.kind': 'internal', ...props.meta }
+  const expected = {
     name: 'fs.operation',
     error: 0,
     service: 'test',
-  }, props)
+    ...props,
+  }
   expected.meta = meta
   return expected
 }

packages/datadog-plugin-graphql/test/index.spec.js

@@ -1352,7 +1352,7 @@ describe('Plugin', () => {
 
           return agent.load('graphql', {
             service: 'custom',
-            variables: variables => Object.assign({}, variables, { who: 'REDACTED' }),
+            variables: variables => ({ ...variables, who: 'REDACTED' }),
             source: true,
           })
         })

packages/datadog-plugin-grpc/test/client.spec.js

@@ -31,12 +31,13 @@ describe('Plugin', () => {
       }
 
       function buildGenericService (grpc, service, TestService, ClientService, currentVersion) {
-        service = Object.assign({
+        service = {
           getBidi: () => {},
           getServerStream: () => {},
           getClientStream: () => {},
           getUnary: () => {},
-        }, service)
+          ...service,
+        }
 
         server = new grpc.Server()
 

packages/datadog-plugin-grpc/test/integration-test/server.mjs

@@ -9,15 +9,13 @@ let server
 let port = 0
 
 function buildClient (service, callback) {
-  service = Object.assign(
-    {
-      getBidi: () => {},
-      getServerStream: () => {},
-      getClientStream: () => {},
-      getUnary: () => {},
-    },
-    service
-  )
+  service = {
+    getBidi: () => {},
+    getServerStream: () => {},
+    getClientStream: () => {},
+    getUnary: () => {},
+    ...service,
+  }
 
   const definition = protoLoader.loadSync(`${currentDirectoryPath}/test.proto`)
   const TestService = grpc.loadPackageDefinition(definition).test.TestService

packages/datadog-plugin-grpc/test/server.spec.js

@@ -25,12 +25,13 @@ describe('Plugin', () => {
       let call
 
       function buildClient (service) {
-        service = Object.assign({
+        service = {
           getBidi: () => {},
           getServerStream: () => {},
           getClientStream: () => {},
           getUnary: () => {},
-        }, service)
+          ...service,
+        }
 
         const loader = require('../../../versions/@grpc/proto-loader').get()
         const definition = loader.loadSync(path.join(__dirname, 'test.proto'))

packages/datadog-plugin-rhea/test/index.spec.js

@@ -641,7 +641,7 @@ describe('Plugin', () => {
             })
             const listener = server.listen({ port: 0 })
             listener.on('listening', () => {
-              connection = client.connect(Object.assign({ reconnect: false }, listener.address()))
+              connection = client.connect({ reconnect: false, ...listener.address() })
               connection.open_receiver({ autoaccept: false })
               connection.open_sender()
               expectedServerPort = listener.address().port