chore: use generated config types as much as possible (#7955)

This adds the now auto generated config types to as many consumers as
possible. Types should now always be correct. There could be additional
consumers that would also profit, this is just a best effort approach
for adding them to the consumers.

The plugin_manager tests were rewritten to reflect the actual config
changes properly.

Author: BridgeAR

packages/dd-trace/src/aiguard/sdk.js

@@ -57,6 +57,10 @@ class AIGuard extends NoopAIGuard {
   #maxContentSize
   #meta
 
+  /**
+   * @param {import('../tracer')} tracer - Tracer instance
+   * @param {import('../config/config-base')} config - Tracer configuration
+   */
   constructor (tracer, config) {
     super()
 

packages/dd-trace/src/appsec/blocking.js

@@ -164,6 +164,9 @@ function getBlockingAction (actions) {
   return actions?.redirect_request || actions?.block_request
 }
 
+/**
+ * @param {import('../config/config-base')} config - Tracer configuration
+ */
 function setTemplates (config) {
   templateHtml = config.appsec.blockedTemplateHtml || blockedTemplates.html
 

packages/dd-trace/src/appsec/sdk/index.js

@@ -26,6 +26,10 @@ class EventTrackingV2 {
 }
 
 class AppsecSdk {
+  /**
+   * @param {import('../../tracer')} tracer - Tracer instance
+   * @param {import('../../config/config-base')} config - Tracer configuration
+   */
   constructor (tracer, config) {
     this._tracer = tracer
     if (config) {

packages/dd-trace/src/ci-visibility/test-api-manual/test-api-manual-plugin.js

@@ -54,6 +54,10 @@ class TestApiManualPlugin extends CiPlugin {
     })
   }
 
+  /**
+   * @param {import('../../config/config-base')} config - Tracer configuration
+   * @param {boolean} shouldGetEnvironmentData - Whether to get environment data
+   */
   configure (config, shouldGetEnvironmentData) {
     this._config = config
     super.configure(config, shouldGetEnvironmentData)

packages/dd-trace/src/crashtracking/crashtracker.js

@@ -23,6 +23,9 @@ class Crashtracker {
     }
   }
 
+  /**
+   * @param {import('../config/config-base')} config - Tracer configuration
+   */
   start (config) {
     if (this.#started) return this.configure(config)
 
@@ -35,7 +38,7 @@ class Crashtracker {
         this.#getMetadata(config)
       )
     } catch (e) {
-      log.error('Error initialising crashtracker', e)
+      log.error('Error initializing crashtracker', e)
     }
   }
 
@@ -49,6 +52,9 @@ class Crashtracker {
   }
 
   // TODO: Send only configured values when defaults are fixed.
+  /**
+   * @param {import('../config/config-base')} config - Tracer configuration
+   */
   #getConfig (config) {
     const url = getAgentUrl(config)
 

packages/dd-trace/src/debugger/index.js

@@ -147,7 +147,7 @@ function start (config, rcInstance) {
  * Sends the new configuration to the worker thread via the config channel.
  * Does nothing if the worker is not started.
  *
- * @param {Config} config - The updated tracer configuration object
+ * @param {import('../config/config-base')} config - The updated tracer configuration object
  */
 function configure (config) {
   if (configChannel === null) return

packages/dd-trace/src/heap_snapshots.js

@@ -45,6 +45,9 @@ function getName (destination) {
 }
 
 module.exports = {
+  /**
+   * @param {import('./config/config-base')} config - Tracer configuration
+   */
   async start (config) {
     const destination = config.heapSnapshot.destination
 

packages/dd-trace/src/opentelemetry/logs/index.js

@@ -33,7 +33,7 @@ const OtlpHttpLogExporter = require('./otlp_http_log_exporter')
 
 /**
  * Initializes OpenTelemetry Logs support
- * @param {Config} config - Tracer configuration instance
+ * @param {import('../../config/config-base')} config - Tracer configuration instance
  */
 function initializeOpenTelemetryLogs (config) {
   // Build resource attributes

packages/dd-trace/src/opentelemetry/metrics/index.js

@@ -35,7 +35,7 @@ const OtlpHttpMetricExporter = require('./otlp_http_metric_exporter')
 
 /**
  * Initializes OpenTelemetry Metrics support
- * @param {Config} config - Tracer configuration instance
+ * @param {import('../../config/config-base')} config - Tracer configuration instance
  */
 function initializeOpenTelemetryMetrics (config) {
   const resourceAttributes = {

packages/dd-trace/src/payload-tagging/config/index.js

@@ -3,16 +3,17 @@
 const aws = require('./aws.json')
 const sdks = { aws }
 
+/** @typedef {Record<string, { request: string[], response: string[], expand: string[] }>} SDKRules */
 /**
  * Builds rules per service for a given SDK, appending user-provided rules.
  *
- * @param {Record<string, { request: string[], response: string[], expand: string[] }>} sdk
+ * @param {SDKRules} sdk
  * @param {string[]} requestInput
  * @param {string[]} responseInput
- * @returns {Record<string, { request: string[], response: string[], expand: string[] }>}
+ * @returns {SDKRules}
  */
 function getSDKRules (sdk, requestInput, responseInput) {
-  const sdkServiceRules = {}
+  const sdkServiceRules = /** @type {SDKRules} */ ({})
   for (const [service, serviceRules] of Object.entries(sdk)) {
     sdkServiceRules[service] = {
       // Make a copy. Otherwise calling the function multiple times would append
@@ -31,10 +32,10 @@ function getSDKRules (sdk, requestInput, responseInput) {
  *
  * @param {string[]} [requestInput=[]]
  * @param {string[]} [responseInput=[]]
- * @returns {Record<string, Record<string, { request: string[], response: string[], expand: string[] }>>}
+ * @returns {Record<string, SDKRules>}
  */
 function appendRules (requestInput = [], responseInput = []) {
-  const sdkRules = {}
+  const sdkRules = /** @type {Record<string, SDKRules>} */ ({})
   for (const [name, sdk] of Object.entries(sdks)) {
     sdkRules[name] = getSDKRules(sdk, requestInput, responseInput)
   }