chore(tests): Made tests use real spans instead of plain objects (#7887)

* made test use real spans instead of plain objects and change inernal context to use context()

* fix fs tests

Author: pabloerhard

packages/datadog-plugin-aerospike/test/index.spec.js

@@ -243,11 +243,11 @@ describe('Plugin', () => {
           })
 
           it('should run the callback in the parent context', done => {
-            const obj = {}
+            const span = tracer.startSpan('test')
             aerospike.connect(config).then(client => {
-              tracer.scope().activate(obj, () => {
+              tracer.scope().activate(span, () => {
                 client.put(key, { i: 123 }, () => {
-                  assert.strictEqual(tracer.scope().active(), obj)
+                  assert.strictEqual(tracer.scope().active(), span)
                   client.close(false)
                   done()
                 })

packages/datadog-plugin-avsc/test/index.spec.js

@@ -81,7 +81,7 @@ describe('Plugin', () => {
             const buf = type.toBuffer({ name: 'Alyssa', favorite_number: 256, favorite_color: null })
             fs.writeFileSync(filePath, buf)
 
-            assert.strictEqual(span._name, 'user.serialize')
+            assert.strictEqual(span.context()._name, 'user.serialize')
 
             assert.strictEqual(compareJson(BASIC_USER_SCHEMA_DEF, span), true)
             assert.strictEqual(span.context()._tags[SCHEMA_TYPE], 'avro')
@@ -112,7 +112,7 @@ describe('Plugin', () => {
             })
             fs.writeFileSync(filePath, buf)
 
-            assert.strictEqual(span._name, 'advanced_user.serialize')
+            assert.strictEqual(span.context()._name, 'advanced_user.serialize')
 
             assert.strictEqual(compareJson(ADVANCED_USER_SCHEMA_DEF, span), true)
             assert.strictEqual(span.context()._tags[SCHEMA_TYPE], 'avro')
@@ -133,7 +133,7 @@ describe('Plugin', () => {
           tracer.trace('user.deserialize', span => {
             type.fromBuffer(buf)
 
-            assert.strictEqual(span._name, 'user.deserialize')
+            assert.strictEqual(span.context()._name, 'user.deserialize')
 
             assert.strictEqual(compareJson(BASIC_USER_SCHEMA_DEF, span), true)
             assert.strictEqual(span.context()._tags[SCHEMA_TYPE], 'avro')
@@ -165,7 +165,7 @@ describe('Plugin', () => {
           tracer.trace('advanced_user.deserialize', span => {
             type.fromBuffer(buf)
 
-            assert.strictEqual(span._name, 'advanced_user.deserialize')
+            assert.strictEqual(span.context()._name, 'advanced_user.deserialize')
 
             assert.strictEqual(compareJson(ADVANCED_USER_SCHEMA_DEF, span), true)
             assert.strictEqual(span.context()._tags[SCHEMA_TYPE], 'avro')

packages/datadog-plugin-aws-sdk/test/aws-sdk.spec.js

@@ -201,7 +201,7 @@ describe('Plugin', () => {
         }
 
         it('should bind callbacks to the correct active span', (done) => {
-          const span = {}
+          const span = tracer.startSpan('test')
 
           tracer.scope().activate(span, () => {
             s3.listBuckets({}, () => {

packages/datadog-plugin-express/test/index.spec.js

@@ -1047,7 +1047,7 @@ describe('Plugin', () => {
         it('should activate a span for every middleware on a route', done => {
           const app = express()
 
-          const span = {}
+          const span = tracer.startSpan('test')
 
           app.get(
             '/user',

packages/datadog-plugin-fs/test/index.spec.js

@@ -1883,7 +1883,8 @@ describe('Plugin', () => {
         if (name.split('.').reduce(reducer, realFS)) {
           describe(name, () => {
             fn(name, (fs, args, done, withError) => {
-              const span = {}
+              const span = tracer.startSpan('test')
+              span.finish()
               return tracer.scope().activate(span, () => {
                 args.push((err) => {
                   assert.strictEqual(tracer.scope().active(), span)
@@ -1902,7 +1903,8 @@ describe('Plugin', () => {
         if (realFS.promises && name in realFS.promises) {
           describe('promises.' + name, () => {
             fn('promises.' + name, (fs, args, done, withError) => {
-              const span = {}
+              const span = tracer.startSpan('test')
+              span.finish()
               return tracer.scope().activate(span, () => {
                 return fs.promises[name].apply(fs.promises, args)
                   .then(() => {

packages/datadog-plugin-google-cloud-pubsub/test/index.spec.js

@@ -228,7 +228,7 @@ describe('Plugin', () => {
             sub.on('message', msg => {
               const activeSpan = tracer.scope().active()
               if (activeSpan) {
-                const receiverSpanContext = activeSpan._spanContext
+                const receiverSpanContext = activeSpan.context()
                 assert.ok(typeof receiverSpanContext._parentId === 'object' && receiverSpanContext._parentId !== null)
               }
               msg.ack()

packages/datadog-plugin-grpc/test/client.spec.js

@@ -512,7 +512,7 @@ describe('Plugin', () => {
             })
 
             it('should propagate the parent scope to the callback', done => {
-              const span = {}
+              const span = tracer.startSpan('test')
 
               buildClient({
                 getUnary: (call, callback) => callback(),
@@ -527,7 +527,7 @@ describe('Plugin', () => {
             })
 
             it('should propagate the parent scope to event listeners', done => {
-              const span = {}
+              const span = tracer.startSpan('test')
 
               buildClient({
                 getServerStream: stream => {

packages/datadog-plugin-http2/test/client.spec.js

@@ -511,7 +511,7 @@ describe('Plugin', () => {
               .connect(`${protocol}://localhost:${port}`)
               .on('error', done)
 
-            const span = {}
+            const span = tracer.startSpan('test')
 
             tracer.scope().activate(span, () => {
               const req = client.request({ ':path': '/user' })

packages/datadog-plugin-ioredis/test/index.spec.js

@@ -56,7 +56,7 @@ describe('Plugin', () => {
         })
 
         it('should run the callback in the parent context', () => {
-          const span = {}
+          const span = tracer.startSpan('test')
 
           return tracer.scope().activate(span, async () => {
             await redis.get('foo')

packages/datadog-plugin-iovalkey/test/index.spec.js

@@ -57,7 +57,7 @@ describe('Plugin', () => {
         })
 
         it('should run the callback in the parent context', () => {
-          const span = {}
+          const span = tracer.startSpan('test')
 
           return tracer.scope().activate(span, async () => {
             await valkey.get('foo')