Skip to content

Commit a182723

Browse files
BridgeARuurienwatson
authored
Pin express version to make sure integration tests pass (#5510)
* Pin express version to make sure integration tests pass The issue itself has to be addressed and this should be reworked after this landing. * Fix appsec ci * Apply suggestions from code review --------- Co-authored-by: Ugaitz Urien <ugaitz.urien@datadoghq.com> Co-authored-by: Thomas Watson <w@tson.dk>
1 parent 1bd4073 commit a182723

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

integration-tests/appsec/iast.esm-security-controls.spec.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ describe('ESM Security controls', () => {
1111

1212
before(async function () {
1313
this.timeout(process.platform === 'win32' ? 90000 : 30000)
14-
sandbox = await createSandbox(['express'])
14+
sandbox = await createSandbox(['express@4']) // TODO: Remove pinning once our tests support Express v5
1515
appPort = await getPort()
1616
cwd = sandbox.folder
1717
appFile = path.join(cwd, 'appsec', 'esm-security-controls', 'index.mjs')

integration-tests/opentelemetry.spec.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ describe('opentelemetry', () => {
6161
'@opentelemetry/instrumentation',
6262
'@opentelemetry/instrumentation-http',
6363
'@opentelemetry/instrumentation-express@0.47.1',
64-
'express'
64+
'express@4' // TODO: Remove pinning once our tests support Express v5
6565
]
6666
if (satisfies(process.version.slice(1), '>=14')) {
6767
dependencies.push('@opentelemetry/sdk-node')

0 commit comments

Comments
 (0)