test: completely remove chai and fix type errors (#7144)

* test: fix env type errors

Environment variables may only be of type string or undefined.

* test: remove all chai related code

Instead, the code is now using Node.js assert or a native testing
library available by a test runner.

* test: fix opentracing tests

This uses a hack to keep them supported, since they use chai. To do so,
a fake chai is introduced when loading that test file.

* test: remove unused deepInclude test helper

It was not used for a while and could be replaced with the more
generic partial deep strict equal helper.

Author: BridgeAR

benchmark/sirun/startup/startup-test.js

@@ -27,7 +27,6 @@ if (Number(process.env.EVERYTHING)) {
     'axios',
     'benchmark',
     'body-parser',
-    'chai',
     'crypto-randomuuid',
     'dc-polyfill',
     'eslint-plugin-cypress',
@@ -67,7 +66,6 @@ if (Number(process.env.EVERYTHING)) {
     'semifies',
     'semver',
     'shell-quote',
-    'sinon-chai',
     'sinon',
     'source-map',
     'tap',

eslint.config.mjs

@@ -595,7 +595,6 @@ export default [
         allowModules: [
           ...Object.keys(dependencies),
           'mocha',
-          'chai'
         ]
       }],
       'n/no-missing-require': 'off',

integration-tests/appsec/data-collection.spec.js

@@ -27,7 +27,7 @@ describe('ASM Data collection', () => {
 
       const env = {
         DD_TRACE_AGENT_PORT: agent.port,
-        DD_APPSEC_ENABLED: true,
+        DD_APPSEC_ENABLED: 'true',
         DD_APPSEC_RULES: path.join(cwd, 'appsec', 'data-collection', 'data-collection-rules.json')
       }
 

integration-tests/appsec/response-headers.spec.js

@@ -26,7 +26,7 @@ describe('Headers collection - Fastify', () => {
 
     const env = {
       DD_TRACE_AGENT_PORT: agent.port,
-      DD_APPSEC_ENABLED: true,
+      DD_APPSEC_ENABLED: 'true',
       DD_APPSEC_RULES: path.join(cwd, 'appsec/data-collection/data-collection-rules.json')
     }
     proc = await spawnProc(appFile, { cwd, env, execArgv: [] })

integration-tests/appsec/trace-tagging.spec.js

@@ -20,7 +20,7 @@ describe('ASM Trace Tagging rules', () => {
 
       const env = {
         DD_TRACE_AGENT_PORT: agent.port,
-        DD_APPSEC_ENABLED: true,
+        DD_APPSEC_ENABLED: 'true',
         DD_APPSEC_RULES: path.join(cwd, 'appsec', 'data-collection', 'data-collection-rules.json')
       }
 

integration-tests/ci-visibility/automatic-log-submission.spec.js

@@ -24,7 +24,6 @@ describe('test optimization automatic log submission', () => {
     '@cucumber/cucumber',
     'jest',
     'winston',
-    'chai@4',
     '@playwright/test'
   ], true)
 
@@ -73,7 +72,7 @@ describe('test optimization automatic log submission', () => {
       getExtraEnvVars: () => ({
         PW_BASE_URL: `http://localhost:${webAppPort}`,
         TEST_DIR: 'ci-visibility/automatic-log-submission-playwright',
-        DD_TRACE_DEBUG: 1
+        DD_TRACE_DEBUG: '1'
       })
     }
   ]

integration-tests/cucumber/cucumber.spec.js

@@ -1838,7 +1838,7 @@ describe(`cucumber@${version} commonJS`, () => {
               cwd,
               env: {
                 ...envVars,
-                DD_CIVISIBILITY_FLAKY_RETRY_COUNT: 1
+                DD_CIVISIBILITY_FLAKY_RETRY_COUNT: '1'
               },
               stdio: 'pipe'
             }

integration-tests/cypress/cypress.spec.js

@@ -2012,7 +2012,7 @@ moduleTypes.forEach(({
             env: {
               ...restEnvVars,
               CYPRESS_BASE_URL: `http://localhost:${webAppPort}`,
-              DD_CIVISIBILITY_FLAKY_RETRY_COUNT: 1,
+              DD_CIVISIBILITY_FLAKY_RETRY_COUNT: '1',
               SPEC_PATTERN: specToRun
             },
             stdio: 'pipe'
@@ -2302,7 +2302,7 @@ moduleTypes.forEach(({
               CYPRESS_BASE_URL: `http://localhost:${webAppPort}`,
               CYPRESS_BASE_URL_SECOND: `http://localhost:${secondWebAppPort}`,
               SPEC_PATTERN: specToRun,
-              DD_TRACE_DEBUG: true
+              DD_TRACE_DEBUG: 'true'
             },
             stdio: 'pipe'
           }

integration-tests/debugger/basic.spec.js

@@ -767,7 +767,7 @@ describe('Dynamic Instrumentation', function () {
 
   describe('DD_TRACING_ENABLED=true, DD_TRACE_128_BIT_TRACEID_GENERATION_ENABLED=true', function () {
     const t = setup({
-      env: { DD_TRACING_ENABLED: true, DD_TRACE_128_BIT_TRACEID_GENERATION_ENABLED: true },
+      env: { DD_TRACING_ENABLED: 'true', DD_TRACE_128_BIT_TRACEID_GENERATION_ENABLED: true },
       dependencies: ['fastify']
     })
 
@@ -778,7 +778,7 @@ describe('Dynamic Instrumentation', function () {
 
   describe('DD_TRACING_ENABLED=true, DD_TRACE_128_BIT_TRACEID_GENERATION_ENABLED=false', function () {
     const t = setup({
-      env: { DD_TRACING_ENABLED: true, DD_TRACE_128_BIT_TRACEID_GENERATION_ENABLED: false },
+      env: { DD_TRACING_ENABLED: 'true', DD_TRACE_128_BIT_TRACEID_GENERATION_ENABLED: false },
       dependencies: ['fastify']
     })
 
@@ -789,7 +789,7 @@ describe('Dynamic Instrumentation', function () {
 
   describe('DD_TRACING_ENABLED=false', function () {
     const t = setup({
-      env: { DD_TRACING_ENABLED: false },
+      env: { DD_TRACING_ENABLED: 'false' },
       dependencies: ['fastify']
     })
 

integration-tests/jest/jest.spec.js

@@ -101,7 +101,6 @@ describe(`jest@${JEST_VERSION} commonJS`, () => {
 
   useSandbox([
     `jest@${JEST_VERSION}`,
-    'chai@v4',
     `jest-jasmine2@${JEST_VERSION}`,
     // jest-environment-jsdom is included in older versions of jest
     JEST_VERSION === 'latest' && `jest-environment-jsdom@${JEST_VERSION}`,
@@ -2792,7 +2791,7 @@ describe(`jest@${JEST_VERSION} commonJS`, () => {
             ...getCiVisAgentlessConfig(receiver.port), // use agentless for this test, just for variety
             TESTS_TO_RUN: 'test/ci-visibility-test',
             ENABLE_JSDOM: true,
-            DD_TRACE_DEBUG: 1,
+            DD_TRACE_DEBUG: '1',
             DD_TRACE_LOG_LEVEL: 'warn'
           },
           stdio: 'inherit'
@@ -3386,7 +3385,7 @@ describe(`jest@${JEST_VERSION} commonJS`, () => {
           env: {
             ...getCiVisEvpProxyConfig(receiver.port),
             TESTS_TO_RUN: 'jest-flaky/flaky-',
-            DD_CIVISIBILITY_FLAKY_RETRY_COUNT: 1
+            DD_CIVISIBILITY_FLAKY_RETRY_COUNT: '1'
           },
           stdio: 'inherit'
         }
@@ -4801,7 +4800,7 @@ describe(`jest@${JEST_VERSION} commonJS`, () => {
 
       fs.writeFileSync(
         path.join(cwd, 'ci-visibility/test-impacted-test/test-impacted-1.js'),
-        `const { expect } = require('chai')
+        `const assert = require('assert')
 
          describe('impacted tests', () => {
           it('can pass normally', () => {