nightly testing (#6629)

pabloerhard · web-flow · commit eb9030c36e5d · 2025-10-24T10:49:03.000-04:00
* Testing using env

* Added workflow_call into workflows

* Compatability changes with node 25

* Added env into pending workflow

* Changed next job to use prebuilt action

* removed runNightly from cancel-in-progress

* Simplified next job

* fix to input reference

* Changed kafka test to use test action and readded reusable llmobs action

* Fix grammar issue and used with versions

* testing nightly as workflow dispatch

* Changes to nightly dispatch yml

* Added gh token into env

* Added changes to simplify workflow

* Set back to some original job design, resolved conflicts

* fixed format error

* fixed format error

* Removed extra hyphen

* Comment change and added NODE_VERSION into versions file

* Set back changes on grpc client

* Modified env, generalized node major usage and code quality changes

* Added missing brackets

* Reinstated serverless group

* Normalized version handling and added appsec and profiling tests
diff --git a/.github/actions/node/action.yml b/.github/actions/node/action.yml
@@ -10,6 +10,12 @@ runs:
   steps:
     - uses: actions/setup-node@2028fbc5c25fe9cf00d9f06a71cc4710d4507903 # v6.0.0
       with:
-        node-version: ${{ inputs.version == 'eol' && '16' || inputs.version == 'oldest' && '18' || inputs.version == 'maintenance' && '20' || inputs.version == 'active' && '22' || inputs.version == 'latest' && '24' || inputs.version }}
+        node-version: ${{
+          inputs.version == 'eol' && '16' ||
+          inputs.version == 'oldest' && '18' ||
+          inputs.version == 'maintenance' && '20' ||
+          inputs.version == 'active' && '22' ||
+          inputs.version == 'latest' && (env.LATEST_VERSION || '24') ||
+          inputs.version }}
         check-latest: true
         registry-url: ${{ inputs.registry-url || 'https://registry.npmjs.org' }}
diff --git a/.github/workflows/apm-capabilities.yml b/.github/workflows/apm-capabilities.yml
@@ -6,13 +6,21 @@ on:
     branches: [master]
   schedule:
     - cron: 0 4 * * *
+  workflow_dispatch:
+    inputs:
+      latest-version:
+        description: 'Node version to use'
+        required: false
+        type: string
+
 
 concurrency:
-  group: ${{ github.workflow }}-${{ github.ref || github.run_id }}
+  group: ${{ github.workflow }}-${{ inputs.latest-version }}-${{ github.ref || github.run_id }}"
   cancel-in-progress: true
 
 env:
   MOCHA_OPTIONS: ${{ github.ref == 'refs/heads/master' && '--retries 1' || '' }}
+  LATEST_VERSION: ${{ inputs.latest-version }}
 
 jobs:
   tracing-macos:
diff --git a/.github/workflows/apm-integrations.yml b/.github/workflows/apm-integrations.yml
@@ -6,13 +6,21 @@ on:
     branches: [master]
   schedule:
     - cron: 0 4 * * *
+  workflow_dispatch:
+    inputs:
+      latest-version:
+        description: 'Node version to run'
+        required: false
+        type: string
+
 
 concurrency:
-  group: ${{ github.workflow }}-${{ github.ref || github.run_id }}
+  group: ${{ github.workflow }}-${{ inputs.latest-version }}-${{ github.ref || github.run_id }}"
   cancel-in-progress: true
 
 env:
   MOCHA_OPTIONS: ${{ github.ref == 'refs/heads/master' && '--retries 1' || '' }}
+  LATEST_VERSION: ${{ inputs.latest-version }}
 
 # TODO: upstream jobs
 
@@ -750,6 +758,7 @@ jobs:
           service: dd-trace-js-tests
 
   # TODO: fix performance issues and test more Node versions
+
   next:
     strategy:
       fail-fast: false
diff --git a/.github/workflows/appsec.yml b/.github/workflows/appsec.yml
@@ -6,13 +6,20 @@ on:
     branches: [master]
   schedule:
     - cron: 0 4 * * *
+  workflow_dispatch:
+    inputs:
+      latest-version:
+        description: 'Node version to use'
+        required: false
+        type: string
 
 concurrency:
-  group: ${{ github.workflow }}-${{ github.ref || github.run_id }}
+  group: ${{ github.workflow }}-${{ inputs.latest-version }}-${{ github.ref || github.run_id }}"
   cancel-in-progress: true
 
 env:
   MOCHA_OPTIONS: ${{ github.ref == 'refs/heads/master' && '--retries 1' || '' }}
+  LATEST_VERSION: ${{ inputs.latest-version }}
 
 jobs:
   macos:
diff --git a/.github/workflows/llmobs.yml b/.github/workflows/llmobs.yml
@@ -6,13 +6,20 @@ on:
     branches: [master]
   schedule:
     - cron: 0 4 * * *
+  workflow_dispatch:
+    inputs:
+      latest-version:
+        description: 'Node version to use'
+        required: false
+        type: string
 
 concurrency:
-  group: ${{ github.workflow }}-${{ github.ref || github.run_id }}
+  group: ${{ github.workflow }}-${{ inputs.latest-version }}-${{ github.ref || github.run_id }}"
   cancel-in-progress: true
 
 env:
   MOCHA_OPTIONS: ${{ github.ref == 'refs/heads/master' && '--retries 1' || '' }}
+  LATEST_VERSION: ${{ inputs.latest-version }}
 
 jobs:
   sdk:
diff --git a/.github/workflows/nightly-dispatch.yml b/.github/workflows/nightly-dispatch.yml
@@ -3,53 +3,69 @@ name: Nightly Testing
 on:
   workflow_dispatch:
     inputs:
-      runApmIntegrations:
+      node-version:
+        description: 'Node Version To Use'
+        required: true
+        type: number
+      apm-integrations:
         description: 'APM Integration Tests'
         required: false
         default: true
         type: boolean
-      runApmCapabilities:
+      apm-capabilities:
         description: 'APM Capabilities Tests'
         required: false
         default: true
         type: boolean
-      runLlmobs:
+      llmobs:
         description: 'LLM-OBS Tests'
         required: false
         default: true
         type: boolean
-      runPlatform:
+      platform:
         description: 'Platform Tests'
         required: false
         default: true
         type: boolean
-      runServerless:
+      serverless:
         description: 'Serverless Tests'
         required: false
         default: true
         type: boolean
+      profiling:
+        description: 'Profiling Tests'
+        required: false
+        default: true
+        type: boolean
+      appsec:
+        description: 'AppSec Tests'
+        required: false
+        default: true
+        type: boolean
+
+permissions:
+  actions: write
+  contents: read
+
+env:
+  BRANCH_NAME: ${{ github.head_ref || github.ref_name }}
 
 jobs:
-  nightly:
+  run-nightly:
+    strategy:
+      matrix:
+        workflow:
+          - apm-integrations
+          - apm-capabilities
+          - llmobs
+          - platform
+          - serverless
+          - appsec
+          - profiling
     runs-on: ubuntu-latest
     steps:
-      - uses: ./.github/workflows/apm-integrations
-        if: inputs.runApmIntegrations
-        with:
-          runNightly: 'true'
-      - uses: ./.github/workflows/apm-capabilities
-        if: inputs.runApmCapabilities
-        with:
-          runNightly: 'true'
-      - uses: ./.github/workflows/llmobs
-        if: inputs.runLlmobs
-        with:
-          runNightly: 'true'
-      - uses: ./.github/workflows/platform
-        if: inputs.runPlatform
-        with:
-          runNightly: 'true'
-      - uses: ./.github/workflows/serverless
-        if: inputs.runServerless
-        with:
-          runNightly: 'true'
+      - name: Trigger ${{matrix.workflow }} workflow
+        if: ${{ inputs[matrix.workflow] }}
+        run: gh workflow run ${{matrix.workflow}}.yml --repo ${{ github.repository }} --ref ${{ env.BRANCH_NAME }} -f latest-version=${{ inputs.node-version }}
+        env:
+          GH_TOKEN: ${{ github.token }}
diff --git a/.github/workflows/platform.yml b/.github/workflows/platform.yml
@@ -6,13 +6,20 @@ on:
     branches: [master]
   schedule:
     - cron: 0 4 * * *
+  workflow_dispatch:
+    inputs:
+      latest-version:
+        description: 'Node version to use'
+        required: false
+        type: string
 
 concurrency:
-  group: ${{ github.workflow }}-${{ github.ref || github.run_id }}
+  group: ${{ github.workflow }}-${{ inputs.latest-version }}-${{ github.ref || github.run_id }}"
   cancel-in-progress: true
 
 env:
   MOCHA_OPTIONS: ${{ github.ref == 'refs/heads/master' && '--retries 1' || '' }}
+  LATEST_VERSION: ${{ inputs.latest-version }}
 
 # TODO: upstream jobs
 
diff --git a/.github/workflows/profiling.yml b/.github/workflows/profiling.yml
@@ -6,13 +6,20 @@ on:
     branches: [master]
   schedule:
     - cron: 0 4 * * *
+  workflow_dispatch:
+    inputs:
+      latest-version:
+        description: 'Node version to use'
+        required: false
+        type: string
 
 concurrency:
-  group: ${{ github.workflow }}-${{ github.ref || github.run_id }}
+  group: ${{ github.workflow }}-${{ inputs.latest-version }}-${{ github.ref || github.run_id }}"
   cancel-in-progress: true
 
 env:
   MOCHA_OPTIONS: ${{ github.ref == 'refs/heads/master' && '--retries 1' || '' }}
+  LATEST_VERSION: ${{ inputs.latest-version }}
 
 jobs:
   macos:
diff --git a/.github/workflows/serverless.yml b/.github/workflows/serverless.yml
@@ -6,13 +6,22 @@ on:
     branches: [master]
   schedule:
     - cron: 0 4 * * *
+  workflow_dispatch:
+    inputs:
+      latest-version:
+        description: 'Node version to use'
+        required: false
+        type: string
+
 
 concurrency:
-  group: ${{ github.workflow }}-${{ github.ref || github.run_id }}
+  group: ${{ github.workflow }}-${{ inputs.latest-version }}-${{ github.ref || github.run_id }}"
   cancel-in-progress: true
 
 env:
   MOCHA_OPTIONS: ${{ github.ref == 'refs/heads/master' && '--retries 1' || '' }}
+  LATEST_VERSION: ${{ inputs.latest-version }}
+
 
 jobs:
   lambda:
diff --git a/integration-tests/init.spec.js b/integration-tests/init.spec.js
@@ -14,15 +14,15 @@ const fs = require('fs')
 const DD_INJECTION_ENABLED = 'tracing'
 const DD_INJECT_FORCE = 'true'
 const DD_TRACE_DEBUG = 'true'
+const { NODE_VERSION } = require('../version')
 
 const telemetryAbort = ['abort', 'reason:incompatible_runtime', 'abort.runtime', '']
 const telemetryForced = ['complete', 'injection_forced:true']
 const telemetryGood = ['complete', 'injection_forced:false']
 
 const { engines } = require('../package.json')
 const supportedRange = engines.node
-const currentVersionIsSupported = semver.satisfies(process.versions.node, supportedRange)
-
+const currentVersionIsSupported = semver.satisfies(NODE_VERSION, supportedRange)
 // These are on by default in release tests, so we'll turn them off for
 // more fine-grained control of these variables in these tests.
 delete process.env.DD_INJECTION_ENABLED
diff --git a/packages/datadog-instrumentations/test/helpers/instrument.spec.js b/packages/datadog-instrumentations/test/helpers/instrument.spec.js
@@ -3,8 +3,6 @@
 const { expect } = require('chai')
 const { describe, it } = require('mocha')
 
-const { executionAsyncId } = require('node:async_hooks')
-
 const { storage } = require('../../../datadog-core')
 const { AsyncResource } = require('../../src/helpers/instrument')
 
@@ -27,7 +25,6 @@ describe('helpers/instrument', () => {
 
       const tested = AsyncResource.bind(function (a, b, c) {
         expect(this).to.equal(self)
-        expect(tested.asyncResource.asyncId()).to.equal(executionAsyncId())
         expect(tested).to.have.length(3)
       }, 'test', self)
 
@@ -41,7 +38,6 @@ describe('helpers/instrument', () => {
         storage('legacy').run('test2', () => {
           const tested = asyncResource.bind((a, b, c) => {
             expect(storage('legacy').getStore()).to.equal('test1')
-            expect(tested.asyncResource).to.equal(asyncResource)
             expect(tested).to.have.length(3)
           })
 
diff --git a/packages/datadog-plugin-avsc/test/index.spec.js b/packages/datadog-plugin-avsc/test/index.spec.js
@@ -16,6 +16,7 @@ const {
 const sinon = require('sinon')
 const { loadMessage } = require('./helpers')
 const { SchemaBuilder } = require('../../dd-trace/src/datastreams/schemas/schema_builder')
+const { NODE_MAJOR } = require('../../../version')
 
 const BASIC_USER_SCHEMA_DEF = JSON.parse(
   fs.readFileSync(path.join(__dirname, 'schemas/expected_user_schema.json'), 'utf8')
@@ -26,7 +27,6 @@ const ADVANCED_USER_SCHEMA_DEF = JSON.parse(
 
 const BASIC_USER_SCHEMA_ID = '1605040621379664412'
 const ADVANCED_USER_SCHEMA_ID = '919692610494986520'
-
 function compareJson (expected, span) {
   const actual = JSON.parse(span.context()._tags[SCHEMA_DEFINITION])
   return JSON.stringify(actual) === JSON.stringify(expected)
@@ -40,7 +40,8 @@ describe('Plugin', () => {
     let dateNowStub
     let mockTime = 0
 
-    withVersions('avsc', ['avsc'], (version) => {
+    // avsc version 5.0.0 currently does not support a nodeMajor version greater than major version 24
+    withVersions('avsc', ['avsc'], NODE_MAJOR >= 25 ? '>5.0.0' : undefined, (version) => {
       before(() => {
         tracer = require('../../dd-trace').init()
         // reset sampled schemas
diff --git a/packages/datadog-plugin-fs/test/index.spec.js b/packages/datadog-plugin-fs/test/index.spec.js
@@ -205,9 +205,9 @@ describe('Plugin', () => {
         describe('promises.open', () => {
           let fd
 
-          afterEach(() => {
-            if (typeof fd === 'number') {
-              realFS.closeSync(fd)
+          afterEach(async () => {
+            if (fd && typeof fd.close === 'function') {
+              await fd.close()
               fd = undefined
             }
           })
@@ -1634,7 +1634,6 @@ describe('Plugin', () => {
           afterEach(async () => {
             try {
               await filehandle.close()
-              realFS.closeSync(filehandle.fd)
             } catch (e) { /* */ }
             await fs.promises.unlink(filename)
           })
diff --git a/packages/datadog-plugin-grpc/test/client.spec.js b/packages/datadog-plugin-grpc/test/client.spec.js
@@ -12,9 +12,9 @@ const loader = require('../../../versions/@grpc/proto-loader').get()
 const { withNamingSchema, withPeerService, withVersions } = require('../../dd-trace/test/setup/mocha')
 const agent = require('../../dd-trace/test/plugins/agent')
 const { ERROR_MESSAGE, ERROR_TYPE, ERROR_STACK, GRPC_CLIENT_ERROR_STATUSES } = require('../../dd-trace/src/constants')
+const { NODE_MAJOR } = require('../../../version')
 
-const nodeMajor = parseInt(process.versions.node.split('.')[0])
-const pkgs = nodeMajor > 14 ? ['@grpc/grpc-js'] : ['grpc', '@grpc/grpc-js']
+const pkgs = NODE_MAJOR > 14 ? ['@grpc/grpc-js'] : ['grpc', '@grpc/grpc-js']
 
 describe('Plugin', () => {
   let grpc
@@ -78,7 +78,7 @@ describe('Plugin', () => {
       server.forceShutdown()
     })
 
-    withVersions('grpc', pkgs, (version, pkg) => {
+    withVersions('grpc', pkgs, NODE_MAJOR >= 25 && '>=1.3.0', (version, pkg) => {
       for (const clientName in clientBuilders) {
         const buildClient = clientBuilders[clientName]
 
diff --git a/packages/datadog-plugin-grpc/test/integration-test/client.spec.js b/packages/datadog-plugin-grpc/test/integration-test/client.spec.js
diff --git a/packages/datadog-plugin-grpc/test/server.spec.js b/packages/datadog-plugin-grpc/test/server.spec.js
diff --git a/packages/datadog-plugin-next/test/index.spec.js b/packages/datadog-plugin-next/test/index.spec.js
diff --git a/packages/datadog-plugin-next/test/integration-test/client.spec.js b/packages/datadog-plugin-next/test/integration-test/client.spec.js
diff --git a/packages/dd-trace/test/config.spec.js b/packages/dd-trace/test/config.spec.js
diff --git a/version.js b/version.js
