From 06e5009b8666dcd816d9af9bbd70d1ef85bec5de Mon Sep 17 00:00:00 2001 From: Duncan Harvey Date: Mon, 21 Jul 2025 17:13:47 -0400 Subject: [PATCH] don't hardcode span type to serverless --- datadog-trace-utils/src/span/trace_utils.rs | 1 - datadog-trace-utils/src/test_utils/mod.rs | 2 -- datadog-trace-utils/src/trace_utils.rs | 3 --- 3 files changed, 6 deletions(-) diff --git a/datadog-trace-utils/src/span/trace_utils.rs b/datadog-trace-utils/src/span/trace_utils.rs index c52b79685b..6a0ae7c11f 100644 --- a/datadog-trace-utils/src/span/trace_utils.rs +++ b/datadog-trace-utils/src/span/trace_utils.rs @@ -193,7 +193,6 @@ mod tests { span.meta.insert("origin".into(), "cloudfunction".into()); span.meta .insert("functionname".into(), "dummy_function_name".into()); - span.r#type = "serverless".into(); } span } diff --git a/datadog-trace-utils/src/test_utils/mod.rs b/datadog-trace-utils/src/test_utils/mod.rs index 3f5a4594ca..c75ba2a5db 100644 --- a/datadog-trace-utils/src/test_utils/mod.rs +++ b/datadog-trace-utils/src/test_utils/mod.rs @@ -123,7 +123,6 @@ pub fn create_test_span( "functionname".to_string(), "dummy_function_name".to_string(), ); - span.r#type = "serverless".to_string(); } span } @@ -185,7 +184,6 @@ pub fn create_test_gcp_span( .insert("_dd.origin".to_string(), "cloudfunction".to_string()); span.meta .insert("origin".to_string(), "cloudfunction".to_string()); - span.r#type = "serverless".to_string(); } span } diff --git a/datadog-trace-utils/src/trace_utils.rs b/datadog-trace-utils/src/trace_utils.rs index 953524ad6e..3070a80f6c 100644 --- a/datadog-trace-utils/src/trace_utils.rs +++ b/datadog-trace-utils/src/trace_utils.rs @@ -436,7 +436,6 @@ pub fn set_serverless_root_span_tags( app_name: Option, env_type: &EnvironmentType, ) { - span.r#type = "serverless".to_string(); let origin_tag = match env_type { EnvironmentType::CloudFunction => "cloudfunction", EnvironmentType::AzureFunction => "azurefunction", @@ -1043,7 +1042,6 @@ mod tests { ("service".to_string(), "test-service".to_string()) ]), ); - assert_eq!(span.r#type, "serverless".to_string()) } #[test] @@ -1068,7 +1066,6 @@ mod tests { ("service".to_string(), "test-service".to_string()) ]), ); - assert_eq!(span.r#type, "serverless".to_string()) } #[test]