From e4d8b99ac8dbff7deb9e1001d9ac089730aab9c0 Mon Sep 17 00:00:00 2001 From: "Ida.Liu" Date: Fri, 7 Feb 2025 13:47:43 -0500 Subject: [PATCH 1/2] skip failing tests --- tests/parametric/test_headers_baggage.py | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/tests/parametric/test_headers_baggage.py b/tests/parametric/test_headers_baggage.py index 44550f44e08..0b8bb9a74cb 100644 --- a/tests/parametric/test_headers_baggage.py +++ b/tests/parametric/test_headers_baggage.py @@ -199,6 +199,10 @@ def _assert_valid_baggage(self, test_library): headers = test_library.dd_make_child_span_and_get_headers([["baggage", "foo=valid"]]) assert "baggage" in headers + @missing_feature( + context.library == "nodejs", + reason="`dd_make_child_span_and_get_headers` calls `dd_extract_headers_and_make_child_span`, which does not work with only baggage" + ) def test_baggage_malformed_headers_D012(self, test_library): """Ensure that malformed baggage headers are handled properly. Unable to use get_baggage functions because it does not return anything""" Test_Headers_Baggage._assert_valid_baggage(self, test_library) @@ -210,6 +214,10 @@ def test_baggage_malformed_headers_D012(self, test_library): assert "baggage" not in headers + @missing_feature( + context.library == "nodejs", + reason="`dd_make_child_span_and_get_headers` calls `dd_extract_headers_and_make_child_span`, which does not work with only baggage" + ) def test_baggage_malformed_headers_D013(self, test_library): """Ensure that malformed baggage headers are handled properly. Unable to use get_baggage functions because it does not return anything""" Test_Headers_Baggage._assert_valid_baggage(self, test_library) @@ -219,6 +227,10 @@ def test_baggage_malformed_headers_D013(self, test_library): assert "baggage" not in headers + @missing_feature( + context.library == "nodejs", + reason="`dd_make_child_span_and_get_headers` calls `dd_extract_headers_and_make_child_span`, which does not work with only baggage" + ) def test_baggage_malformed_headers_D014(self, test_library): Test_Headers_Baggage._assert_valid_baggage(self, test_library) @@ -227,6 +239,10 @@ def test_baggage_malformed_headers_D014(self, test_library): assert "baggage" not in headers + @missing_feature( + context.library == "nodejs", + reason="`dd_make_child_span_and_get_headers` calls `dd_extract_headers_and_make_child_span`, which does not work with only baggage" + ) def test_baggage_malformed_headers_D015(self, test_library): Test_Headers_Baggage._assert_valid_baggage(self, test_library) From 2e28e3a93599916dc56e291ca94453c001c21485 Mon Sep 17 00:00:00 2001 From: "Ida.Liu" Date: Fri, 7 Feb 2025 14:08:19 -0500 Subject: [PATCH 2/2] fix linter error --- tests/parametric/test_headers_baggage.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/parametric/test_headers_baggage.py b/tests/parametric/test_headers_baggage.py index 0b8bb9a74cb..c4d8e56a140 100644 --- a/tests/parametric/test_headers_baggage.py +++ b/tests/parametric/test_headers_baggage.py @@ -201,7 +201,7 @@ def _assert_valid_baggage(self, test_library): @missing_feature( context.library == "nodejs", - reason="`dd_make_child_span_and_get_headers` calls `dd_extract_headers_and_make_child_span`, which does not work with only baggage" + reason="`dd_make_child_span_and_get_headers` calls `dd_extract_headers_and_make_child_span`, which does not work with only baggage", ) def test_baggage_malformed_headers_D012(self, test_library): """Ensure that malformed baggage headers are handled properly. Unable to use get_baggage functions because it does not return anything""" @@ -216,7 +216,7 @@ def test_baggage_malformed_headers_D012(self, test_library): @missing_feature( context.library == "nodejs", - reason="`dd_make_child_span_and_get_headers` calls `dd_extract_headers_and_make_child_span`, which does not work with only baggage" + reason="`dd_make_child_span_and_get_headers` calls `dd_extract_headers_and_make_child_span`, which does not work with only baggage", ) def test_baggage_malformed_headers_D013(self, test_library): """Ensure that malformed baggage headers are handled properly. Unable to use get_baggage functions because it does not return anything""" @@ -229,7 +229,7 @@ def test_baggage_malformed_headers_D013(self, test_library): @missing_feature( context.library == "nodejs", - reason="`dd_make_child_span_and_get_headers` calls `dd_extract_headers_and_make_child_span`, which does not work with only baggage" + reason="`dd_make_child_span_and_get_headers` calls `dd_extract_headers_and_make_child_span`, which does not work with only baggage", ) def test_baggage_malformed_headers_D014(self, test_library): Test_Headers_Baggage._assert_valid_baggage(self, test_library) @@ -241,7 +241,7 @@ def test_baggage_malformed_headers_D014(self, test_library): @missing_feature( context.library == "nodejs", - reason="`dd_make_child_span_and_get_headers` calls `dd_extract_headers_and_make_child_span`, which does not work with only baggage" + reason="`dd_make_child_span_and_get_headers` calls `dd_extract_headers_and_make_child_span`, which does not work with only baggage", ) def test_baggage_malformed_headers_D015(self, test_library): Test_Headers_Baggage._assert_valid_baggage(self, test_library)