Some Ideas #10
alansbraga
started this conversation in
Feature Requests
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
Hello, I’m using Verso and I’d like to congratulate you for the amazing work. I would like to check a few possible changes with you:
I looked at the source code of the SchemaCache class and, from what I understood, it is limited to SQL Server and SQLite. I was thinking about making modifications to support FirebirdSQL and sending you a PR, but it will end up full of ifs. Could you structure it in a more separated/decoupled way so we can add new database providers without mixing everything together, before I start making these changes?
Depending on the situation, I like using the SQL cell approach, and in other cases I prefer using Dapper. Some options would help me a lot — I’m not sure which one works best for you:
a) expose the internal connection of SQL cells;
b) allow the connection string in SQL cells to accept variables;
c) allow SQL cells to accept a preconfigured DbConnection.
Note: I was having issues with Dapper and dynamic variables, but I found out that you just need to add the Microsoft.CSharp NuGet package.
This is pure nitpicking, but here it goes: in Polyglot, when we executed a cell, it was clear that it was running and when it finished, even if it was very fast. In Verso, we click Run and nothing seems to happen — sometimes I click several times just to be sure it actually executed, both in cells that return nothing and in cells that return something but didn’t visibly change anything.
Thank you very much for your work!
Beta Was this translation helpful? Give feedback.
All reactions