From a9c23779f8266c1a9eac8a21c726ae86e0c450a3 Mon Sep 17 00:00:00 2001
From: Parth Shah <parth@deepintent.com>
Date: Fri, 8 Oct 2021 15:43:12 +0530
Subject: [PATCH] addressed comments

---
 modules/deepintentBidAdapter.js | 13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)

diff --git a/modules/deepintentBidAdapter.js b/modules/deepintentBidAdapter.js
index b6bf1a06438..80ab001b518 100644
--- a/modules/deepintentBidAdapter.js
+++ b/modules/deepintentBidAdapter.js
@@ -9,26 +9,26 @@ export const ORTB_VIDEO_PARAMS = {
   'mimes': (value) => Array.isArray(value) && value.length > 0 && value.every(v => typeof v === 'string'),
   'minduration': (value) => utils.isInteger(value),
   'maxduration': (value) => utils.isInteger(value),
-  'protocols': (value) => Array.isArray(value) && value.every(v => [1, 2, 3, 4, 5, 6, 7, 8, 9, 10].indexOf(v) !== -1),
+  'protocols': (value) => Array.isArray(value) && value.every(v => v >= 1 && v <= 10),
   'w': (value) => utils.isInteger(value),
   'h': (value) => utils.isInteger(value),
   'startdelay': (value) => utils.isInteger(value),
-  'placement': (value) => Array.isArray(value) && value.every(v => [1, 2, 3, 4, 5].indexOf(v) !== -1),
+  'placement': (value) => Array.isArray(value) && value.every(v => v >= 1 && v <= 5),
   'linearity': (value) => [1, 2].indexOf(value) !== -1,
   'skip': (value) => [0, 1].indexOf(value) !== -1,
   'skipmin': (value) => utils.isInteger(value),
   'skipafter': (value) => utils.isInteger(value),
   'sequence': (value) => utils.isInteger(value),
-  'battr': (value) => Array.isArray(value) && value.every(v => Array.from({length: 17}, (_, i) => i + 1).indexOf(v) !== -1),
+  'battr': (value) => Array.isArray(value) && value.every(v => v >= 1 && v <= 17),
   'maxextended': (value) => utils.isInteger(value),
   'minbitrate': (value) => utils.isInteger(value),
   'maxbitrate': (value) => utils.isInteger(value),
   'boxingallowed': (value) => [0, 1].indexOf(value) !== -1,
-  'playbackmethod': (value) => Array.isArray(value) && value.every(v => [1, 2, 3, 4, 5, 6].indexOf(v) !== -1),
+  'playbackmethod': (value) => Array.isArray(value) && value.every(v => v >= 1 && v <= 6),
   'playbackend': (value) => [1, 2, 3].indexOf(value) !== -1,
   'delivery': (value) => [1, 2, 3].indexOf(value) !== -1,
   'pos': (value) => [0, 1, 2, 3, 4, 5, 6, 7].indexOf(value) !== -1,
-  'api': (value) => Array.isArray(value) && value.every(v => [1, 2, 3, 4, 5, 6].indexOf(v) !== -1)
+  'api': (value) => Array.isArray(value) && value.every(v => v >= 1 && v <= 6)
 };
 export const spec = {
   code: BIDDER_CODE,
@@ -177,7 +177,7 @@ function buildImpression(bid) {
 }
 
 function _buildVideo(bid) {
-  let videoObj = {};
+  const videoObj = {};
   const videoAdUnitParams = utils.deepAccess(bid, 'mediaTypes.video', {});
   const videoBidderParams = utils.deepAccess(bid, 'params.video', {});
   const computedParams = {};
@@ -199,7 +199,6 @@ function _buildVideo(bid) {
       if (ORTB_VIDEO_PARAMS[paramName](videoParams[paramName])) {
         videoObj[paramName] = videoParams[paramName];
       } else {
-        delete videoObj[paramName];
         utils.logWarn(`The OpenRTB video param ${paramName} has been skipped due to misformating. Please refer to OpenRTB 2.5 spec.`);
       }
     }