Skip to content

Commit 76e5fef

Browse files
committed
fix mypy lint
1 parent da62259 commit 76e5fef

File tree

2 files changed

+7
-2
lines changed

2 files changed

+7
-2
lines changed

devcycle_python_sdk/api/bucketing_client.py

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,12 +92,17 @@ def request(self, method: str, url: str, **kwargs) -> dict:
9292
def variable(self, key: str, user: DevCycleUser) -> Variable:
9393
data = self.request("POST", self._url("variables", key), json=user.to_json())
9494

95+
eval_data = data.get("eval")
96+
eval_reason = None
97+
if eval_data is not None and isinstance(eval_data, dict):
98+
eval_reason = EvalReason.from_json(eval_data)
99+
95100
return Variable(
96101
_id=data.get("_id"),
97102
key=data.get("key", ""),
98103
type=data.get("type", ""),
99104
value=data.get("value"),
100-
eval=EvalReason.from_json(data.get("eval")) if data.get("eval") else None,
105+
eval=eval_reason,
101106
)
102107

103108
def variables(self, user: DevCycleUser) -> Dict[str, Variable]:

devcycle_python_sdk/models/variable.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ def from_json(cls, data: dict) -> "Variable":
6767

6868
@staticmethod
6969
def create_default_variable(
70-
key: str, default_value: Any, default_reason_detail: str = None
70+
key: str, default_value: Any, default_reason_detail: Optional[str] = None
7171
) -> "Variable":
7272
var_type = determine_variable_type(default_value)
7373
if default_reason_detail is not None:

0 commit comments

Comments
 (0)