From a31275149af3567c6ad10629f6dd6d4e016760f8 Mon Sep 17 00:00:00 2001 From: Jonathan Norris Date: Sun, 20 Apr 2025 21:28:28 -0400 Subject: [PATCH 1/2] chore: cleanup SSE function names --- devcycle_python_sdk/managers/sse_manager.py | 29 ++++++++++----------- 1 file changed, 14 insertions(+), 15 deletions(-) diff --git a/devcycle_python_sdk/managers/sse_manager.py b/devcycle_python_sdk/managers/sse_manager.py index d39b6d4..e743692 100644 --- a/devcycle_python_sdk/managers/sse_manager.py +++ b/devcycle_python_sdk/managers/sse_manager.py @@ -5,39 +5,38 @@ import ld_eventsource.config from typing import Callable - class SSEManager: def __init__( self, - handlestate: Callable[[ld_eventsource.actions.Start], None], - handleerror: Callable[[ld_eventsource.actions.Fault], None], - handlemessage: Callable[[ld_eventsource.actions.Event], None], + handle_state: Callable[[ld_eventsource.actions.Start], None], + handle_error: Callable[[ld_eventsource.actions.Fault], None], + handle_message: Callable[[ld_eventsource.actions.Event], None], ): self.client: ld_eventsource.SSEClient = None self.url = "" - self.handlestate = handlestate - self.handleerror = handleerror - self.handlemessage = handlemessage + self.handle_state = handle_state + self.handle_error = handle_error + self.handle_message = handle_message self.read_thread = threading.Thread( target=self.read_events, - args=(self.handlestate, self.handleerror, self.handlemessage), + args=(self.handle_state, self.handle_error, self.handle_message), ) def read_events( self, - handlestate: Callable[[ld_eventsource.actions.Start], None], - handleerror: Callable[[ld_eventsource.actions.Fault], None], - handlemessage: Callable[[ld_eventsource.actions.Event], None], + handle_state: Callable[[ld_eventsource.actions.Start], None], + handle_error: Callable[[ld_eventsource.actions.Fault], None], + handle_message: Callable[[ld_eventsource.actions.Event], None], ): self.client.start() for event in self.client.all: if isinstance(event, ld_eventsource.actions.Start): - handlestate(event) + handle_state(event) elif isinstance(event, ld_eventsource.actions.Fault): - handleerror(event) + handle_error(event) elif isinstance(event, ld_eventsource.actions.Event): - handlemessage(event) + handle_message(event) def update(self, config: dict): if self.use_new_config(config["sse"]): @@ -52,7 +51,7 @@ def update(self, config: dict): ) self.read_thread = threading.Thread( target=self.read_events, - args=(self.handlestate, self.handleerror, self.handlemessage), + args=(self.handle_state, self.handle_error, self.handle_message), ) self.read_thread.start() From 55180f0eeb582d418625eee579ab1c3dee66f316 Mon Sep 17 00:00:00 2001 From: Jonathan Norris Date: Sun, 20 Apr 2025 21:38:05 -0400 Subject: [PATCH 2/2] chore: run black formatter --- devcycle_python_sdk/managers/sse_manager.py | 1 + 1 file changed, 1 insertion(+) diff --git a/devcycle_python_sdk/managers/sse_manager.py b/devcycle_python_sdk/managers/sse_manager.py index e743692..b614144 100644 --- a/devcycle_python_sdk/managers/sse_manager.py +++ b/devcycle_python_sdk/managers/sse_manager.py @@ -5,6 +5,7 @@ import ld_eventsource.config from typing import Callable + class SSEManager: def __init__( self,