refactor: update accent color hover effects to Footer#185
Conversation
- Update Footer links to use --accent-primary on hover - Update ThemeToggle icons to use --accent-primary on hover - Both components adapt colors to light/dark theme
✅ Deploy Preview for develop-devlovers ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
📝 WalkthroughWalkthroughFooter and ThemeToggle were updated to use CSS variables (--accent-primary, --accent-hover) for accent and hover colors; ThemeToggle also received minor formatting changes and a new Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
frontend/components/shared/Footer.tsx (1)
94-106: Mirror hover accent on keyboard focus for social icons.
Focus-visible should get the same accent color as hover for accessibility parity.♿ Proposed tweak
[&:hover]:!text-[var(--accent-primary)] [&:hover]:!border-[var(--accent-primary)] + focus-visible:!text-[var(--accent-primary)] + focus-visible:!border-[var(--accent-primary)]
🤖 Fix all issues with AI agents
In `@frontend/components/shared/Footer.tsx`:
- Around line 59-69: The legal links in Footer (the Link components rendering
privacyPolicy and termsOfService) only change color on hover, so add a matching
focus-visible state to improve keyboard accessibility; update the className on
those Link elements (and any sibling Link usages here) to include
focus-visible:[color:var(--accent-hover)] or an equivalent focus-visible style
(e.g., ring or outline with the same accent) so keyboard users see the same
visual feedback as hover.
In `@frontend/components/theme/ThemeToggle.tsx`:
- Around line 57-61: The hover rule only styles the SVG on mouse hover; add the
matching keyboard focus-visible rule so keyboard users see the same accent:
update the ThemeToggle component styles (the .theme-toggle-btn:hover
:global(svg) rule) to also include a .theme-toggle-btn:focus-visible
:global(svg) rule that sets color: var(--accent-primary) (and ensure the button
receives a visible focus ring if not already handled).
- Add focus-visible styles for keyboard navigation accessibility
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.