From 3262cf6a48856a821dfba17f93b3af6160d32574 Mon Sep 17 00:00:00 2001 From: igorskyflyer Date: Fri, 15 Aug 2025 21:27:05 +0200 Subject: [PATCH 1/2] Fix npm scoped packages IDs --- .../Helpers/NpmPkgOperationHelper.cs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/UniGetUI.PackageEngine.Managers.Npm/Helpers/NpmPkgOperationHelper.cs b/src/UniGetUI.PackageEngine.Managers.Npm/Helpers/NpmPkgOperationHelper.cs index 3930f24360..3919e64f8a 100644 --- a/src/UniGetUI.PackageEngine.Managers.Npm/Helpers/NpmPkgOperationHelper.cs +++ b/src/UniGetUI.PackageEngine.Managers.Npm/Helpers/NpmPkgOperationHelper.cs @@ -12,12 +12,12 @@ protected override IReadOnlyList _getOperationParameters(IPackage packag InstallOptions options, OperationType operation) { List parameters = operation switch { - OperationType.Install => [Manager.Properties.InstallVerb, $"{package.Id}@{(options.Version == string.Empty? package.VersionString: options.Version)}"], - OperationType.Update => [Manager.Properties.UpdateVerb, $"{package.Id}@{package.NewVersionString}"], + OperationType.Install => [Manager.Properties.InstallVerb, $"'{package.Id}@{(options.Version == string.Empty? package.VersionString: options.Version)}'"], + OperationType.Update => [Manager.Properties.UpdateVerb, $"'{package.Id}@{package.NewVersionString}'"], OperationType.Uninstall => [Manager.Properties.UninstallVerb, package.Id], _ => throw new InvalidDataException("Invalid package operation") }; - parameters.Add(package.Id); + parameters.Add($"'{package.Id}'"); if (package.OverridenOptions.Scope == PackageScope.Global || (package.OverridenOptions.Scope is null && options.InstallationScope == PackageScope.Global)) From 142232d022b74d771fce03a0a97fd434795480a7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mart=C3=AD=20Climent?= Date: Sat, 23 Aug 2025 19:12:57 +0200 Subject: [PATCH 2/2] remove redundant parameter npm --- .../Helpers/NpmPkgOperationHelper.cs | 1 - 1 file changed, 1 deletion(-) diff --git a/src/UniGetUI.PackageEngine.Managers.Npm/Helpers/NpmPkgOperationHelper.cs b/src/UniGetUI.PackageEngine.Managers.Npm/Helpers/NpmPkgOperationHelper.cs index 3919e64f8a..dbe1d18a29 100644 --- a/src/UniGetUI.PackageEngine.Managers.Npm/Helpers/NpmPkgOperationHelper.cs +++ b/src/UniGetUI.PackageEngine.Managers.Npm/Helpers/NpmPkgOperationHelper.cs @@ -17,7 +17,6 @@ protected override IReadOnlyList _getOperationParameters(IPackage packag OperationType.Uninstall => [Manager.Properties.UninstallVerb, package.Id], _ => throw new InvalidDataException("Invalid package operation") }; - parameters.Add($"'{package.Id}'"); if (package.OverridenOptions.Scope == PackageScope.Global || (package.OverridenOptions.Scope is null && options.InstallationScope == PackageScope.Global))