From 6def1e355dbf87cf3539528d04d7caeeed768862 Mon Sep 17 00:00:00 2001 From: konstntokas Date: Tue, 15 Apr 2025 16:15:51 +0200 Subject: [PATCH 1/2] issue already resolved by filter --- xarray_eopf/filter.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/xarray_eopf/filter.py b/xarray_eopf/filter.py index 675ce36..3138d3a 100644 --- a/xarray_eopf/filter.py +++ b/xarray_eopf/filter.py @@ -5,6 +5,7 @@ from typing import Iterable import xarray as xr +from dask.core import keys_in_tasks from .utils import NameFilter @@ -17,9 +18,8 @@ def filter_dataset( return dataset name_filter = NameFilter(includes=variables) names = set(map(str, dataset.variables.keys())) + # find all dataset variables including respective coordinates drop_names = names - set(name_filter.filter(names)) if drop_names: - # TODO: also drop now unused coordinates + dimensions as - # they remain even if no longer referenced by any data variables dataset = dataset.drop_vars(drop_names) return dataset From c283836c72373005fd0b8a7ac14d5a78978e7155 Mon Sep 17 00:00:00 2001 From: konstntokas Date: Tue, 15 Apr 2025 16:22:53 +0200 Subject: [PATCH 2/2] review addressed --- xarray_eopf/filter.py | 1 - 1 file changed, 1 deletion(-) diff --git a/xarray_eopf/filter.py b/xarray_eopf/filter.py index 3138d3a..07b305c 100644 --- a/xarray_eopf/filter.py +++ b/xarray_eopf/filter.py @@ -5,7 +5,6 @@ from typing import Iterable import xarray as xr -from dask.core import keys_in_tasks from .utils import NameFilter