sphinx: fix potential data leak.#3246
Merged
Merged
Conversation
…ossip! It currently works because we inject it so fast that it's still doing the txout lookup, but that's about to change. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
…re options. And drive-by fix: document that you can now (since e40f078) use --max-messages=0. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
This correctly refreshes the txout entry against aging. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
This prevents a gratuitous lookup of we get a late channel_announce, but even better, it suppresses the "bad gossip" messages in case of a late channel_update, which have plagued Travis (especially since we got aggressive in pushing our own updates). Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Collaborator
|
ACK 5a24039 |
cdecker
force-pushed
the
fix-sphinx-padding
branch
2 times, most recently
from
ede7b9b to
34b60b2
Compare
Member
|
I'd prefer we have a way to turn the random bytes off, or at least produce them in a reproducible way, e.g., usin chacha20 which is already in use elsewhere in the onion. Otherwise we'll end up without test-vectors. |
Contributor
Author
Well, we already have a backdoor to set the session_key for testing, so we'd just need another one. But you're right: generating it this way is Just Good Practice anyway, so let's do that. Take II coming. |
lightning/bolts#697 https://lists.linuxfoundation.org/pipermail/lightning-dev/2019-November/002288.html We generate it from an hmac using the session secret. It's not clear that this will be useful for reproducing test vectors though, since we don't generate the first 66 bytes, which is what the spec says to do. Reported-by: @Roasbeef Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
rustyrussell
force-pushed
the
fix-sphinx-padding
branch
from
34b60b2 to
d8c386a
Compare
Member
|
ACK d8c386a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[ Based on #3245 to keep Travis happy: just look at last commit ]
lightning/bolts#697
https://lists.linuxfoundation.org/pipermail/lightning-dev/2019-November/002288.html
Reported-by: @Roasbeef
Signed-off-by: Rusty Russell rusty@rustcorp.com.au
Changelog-None