Conversation
dalonsoa
approved these changes
Nov 5, 2024
Collaborator
dalonsoa
left a comment
dalonsoa
left a comment
There was a problem hiding this comment.
This changes all make sense, specially because they remove ambiguity.
Remember to mention in the release note for the next release that these outputs are no longer available.
| return _aggregate_sectors(sectors, market_out, op=sector_supply) | ||
|
|
||
|
|
||
| def sector_supply(sector: AbstractSector, market: xr.Dataset, **kwargs) -> pd.DataFrame: |
Collaborator
There was a problem hiding this comment.
The infamous sector_supply function, gone for good!
| return _aggregate_sectors(sectors, market_out, op=sectory_supply) | ||
|
|
||
|
|
||
| def sectory_supply( |
Collaborator
There was a problem hiding this comment.
What the heck is sectory_supply? I hadn't seen this before...
Merged
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deletes outputs that aren't required any more, as discussed in #413
Deleting these because they are known to be unreliable (e.g. #312), and all the relevant data can be created with other global/sector outputs
I advised in the release notes for v1.2.0 that these would eventually be deleted, so nobody should still be using these anyway.
Will save this for v1.3.0 along with #507 #510 and others