-
Notifications
You must be signed in to change notification settings - Fork 10
Configurable timeslice level for sectors #550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
117 commits
Select commit
Hold shift + click to select a range
fa59017
Add comments and simplify sector.next
tsmbland 697ff3f
Simplify agent module, more comments
tsmbland b47c811
Simplify retirment profile code
tsmbland a86e07f
Simplify merge_assets
tsmbland 3e51311
Revert change to merge_assets
tsmbland 941a5a6
Delete unused factory
tsmbland 9d2cac9
More comments added to code
tsmbland e386da1
Revert some changes to fix tests
tsmbland 018ca5c
Fix tests
tsmbland 4fd2e79
Small fix to another test
tsmbland 51a5273
Delete legacy sector
tsmbland 1518034
Delete tests and documentation
tsmbland 3b0cb49
Remove more redundant code
tsmbland 3a05344
Delete new_to_old_timeslice function
tsmbland 977647d
Remove unnecessary convert_timeslice operations
tsmbland 647d3fe
Use global TIMESLICE variable throughout
tsmbland 8faf468
Simplify some other parts of the code accordingly
tsmbland 65c3e48
Draft new function with intended behaviour
tsmbland d9eb060
Use new function wherever possible
tsmbland 7ebab9e
Update tests
tsmbland a0fe43c
Remove represent_hours function
tsmbland c2b94e7
Fix issue with timeslice ordering
tsmbland 5cbc8f2
Remove remaining convert_timeslice calls
tsmbland 81e7a6a
Simplify timeslice_op function
tsmbland 19cf269
Delete old convert_timeslice function
tsmbland 57c1c73
Delete unused functions
tsmbland e4150e3
Simplify timeslie import process
tsmbland dc8b8b8
Formatting
tsmbland 0288459
Default arguments for convert_timeslice
tsmbland c7f67f4
Update results files
tsmbland 9360ad1
Merge branch 'refactor' into legacy
tsmbland b2e8294
Merge branch 'legacy' into convert_timeslice2
tsmbland 94ef9b7
Merge branch 'legacy' into convert_timeslice2
tsmbland cc9d237
Fix test
tsmbland acdcbf8
Merge branch 'refactor' into legacy
tsmbland 89f8c61
Carry changes from fix_supply_issue2 branch
tsmbland 793aacf
More benign changes
tsmbland 22c141e
Fix incorrect convert_timeslice usage in tests
tsmbland a59580c
Fix timeslice import in tests
tsmbland 993af9f
Delete unused fixture
tsmbland 908872a
Fix market fixtures
tsmbland e0a8c3a
More test fixes
tsmbland 8034807
Fix a fixture
tsmbland 86d7dd2
Merge branch 'legacy' into convert_timeslice2
tsmbland 1bd7c84
Move default timeslice settings to conftest
tsmbland c616694
Fix docstring tests
tsmbland d054a3b
A few more tiny changes (e.g. typing)
tsmbland 0c84ba9
Remove inline comment
tsmbland 65313de
Merge branch 'v1.3' into refactor
tsmbland 4ce54e6
Merge branch 'refactor' into legacy
tsmbland ad3766e
Merge branch 'legacy' into convert_timeslice2
tsmbland a02088e
Small changes
tsmbland 4785412
Fix constraints tests
tsmbland 88d40b4
Fix remaining tests
tsmbland 4fbc1ff
Create separate functions for broadcasting and distributing timeslices
tsmbland 0258ae9
Check for existing timeslice dimension in broadcast_timeslice
tsmbland b0ce228
Fix test
tsmbland 8d06e85
Merge branch 'v1.3' into refactor
tsmbland 5c5fc45
Merge branch 'refactor' into legacy
tsmbland 8149020
Merge branch 'legacy' into convert_timeslice2
tsmbland 885f752
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 433c39c
Fix merge conflicts
tsmbland 6975787
Merge branch 'broadcast_errors2' into refactor
tsmbland 2e601ea
Merge branch 'v1.2.2' into refactor
tsmbland 423fafe
Merge branch 'main' into refactor
tsmbland c270dfa
Merge branch 'main' into refactor
tsmbland b521d93
Merge branch 'refactor' into legacy
tsmbland fde592b
Merge branch 'legacy' into convert_timeslice2
tsmbland d5875f9
Fix tests
tsmbland 46ab820
Remove timeslice arguments
tsmbland d5b5676
Fix tests
tsmbland ae3c06c
Turn off automatic broadcasting over the timeslice dimension (#530)
tsmbland 366c37c
Drop convert_market_timeslice
tsmbland 908be7b
Remove timeslice attribute from sectors
tsmbland 15ebf84
Add dummy timeslice_level argument
tsmbland 8b36797
Read timeslice_level from settings file
tsmbland 0d2a19e
Add basic transforms
tsmbland d3604dc
Merge branch 'v1.3' into convert_timeslice2
tsmbland a552029
Merge branch 'convert_timeslice2' into timeslice_level
tsmbland 8c4a8c4
Merge branch 'v1.3' into timeslice_level
tsmbland 4ff56c2
Fix some errors from merge
tsmbland 738e07d
Placeholder functions for sector conversion
tsmbland ff847bb
Functions working with single timeslice level
tsmbland cb5b9a1
Working compress_timeslice function
tsmbland 62ab9ac
Typing, remove aggregates, skeleton for tests
tsmbland b51143e
Skeleton for tests
tsmbland 1f35e8d
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 8c772d7
Restore patch to tests
tsmbland 66bbd5a
Merge branch 'timeslice_level' of https://github.com/EnergySystemsMod…
tsmbland 597a203
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 08234e2
Tests for broadcast and distribute, replace transforms with compress
tsmbland 78f50f4
Test for compress_timeslice
tsmbland ef8ecf2
Finish functions and tests
tsmbland 270ffff
Change type hinting to work with 3.9
tsmbland 0188872
Same again
tsmbland 8414c28
Lint
tsmbland 1eab863
Improve tests
tsmbland 7901d1a
Add parameter descriptions
tsmbland 6dadde1
Docstrings for new functions, use get_level
tsmbland 5904acd
Add documentation
tsmbland ddeedeb
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] d57d324
Finish compress_timeslice (still small todo)
tsmbland cf273c0
Merge branch 'timeslice_level' of https://github.com/EnergySystemsMod…
tsmbland 4fd085c
sort_timeslice and timeslice_max functions
tsmbland dcbed0d
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 1014751
New tests, some robustness improvements
tsmbland 88e0540
Move import statements
tsmbland 959148d
Add check to sector init
tsmbland 4a81d94
Variable names, docstrings
tsmbland dff094f
Apply default timeslice level to sector
tsmbland 82f5861
Fix adhoc bug, add warning
tsmbland 8ca30ba
Fix error in convert_to_global_timeslicing
tsmbland 45aa865
Merge branch 'v1.3' into timeslice_level
tsmbland 6171d32
Merge branch 'v1.3' into timeslice_level
tsmbland 07074cd
Use modern syntax for type annotations
tsmbland 220fb27
Address reviewer comments
tsmbland 26904c9
Merge branch 'v1.3' into timeslice_level
tsmbland File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing to do with the PR, but I've always found the use of cursive headers in the documentation pretty useless: they do not highlight that much the text and you cannot directly link the section from somewhere else. I'd suggest at some point to revamp the docs and use, eg. level 5 headers or something like that. See the Sphinx docs for that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wish we were using markdown as it's so much nicer to work with, but I guess it's too late for that