fix: Resolve integration test failures and enhance static binary export extraction

[Copilot]

• Fix integration test compilation errors (duplicate function name, missing imports, duplicate test attribute)
• Add tempfile dependency for test temp directory management
• Fix dynamic test to compile without -static flag for proper import detection
• Enhance ELF export extraction to check both dynamic and regular symbol tables
• Support both global and weak bindings for exports (matching import logic)
• Add symbol type filtering for exports (functions, objects, notype)
• Fix formatting issues
• Update cargo-dist version to 0.30.2 and regenerate release workflow
• Optimize duplicate detection with HashSet for O(1) lookups instead of O(n²) iteration

---

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

Summary by CodeRabbit

• Bug Fixes
  • Enhanced ELF export handling to eliminate duplicate symbols and ensure more comprehensive symbol coverage from multiple sources.

Walkthrough

ELF export collection logic now deduplicates symbol entries using a HashSet to track seen names. Exports are gathered from both dynamic and static symbol tables. Dynamic symbol handling skips empty names; static symbol handling includes FUNC, OBJECT, and NOTYPE symbol types from the static table and deduplicates against previously seen names. Ordinal assignment remains None.

Changes

Cohort / File(s)	Summary
ELF symbol table deduplication src/container/elf.rs	Introduces HashSet-based deduplication for export collection. Extends symbol gathering to both dynamic and static symbol tables. Dynamic symbols now skip empty names; static symbols filter by type (FUNC, OBJECT, NOTYPE) and use regular string table. Duplicate entries eliminated across both sources.
Test documentation tests/integration_elf.rs	Comment clarification noting that the regular gcc path is attempted for dynamically linked ELF output in cross-compiler fallback scenarios.

Sequence Diagram

sequenceDiagram
    participant Collector as Export Collector
    participant DynSym as Dynamic Symbol Table
    participant StaticSym as Static Symbol Table
    participant Dedup as HashSet (Seen Names)
    participant Result as Exports

    Collector->>DynSym: Iterate dynamic symbols
    DynSym-->>Collector: Symbol names
    
    rect rgb(220, 240, 255)
    note over Collector,Dedup: Process Dynamic Symbols
    Collector->>Collector: Skip empty names
    Collector->>Dedup: Check if seen
    alt Not seen
        Dedup-->>Collector: Add to set
        Collector->>Result: Append export
    else Already seen
        Dedup-->>Collector: Skip
    end
    end

    Collector->>StaticSym: Iterate static symbols
    StaticSym-->>Collector: FUNC/OBJECT/NOTYPE symbols
    
    rect rgb(240, 220, 255)
    note over Collector,Dedup: Process Static Symbols
    Collector->>Dedup: Check if seen
    alt Not seen
        Dedup-->>Collector: Add to set
        Collector->>Result: Append export
    else Already seen
        Dedup-->>Collector: Skip (deduplicate)
    end
    end

    Result-->>Collector: Final deduplicated exports

Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

• Key areas requiring attention:
  • Verify HashSet logic correctly deduplicates symbols across dynamic and static tables
  • Confirm FUNC, OBJECT, and NOTYPE symbol type filtering is exhaustive and correct for the use case
  • Validate that static symbol table string table lookup (regular string table vs. dynamic) is correct
  • Ensure the two-pass collection doesn't introduce performance concerns or incorrect symbol ordering

Possibly related issues

• Enhance ELF Dynamic Symbol Extraction with Library Mapping and Comprehensive Symbol Classification #2: Both changes modify ELF export extraction logic by gathering from .dynsym and static symbol tables, adding OBJECT/NOTYPE symbol type handling, and implementing deduplication mechanisms for symbol collection.

Poem

🐰 Hops through symbol tables with glee,
Deduplicating FUNC, OBJECT, what a spree!
Dynamic and static now work as one,
No duplicate exports—the cleanup is done! ✨

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch copilot/sub-pr-45

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between b27473d and 9943114.

📒 Files selected for processing (2)

• src/container/elf.rs (2 hunks)
• tests/integration_elf.rs (1 hunks)

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[dosubot]

Related Documentation

Checked 9 published document(s) in 1 knowledge base(s). No updates required.

^{How did I do? Any feedback?}  

[Copilot]

Pull Request Overview

This PR enhances ELF export extraction to handle both dynamically linked and statically linked binaries. The main improvements include support for weak symbols, empty name filtering, and extraction from the regular symbol table (.symtab) in addition to the dynamic symbol table (.dynsyms).

Key Changes:

• Added support for weak symbol bindings (STB_WEAK) in addition to global symbols
• Added empty name filtering to avoid exporting unnamed symbols
• Implemented regular symbol table (.symtab) parsing to extract exports from statically linked binaries

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
tests/integration_elf.rs	Updated comment to clarify that fallback gcc compilation produces dynamically linked binaries
src/container/elf.rs	Enhanced export extraction to support weak symbols, filter empty names, and parse regular symbol table for static binary exports

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The duplicate detection logic has O(n²) time complexity. Each time you check !exports.iter().any(|exp| exp.name == name), you iterate through all existing exports. For binaries with many symbols, this can be slow.

Consider using a HashSet to track seen names for O(1) lookups:

use std::collections::HashSet;

// At the start of extract_exports
let mut seen_names = HashSet::new();

// When adding exports from dynsyms:
if !name.is_empty() && seen_names.insert(name.to_string()) {
    exports.push(ExportInfo { ... });
}

// When adding exports from syms:
if !name.is_empty() && seen_names.insert(name.to_string()) {
    exports.push(ExportInfo { ... });
}

[Copilot]

Optimized duplicate detection using HashSet for O(1) lookups. The seen_names HashSet now tracks all exported names, eliminating the O(n²) iteration through the exports vector. Commit: 9943114

[unclesp1d3r]

@copilot apply changes based on the comments in this thread

[unclesp1d3r]

@coderabbitai Enhance this issue body with additional context and a proposed solution. Improve the issue title and assign the proper labels and other metadata.

[coderabbitai]

Tip

For best results, initiate chat on the files or code changes.

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash

# Get the PR review comments for review ID 3440404299
gh api /repos/EvilBit-Labs/StringyMcStringFace/pulls/51/reviews/3440404299/comments --jq '.[] | {path: .path, body: .body, line: .line}'

# Also get the PR details to understand context
gh pr view 51 --repo EvilBit-Labs/StringyMcStringFace --json title,body,comments,reviews

# List recent issues to see if one was created from this review
gh issue list --repo EvilBit-Labs/StringyMcStringFace --limit 10 --json number,title,body,url

Length of output: 44610

---

🏁 Script executed:

#!/bin/bash

# Search for any issue that might reference the PR or review
gh issue list --repo EvilBit-Labs/StringyMcStringFace --limit 50 --json number,title,body,url,labels | \
  jq '.[] | select(.body | contains("51") or contains("HashSet") or contains("duplicate") or contains("3440404299"))'

# Also check if there are any issues created very recently (today)
gh issue list --repo EvilBit-Labs/StringyMcStringFace --state all --limit 5 --json number,title,createdAt,url | jq '.'

# Search the PR for linked issues
gh pr view 51 --repo EvilBit-Labs/StringyMcStringFace --json body,comments --jq '.comments[] | select(.body | contains("#") or contains("issue"))'

Length of output: 28423

---

🏁 Script executed:

#!/bin/bash

# Check the PR body for any linked issues
gh pr view 51 --repo EvilBit-Labs/StringyMcStringFace --json body --jq '.body'

# Search for any issues created today or very recently
gh issue list --repo EvilBit-Labs/StringyMcStringFace --state all --json number,title,body,createdAt,url --limit 20 | \
  jq '.[] | select(.createdAt > "2025-11-09")'

# Also check if there are any open issues
gh issue list --repo EvilBit-Labs/StringyMcStringFace --state open --json number,title,createdAt,url | jq '.'

# Try to find issues with keywords related to the optimization
gh issue list --repo EvilBit-Labs/StringyMcStringFace --search "duplicate OR HashSet OR O(n) OR optimization OR export" --json number,title,body,url --limit 10

Length of output: 7111

---

@unclesp1d3r: I couldn't locate a specific issue related to the review thread you referenced. The review comment is about the HashSet optimization for duplicate detection in src/container/elf.rs, which has already been implemented and marked as complete in PR #51.

Could you please clarify which issue you'd like me to enhance? You can:

1. Provide the issue number (e.g., Implement String Deduplication with Metadata Preservation #13 for "Implement String Deduplication with Metadata Preservation" if that's the one)
2. Link directly to the issue you're viewing
3. Ask me to create a new issue to document the HashSet optimization that was completed in this PR

Once you let me know the specific issue number, I'll be happy to enhance it with additional context, improve the title, and assign appropriate labels and metadata!

[unclesp1d3r]

@coderabbitai full review

[coderabbitai]

✅ Actions performed

Full review triggered.