Skip to content

Commit 474e4cb

Browse files
authored
Merge pull request #83063 from callstack-internal/use-card-name-from-original-message
[Internal QA]: Use card name from Original Message for concierge
2 parents 8973418 + 84c1687 commit 474e4cb

File tree

3 files changed

+9
-5
lines changed

3 files changed

+9
-5
lines changed

src/libs/ReportActionsUtils.ts

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -416,9 +416,8 @@ function getOriginalMessage<T extends ReportActionName>(reportAction: OnyxInputO
416416
return reportAction.originalMessage;
417417
}
418418

419-
function getCardConnectionBrokenMessage(card: Card | undefined, translate: LocaleContextProps['translate'], connectionLink?: string) {
420-
const cardName = card?.cardName;
421-
const personalCardName = cardName ?? getBankName(card?.bank as CompanyCardFeed);
419+
function getCardConnectionBrokenMessage(card: Card | undefined, originalCardName: string | undefined, translate: LocaleContextProps['translate'], connectionLink?: string) {
420+
const personalCardName = originalCardName ?? card?.cardName ?? getBankName(card?.bank as CompanyCardFeed);
422421
return translate('personalCard.conciergeBrokenConnection', {cardName: personalCardName, connectionLink});
423422
}
424423

src/pages/inbox/report/PureReportActionItem.tsx

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1656,12 +1656,14 @@ function PureReportActionItem({
16561656
/>
16571657
);
16581658
} else if (isCardBrokenConnectionAction(action)) {
1659-
const cardID = getOriginalMessage(action)?.cardID;
1659+
const message = getOriginalMessage(action);
1660+
const cardID = message?.cardID;
1661+
const cardName = message?.cardName;
16601662
const card = cardID ? cardList?.[cardID] : undefined;
16611663
const connectionLink = cardID && isPersonalCardBrokenConnection(card) ? `${environmentURL}/${ROUTES.SETTINGS_WALLET_PERSONAL_CARD_DETAILS.getRoute(String(cardID))}` : undefined;
16621664
children = (
16631665
<ReportActionItemBasicMessage message="">
1664-
<RenderHTML html={`<comment>${getCardConnectionBrokenMessage(card, translate, connectionLink)}</comment>`} />
1666+
<RenderHTML html={`<comment>${getCardConnectionBrokenMessage(card, cardName, translate, connectionLink)}</comment>`} />
16651667
</ReportActionItemBasicMessage>
16661668
);
16671669
} else if (isActionOfType(action, CONST.REPORT.ACTIONS.TYPE.EXPORTED_TO_INTEGRATION)) {

src/types/onyx/OriginalMessage.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1225,6 +1225,9 @@ type OriginalPersonalCard = {
12251225

12261226
/** The id of the card */
12271227
cardID: number;
1228+
1229+
/** The name of the card */
1230+
cardName?: string;
12281231
};
12291232

12301233
/**

0 commit comments

Comments
 (0)