fix: hoist getUserFriendlyKey out of map and justify eslint-disable

Address AI reviewer feedback:
- PERF-13: Hoist iterator-independent getUserFriendlyKey() call outside
  the .map() in the currency case
- CONSISTENCY-5: Add justification comment for eslint-disable in tests

Co-authored-by: Cursor <cursoragent@cursor.com>

Author: mountiny

src/hooks/useAutocompleteSuggestions.ts

@@ -158,8 +158,9 @@ function useAutocompleteSuggestions({
                 .sort()
                 .slice(0, 10);
 
+            const friendlyKey = getUserFriendlyKey(autocompleteKey);
             return filteredCurrencies.map((currencyName) => ({
-                filterKey: getUserFriendlyKey(autocompleteKey),
+                filterKey: friendlyKey,
                 text: currencyName,
             }));
         }

tests/unit/hooks/useAutocompleteSuggestions.test.ts

@@ -78,7 +78,7 @@ jest.mock('@libs/SearchUIUtils', () => ({
     getHasOptions: jest.fn(() => [{value: 'attachment'}, {value: 'note'}]),
 }));
 
-// eslint-disable-next-line @typescript-eslint/naming-convention
+// eslint-disable-next-line @typescript-eslint/naming-convention -- jest.requireMock returns a module-shaped object; destructured name must match the original export
 const {parseForAutocomplete} = jest.requireMock<{parseForAutocomplete: jest.Mock}>('@libs/SearchAutocompleteUtils');
 
 const defaultParams = {