From c935d5106244c2faa1225199e57a7ab52962f93e Mon Sep 17 00:00:00 2001 From: Georgia Monahan Date: Fri, 4 Nov 2022 12:06:22 -0700 Subject: [PATCH 01/16] 1:1 swap to dark mode colors. --- src/styles/colors.js | 49 +++++++++++++++++++++++++++++--------------- 1 file changed, 33 insertions(+), 16 deletions(-) diff --git a/src/styles/colors.js b/src/styles/colors.js index f195cd62ebb41..ad692caeec1c9 100644 --- a/src/styles/colors.js +++ b/src/styles/colors.js @@ -1,21 +1,38 @@ export default { - white: '#FFFFFF', - gray1: '#FAFAFA', - gray2: '#ECECEC', - gray3: '#C6C9CA', + // NOTE: DEPRECATED COLOR NAMES + white: '#061B09', + gray1: '#002E22', + gray2: '#1B5744', + gray3: '#8B9C8F', gray4: '#7D8B8F', - dark: '#0b1b34', - black: '#000000', - blue: '#0185ff', - blueHover: '#0063bf', + dark: '#FFFFFF', + black: '#FFFFFF', + blue: '#5AB0FF', + blueHover: '#8DC8FF', floralwhite: '#fffaf0', - green: '#03d47c', - greenHover: '#03c775', - orange: '#ff7101', - pink: '#f68dfe', - red: '#fc3826', - redHover: '#e13826', - redDisabled: '#fea29a', - yellow: '#fed607', + green: '#03D47C', + greenHover: '#00C271', + orange: '#FF7101', + pink: '#F68DFE', + red: '#F25730', + redHover: '#DE4822', + redDisabled: '#F25730', + yellow: '#FED607', transparent: 'transparent', + + // Dark Mode Colors + AppBackground: '#061B09', + HighlightBackground: '#002E22', + Borders: '#1B5744', + Icons: '#8B9C8F', + SupportingText: '#C9D3C5', + Text: '#FFFFFF', + DefaultButton: '#184E3D', + DefaultButtonHover: '#2C6755', + SuccessButton: '#03D47C', + SuccessButtonHover: '#00C271', + DangerButton: '#F25730', + DangerButtonHover: '#DE4822', + Link: '#5AB0FF', + LinkHover: '#8DC8FF', }; From 54bd43f3ca2d15eebc7f561b9322bf390b36f65f Mon Sep 17 00:00:00 2001 From: Georgia Monahan Date: Mon, 7 Nov 2022 13:36:14 -0800 Subject: [PATCH 02/16] Define temp color names in colors.js / use in theme file. --- src/styles/colors.js | 35 +++++++------- src/styles/themes/default.js | 90 +++++++++++++++++++++--------------- 2 files changed, 70 insertions(+), 55 deletions(-) diff --git a/src/styles/colors.js b/src/styles/colors.js index ad692caeec1c9..58514d0a39b13 100644 --- a/src/styles/colors.js +++ b/src/styles/colors.js @@ -4,16 +4,16 @@ export default { gray1: '#002E22', gray2: '#1B5744', gray3: '#8B9C8F', - gray4: '#7D8B8F', + gray4: '#C9D3C5', dark: '#FFFFFF', black: '#FFFFFF', blue: '#5AB0FF', blueHover: '#8DC8FF', floralwhite: '#fffaf0', - green: '#03D47C', - greenHover: '#00C271', orange: '#FF7101', pink: '#F68DFE', + green: '#03D47C', + greenHover: '#00C271', red: '#F25730', redHover: '#DE4822', redDisabled: '#F25730', @@ -21,18 +21,19 @@ export default { transparent: 'transparent', // Dark Mode Colors - AppBackground: '#061B09', - HighlightBackground: '#002E22', - Borders: '#1B5744', - Icons: '#8B9C8F', - SupportingText: '#C9D3C5', - Text: '#FFFFFF', - DefaultButton: '#184E3D', - DefaultButtonHover: '#2C6755', - SuccessButton: '#03D47C', - SuccessButtonHover: '#00C271', - DangerButton: '#F25730', - DangerButtonHover: '#DE4822', - Link: '#5AB0FF', - LinkHover: '#8DC8FF', + greenAppBackground: '#061B09', + greenHighlightBackground: '#002E22', + greenBorders: '#1B5744', + greenIcons: '#8B9C8F', + greenSupportingText: '#C9D3C5', + whiteText: '#FFFFFF', + greenDefaultButton: '#184E3D', + greenDefaultButtonHover: '#2C6755', + greenDefaultButtonPress: '#184E3D', + greenSuccess: '#03D47C', + greenSuccessHover: '#00C271', + redDangerButton: '#F25730', + redDangerButtonHover: '#DE4822', + blueLink: '#5AB0FF', + blueLinkHover: '#8DC8FF', }; diff --git a/src/styles/themes/default.js b/src/styles/themes/default.js index 0b64e64484bf3..2b2ab2c0d2072 100644 --- a/src/styles/themes/default.js +++ b/src/styles/themes/default.js @@ -1,52 +1,66 @@ import colors from '../colors'; export default { - shadow: colors.black, - link: colors.blue, - linkHover: colors.blueHover, - componentBG: colors.white, - hoverComponentBG: colors.gray1, - activeComponentBG: colors.gray2, - appBG: colors.white, - heading: colors.dark, - sidebar: colors.gray1, - sidebarHover: colors.white, - border: colors.gray2, - borderFocus: colors.blue, - icon: colors.gray3, + // figma keys + appBG: colors.greenAppBackground, + highlightBG: colors.greenHighlightBackground, + borders: colors.greenBorders, + icons: colors.greenIcons, + supportingText: colors.greenSupportingText, + text: colors.whiteText, + defaultButton: colors.greenDefaultButton, + defaultButtonHover: colors.greenDefaultButtonHover, + successButton: colors.greenSuccess, + successButtonHover: colors.greenSuccessHover, + dangerButton: colors.red, + dangerButtonHover: colors.redHover, + link: colors.blueLink, + linkHover: colors.blueLinkHover, + + // custom keys + inverse: colors.whiteText, + shadow: colors.greenAppBackground, + componentBG: colors.greenAppBackground, + hoverComponentBG: colors.greenHighlightBackground, + activeComponentBG: colors.greenBorders, + sidebar: colors.greenHighlightBackground, + sidebarHover: colors.greenAppBackground, + border: colors.greenBorders, + borderFocus: colors.blueLink, + icon: colors.greenIcons, iconHovered: colors.dark, - iconSuccessFill: colors.green, - iconReversed: colors.white, - textSupporting: colors.gray4, - text: colors.dark, + iconSuccessFill: colors.greenSuccess, + iconReversed: colors.greenAppBackground, + heading: colors.dark, + textSupporting: colors.greenSupportingText, textError: colors.red, - textSuccess: colors.green, - textBackground: colors.gray1, - textReversed: colors.white, - textMutedReversed: colors.gray3, - buttonDefaultBG: colors.gray2, - buttonSuccessBG: colors.green, + textSuccess: colors.greenSuccess, + textBackground: colors.greenHighlightBackground, + textReversed: colors.greenAppBackground, + textMutedReversed: colors.greenIcons, + buttonDefaultBG: colors.greenDefaultButton, + buttonSuccessBG: colors.greenSuccess, buttonSuccessHoveredBG: colors.greenHover, buttonDangerBG: colors.red, buttonDangerPressedBG: colors.redHover, buttonDangerDisabledBG: colors.redDisabled, - online: colors.green, - offline: colors.gray3, + online: colors.greenSuccess, + offline: colors.greenIcons, sidebarButtonBG: 'rgba(198, 201, 202, 0.25)', - opaqueAvatar: 'rgba(011, 027, 052, 0.64)', - modalBackdrop: colors.gray3, - modalBackground: colors.gray2, + opaqueAvatar: 'rgba(198, 201, 202, 0.64)', + modalBackdrop: colors.greenIcons, + modalBackground: colors.greenBorders, badgeDangerBG: colors.red, badgeDangerPressedBG: colors.redHover, - badgeDefaultBG: colors.gray2, - badgeSuccessBG: colors.green, + badgeDefaultBG: colors.greenBorders, + badgeSuccessBG: colors.greenSuccess, badgeSuccessPressedBG: colors.greenHover, - buttonDisabledBG: colors.gray2, - buttonHoveredBG: colors.gray1, - buttonPressedBG: colors.gray2, - spinner: colors.gray4, - unreadIndicator: colors.green, - placeholderText: colors.gray3, - heroCard: colors.blue, - uploadPreviewActivityIndicator: colors.gray1, + buttonDisabledBG: colors.greenBorders, + buttonHoveredBG: colors.greenDefaultButtonHover, + buttonPressedBG: colors.greenDefaultButtonPress, + spinner: colors.greenSupportingText, + unreadIndicator: colors.greenSuccess, + placeholderText: colors.greenIcons, + heroCard: colors.blueLink, + uploadPreviewActivityIndicator: colors.greenHighlightBackground, }; From 4726435d71079dfc2d0a23a4d171babee328f855 Mon Sep 17 00:00:00 2001 From: Georgia Monahan Date: Mon, 7 Nov 2022 14:57:41 -0800 Subject: [PATCH 03/16] Remove colors import from styles.js, replace with themeColors --- src/styles/styles.js | 59 ++++++++++++++++++++++---------------------- 1 file changed, 29 insertions(+), 30 deletions(-) diff --git a/src/styles/styles.js b/src/styles/styles.js index f2d7cff023da9..4d7fe06c3bbe2 100644 --- a/src/styles/styles.js +++ b/src/styles/styles.js @@ -3,7 +3,6 @@ import addOutlineWidth from './addOutlineWidth'; import themeColors from './themes/default'; import fontWeightBold from './fontWeight/bold'; import variables from './variables'; -import colors from './colors'; import spacing from './utilities/spacing'; import sizing from './utilities/sizing'; import flex from './utilities/flex'; @@ -22,7 +21,7 @@ import pointerEventsAuto from './pointerEventsAuto'; import overflowXHidden from './overflowXHidden'; const picker = { - backgroundColor: 'transparent', + backgroundColor: themeColors.transparent, color: themeColors.text, fontFamily: fontFamily.GTA, fontSize: variables.fontSizeNormal, @@ -285,11 +284,11 @@ const styles = { }, textWhite: { - color: colors.white, + color: themeColors.appBG, }, textBlue: { - color: colors.blue, + color: themeColors.link, }, textUppercase: { @@ -321,7 +320,7 @@ const styles = { }, bgDark: { - backgroundColor: colors.dark, + backgroundColor: themeColors.inverse, }, opacity0: { @@ -333,7 +332,7 @@ const styles = { }, textDanger: { - color: colors.red, + color: themeColors.dangerButton, }, borderRadiusNormal: { @@ -349,7 +348,7 @@ const styles = { }, buttonText: { - color: themeColors.heading, + color: themeColors.textWhite, fontFamily: fontFamily.GTA_BOLD, fontSize: variables.fontSizeNormal, fontWeight: fontWeightBold, @@ -478,11 +477,11 @@ const styles = { }, buttonSuccessText: { - color: themeColors.textReversed, + color: themeColors.text, }, buttonDangerText: { - color: themeColors.textReversed, + color: themeColors.text, }, hoveredComponentBG: { @@ -830,12 +829,12 @@ const styles = { }), disabledText: { - color: colors.gray3, + color: themeColors.icons, }, inputDisabled: { - backgroundColor: colors.gray1, - color: colors.gray3, + backgroundColor: themeColors.highlightBG, + color: themeColors.icons, }, textInputReversed: addOutlineWidth({ @@ -851,7 +850,7 @@ const styles = { noOutline: addOutlineWidth({}, 0), errorOutline: { - borderColor: colors.red, + borderColor: themeColors.dangerButton, }, textLabelSupporting: { @@ -920,14 +919,14 @@ const styles = { fontFamily: fontFamily.GTA, fontWeight: fontWeightBold, fontSize: variables.fontSizeHero, - color: colors.white, + color: themeColors.appBG, lineHeight: variables.lineHeightHero, }, signInPageHeroDescription: { fontFamily: fontFamily.GTA, fontSize: variables.fontSizeNormal, - color: colors.white, + color: themeColors.appBG, }, signInPageFormContainer: { @@ -1340,7 +1339,7 @@ const styles = { }, chatItemMessageLink: { - color: colors.blue, + color: themeColors.link, fontSize: variables.fontSizeNormal, fontFamily: fontFamily.GTA, lineHeight: 20, @@ -1578,7 +1577,7 @@ const styles = { horizontalStackedAvatar: { height: 28, width: 28, - backgroundColor: colors.white, + backgroundColor: themeColors.appBG, borderRadius: 33, paddingTop: 2, }, @@ -1744,7 +1743,7 @@ const styles = { width: 28, borderWidth: 2, borderStyle: 'solid', - borderColor: colors.white, + borderColor: themeColors.appBG, backgroundColor: themeColors.opaqueAvatar, borderRadius: 24, zIndex: 6, @@ -1886,7 +1885,7 @@ const styles = { }, notFoundTextHeader: { - color: colors.blue, + color: themeColors.link, fontFamily: fontFamily.GTA_BOLD, fontWeight: fontWeightBold, fontSize: 150, @@ -1900,7 +1899,7 @@ const styles = { }, notFoundButtonText: { - color: colors.blue, + color: themeColors.link, fontFamily: fontFamily.GTA_BOLD, fontWeight: fontWeightBold, fontSize: 15, @@ -1912,7 +1911,7 @@ const styles = { defaultModalContainer: { backgroundColor: themeColors.componentBG, - borderColor: colors.transparent, + borderColor: themeColors.transparent, }, reportActionContextMenuMiniButton: { @@ -1989,7 +1988,7 @@ const styles = { right: 0, bottom: 0, left: 0, - backgroundColor: colors.dark, + backgroundColor: themeColors.inverse, opacity: 0.5, }, @@ -2104,11 +2103,11 @@ const styles = { justifyContent: 'center', borderRadius: 20, padding: 15, - backgroundColor: colors.green, + backgroundColor: themeColors.successButton, }, switchInactive: { - backgroundColor: colors.gray2, + backgroundColor: themeColors.borders, }, switchThumb: { @@ -2117,7 +2116,7 @@ const styles = { borderRadius: 11, position: 'absolute', left: 4, - backgroundColor: colors.white, + backgroundColor: themeColors.appBG, }, radioButtonContainer: { @@ -2143,7 +2142,7 @@ const styles = { }, checkedContainer: { - backgroundColor: colors.blue, + backgroundColor: themeColors.link, }, iouAmountText: { @@ -2241,7 +2240,7 @@ const styles = { }, navigatorFullScreenLoading: { - backgroundColor: colors.gray1, + backgroundColor: themeColors.highlightBG, opacity: 1, }, @@ -2294,7 +2293,7 @@ const styles = { }), growlNotificationBox: { - backgroundColor: colors.dark, + backgroundColor: themeColors.inverse, borderRadius: variables.componentBorderRadiusNormal, alignItems: 'center', flexDirection: 'row', @@ -2666,7 +2665,7 @@ const styles = { }, iPhoneXSafeArea: { - backgroundColor: colors.black, + backgroundColor: themeColors.inverse, flex: 1, }, @@ -2753,7 +2752,7 @@ const styles = { textPill: { ellipsizeMode: 'end', - backgroundColor: colors.gray2, + backgroundColor: themeColors.borders, borderRadius: 10, overflow: 'hidden', paddingVertical: 2, From a98a18a4edcfe22b9865d8d60d2e000adf738252 Mon Sep 17 00:00:00 2001 From: Georgia Monahan Date: Mon, 7 Nov 2022 17:32:32 -0800 Subject: [PATCH 04/16] WIP clean up color imports for gray1-gray4 and appBG. --- .../AvatarCropModal/AvatarCropModal.js | 5 +-- src/components/Button.js | 5 +-- src/components/ButtonWithDropdown.js | 2 +- src/components/OptionRow.js | 6 +-- src/libs/Navigation/NavigationRoot.js | 4 +- src/pages/settings/Profile/LoginField.js | 4 +- src/styles/colors.js | 1 - .../getModalStyles/getBaseModalStyles.js | 7 ++-- src/styles/styles.js | 18 ++++----- src/styles/themes/default.js | 38 ++++++++----------- 10 files changed, 40 insertions(+), 50 deletions(-) diff --git a/src/components/AvatarCropModal/AvatarCropModal.js b/src/components/AvatarCropModal/AvatarCropModal.js index e32057d87301d..fe893d63e451d 100644 --- a/src/components/AvatarCropModal/AvatarCropModal.js +++ b/src/components/AvatarCropModal/AvatarCropModal.js @@ -14,7 +14,6 @@ import { } from 'react-native-reanimated'; import CONST from '../../CONST'; import compose from '../../libs/compose'; -import colors from '../../styles/colors'; import styles from '../../styles/styles'; import themeColors from '../../styles/themes/default'; import Button from '../Button'; @@ -317,7 +316,7 @@ const AvatarCropModal = (props) => { rotation={rotation} /> - + {