From 8b15c4671c95ce158c1ccd19748f25f198da0d4b Mon Sep 17 00:00:00 2001 From: Getabalew Tesfaye Date: Wed, 8 Nov 2023 09:47:18 +0300 Subject: [PATCH 1/3] fix autofill on signinpage --- src/pages/signin/LoginForm/BaseLoginForm.js | 1 - 1 file changed, 1 deletion(-) diff --git a/src/pages/signin/LoginForm/BaseLoginForm.js b/src/pages/signin/LoginForm/BaseLoginForm.js index b239ce6d3a864..5b55965d1539f 100644 --- a/src/pages/signin/LoginForm/BaseLoginForm.js +++ b/src/pages/signin/LoginForm/BaseLoginForm.js @@ -221,7 +221,6 @@ function LoginForm(props) { ref={input} label={translate('loginForm.phoneOrEmail')} accessibilityLabel={translate('loginForm.phoneOrEmail')} - role={CONST.ACCESSIBILITY_ROLE.TEXT} value={login} returnKeyType="go" autoCompleteType="username" From de36894fc21154aada4d28fc059ea3be7182adaa Mon Sep 17 00:00:00 2001 From: Getabalew Tesfaye Date: Wed, 8 Nov 2023 09:54:32 +0300 Subject: [PATCH 2/3] fix wrong placeholder alignment --- src/components/Composer/index.android.js | 3 ++- .../ComposerWithSuggestions/ComposerWithSuggestions.js | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/components/Composer/index.android.js b/src/components/Composer/index.android.js index 08d3e45e671ff..647d19a40f528 100644 --- a/src/components/Composer/index.android.js +++ b/src/components/Composer/index.android.js @@ -120,7 +120,8 @@ function Composer({shouldClear, onClear, isDisabled, maxLines, forwardedRef, isC // @Szymon20000 is working on fixing this (android-only) issue in the in the upstream PR (https://github.com/facebook/react-native/pulls?q=is%3Apr+is%3Aopen+maxNumberOfLines) // TODO: remove this comment once upstream PR is merged and available in a future release maxNumberOfLines={maxNumberOfLines} - style={[composerStyles, styles.verticalAlignMiddle]} + textAlignVertical="center" + style={[composerStyles]} /* eslint-disable-next-line react/jsx-props-no-spreading */ {...props} readOnly={isDisabled} diff --git a/src/pages/home/report/ReportActionCompose/ComposerWithSuggestions/ComposerWithSuggestions.js b/src/pages/home/report/ReportActionCompose/ComposerWithSuggestions/ComposerWithSuggestions.js index b69e65e854d7f..3f943502f7483 100644 --- a/src/pages/home/report/ReportActionCompose/ComposerWithSuggestions/ComposerWithSuggestions.js +++ b/src/pages/home/report/ReportActionCompose/ComposerWithSuggestions/ComposerWithSuggestions.js @@ -536,7 +536,8 @@ function ComposerWithSuggestions({ placeholderTextColor={themeColors.placeholderText} onChangeText={(commentValue) => updateComment(commentValue, true)} onKeyPress={triggerHotkeyActions} - style={[styles.textInputCompose, isComposerFullSize ? styles.textInputFullCompose : styles.flex4, styles.verticalAlignTop]} + textAlignVertical="top" + style={[styles.textInputCompose, isComposerFullSize ? styles.textInputFullCompose : styles.flex4]} maxLines={maxComposerLines} onFocus={onFocus} onBlur={onBlur} From 703230ea39577d9bc8db59bc992860b5334f4691 Mon Sep 17 00:00:00 2001 From: Getabalew Tesfaye Date: Wed, 8 Nov 2023 10:25:49 +0300 Subject: [PATCH 3/3] fix lint --- src/components/Composer/index.android.js | 1 - 1 file changed, 1 deletion(-) diff --git a/src/components/Composer/index.android.js b/src/components/Composer/index.android.js index 647d19a40f528..278965cbc81a9 100644 --- a/src/components/Composer/index.android.js +++ b/src/components/Composer/index.android.js @@ -4,7 +4,6 @@ import {StyleSheet} from 'react-native'; import _ from 'underscore'; import RNTextInput from '@components/RNTextInput'; import * as ComposerUtils from '@libs/ComposerUtils'; -import styles from '@styles/styles'; import themeColors from '@styles/themes/default'; const propTypes = {