From 588789fd7c718fda074b3bb9b0b0c66a8a813b92 Mon Sep 17 00:00:00 2001 From: Daniel Gale-Rosen Date: Thu, 26 Sep 2024 17:20:24 -0400 Subject: [PATCH] fix type error --- src/languages/en.ts | 3 ++- src/languages/es.ts | 3 ++- src/languages/params.ts | 5 +++++ src/pages/home/report/ReportActionItemSingle.tsx | 2 +- 4 files changed, 10 insertions(+), 3 deletions(-) diff --git a/src/languages/en.ts b/src/languages/en.ts index dabb592b2bf50..e75fd92556ab9 100755 --- a/src/languages/en.ts +++ b/src/languages/en.ts @@ -97,6 +97,7 @@ import type { NoLongerHaveAccessParams, NotAllowedExtensionParams, NotYouParams, + OnBehalfOfParams, OOOEventSummaryFullDayParams, OOOEventSummaryPartialDayParams, OptionalParam, @@ -4818,7 +4819,7 @@ const translations = { } }, genericError: 'Oops, something went wrong. Please try again.', - onBehalfOfMessage: (delegator: string) => `on behalf of ${delegator}`, + onBehalfOfMessage: ({delegator}: OnBehalfOfParams) => `on behalf of ${delegator}`, accessLevel: 'Access level', confirmCopilot: 'Confirm your copilot below.', accessLevelDescription: 'Choose an access level below. Both Full and Limited access allow copilots to view all conversations and expenses.', diff --git a/src/languages/es.ts b/src/languages/es.ts index 3dc528fe8257a..dbd023e0238c3 100644 --- a/src/languages/es.ts +++ b/src/languages/es.ts @@ -96,6 +96,7 @@ import type { NoLongerHaveAccessParams, NotAllowedExtensionParams, NotYouParams, + OnBehalfOfParams, OOOEventSummaryFullDayParams, OOOEventSummaryPartialDayParams, OptionalParam, @@ -5338,7 +5339,7 @@ const translations = { } }, genericError: '¡Ups! Ha ocurrido un error. Por favor, inténtalo de nuevo.', - onBehalfOfMessage: (delegator: string) => `en nombre de ${delegator}`, + onBehalfOfMessage: ({delegator}: OnBehalfOfParams) => `en nombre de ${delegator}`, accessLevel: 'Nivel de acceso', confirmCopilot: 'Confirma tu copiloto a continuación.', accessLevelDescription: 'Elige un nivel de acceso a continuación. Tanto el acceso Completo como el Limitado permiten a los copilotos ver todas las conversaciones y gastos.', diff --git a/src/languages/params.ts b/src/languages/params.ts index 20e7ac34185c3..a1c23e5d3e117 100644 --- a/src/languages/params.ts +++ b/src/languages/params.ts @@ -546,6 +546,10 @@ type AuthenticationErrorParams = { connectionName: string; }; +type OnBehalfOfParams = { + delegator: string; +}; + export type { AuthenticationErrorParams, ImportMembersSuccessfullDescriptionParams, @@ -748,4 +752,5 @@ export type { CharacterLengthLimitParams, OptionalParam, AssignCardParams, + OnBehalfOfParams, }; diff --git a/src/pages/home/report/ReportActionItemSingle.tsx b/src/pages/home/report/ReportActionItemSingle.tsx index 01a0847b4f773..56eaf814ff103 100644 --- a/src/pages/home/report/ReportActionItemSingle.tsx +++ b/src/pages/home/report/ReportActionItemSingle.tsx @@ -375,7 +375,7 @@ function ReportActionItemSingle({ ) : null} {action?.delegateAccountID && !isReportPreviewAction && ( - {translate('delegate.onBehalfOfMessage', accountOwnerDetails?.displayName ?? '')} + {translate('delegate.onBehalfOfMessage', {delegator: accountOwnerDetails?.displayName ?? ''})} )} {children}