diff --git a/src/components/MenuItem.tsx b/src/components/MenuItem.tsx index 259ae3170825d..7fb5533fd172b 100644 --- a/src/components/MenuItem.tsx +++ b/src/components/MenuItem.tsx @@ -224,9 +224,6 @@ type MenuItemBaseProps = { /** Whether the secondary right avatar should show as a subscript */ shouldShowSubscriptRightAvatar?: boolean; - /** Whether the secondary avatar should show as a subscript */ - shouldShowSubscriptAvatar?: boolean; - /** Affects avatar size */ viewMode?: ValueOf; @@ -348,15 +345,6 @@ type MenuItemBaseProps = { }; type MenuItemProps = (IconProps | AvatarProps | NoIcon) & MenuItemBaseProps; - -const getSubscriptpAvatarBackgroundColor = (isHovered: boolean, isPressed: boolean, hoveredBackgroundColor: string, pressedBackgroundColor: string) => { - if (isPressed) { - return pressedBackgroundColor; - } - if (isHovered) { - return hoveredBackgroundColor; - } -}; function MenuItem( { interactive = true, @@ -419,7 +407,6 @@ function MenuItem( floatRightAvatars = [], floatRightAvatarSize, shouldShowSubscriptRightAvatar = false, - shouldShowSubscriptAvatar: shouldShowSubscriptAvatarProp = false, avatarSize = CONST.AVATAR_SIZE.DEFAULT, isSmallAvatarSubscriptMenu = false, brickRoadIndicator, @@ -470,7 +457,7 @@ function MenuItem( const isDeleted = style && Array.isArray(style) ? style.includes(styles.offlineFeedback.deleted) : false; const descriptionVerticalMargin = shouldShowDescriptionOnTop ? styles.mb1 : styles.mt1; const fallbackAvatarSize = viewMode === CONST.OPTION_MODE.COMPACT ? CONST.AVATAR_SIZE.SMALL : CONST.AVATAR_SIZE.DEFAULT; - const firstRightIcon = floatRightAvatars.at(0); + const firstIcon = floatRightAvatars.at(0); const combinedTitleTextStyle = StyleUtils.combineStyles( [ styles.flexShrink1, @@ -485,9 +472,6 @@ function MenuItem( ], titleStyle ?? {}, ); - const shouldShowAvatar = !!icon && Array.isArray(icon); - const firstIcon = Array.isArray(icon) && !!icon.length ? icon.at(0) : undefined; - const shouldShowSubscriptAvatar = shouldShowSubscriptAvatarProp && !!firstIcon; const descriptionTextStyles = StyleUtils.combineStyles([ styles.textLabelSupporting, icon && !Array.isArray(icon) ? styles.ml3 : {}, @@ -637,7 +621,7 @@ function MenuItem( )} - {shouldShowAvatar && !shouldShowSubscriptAvatar && ( + {!!icon && Array.isArray(icon) && ( )} - {shouldShowAvatar && shouldShowSubscriptAvatar && ( - - )} {!icon && shouldPutLeftPaddingWhenNoIcon && ( {subtitle} )} - {floatRightAvatars?.length > 0 && !!firstRightIcon && ( + {floatRightAvatars?.length > 0 && !!firstIcon && ( {shouldShowSubscriptRightAvatar ? ( diff --git a/src/languages/en.ts b/src/languages/en.ts index 5a06ca3a826cb..e627199ad455c 100755 --- a/src/languages/en.ts +++ b/src/languages/en.ts @@ -2539,7 +2539,6 @@ const translations = { return 'Member'; } }, - submitExpense: 'Submit expenses using your workspace chat below:', defaultCategory: 'Default category', }, perDiem: { diff --git a/src/languages/es.ts b/src/languages/es.ts index f9a3a1e114349..c5fc5cad72fdb 100644 --- a/src/languages/es.ts +++ b/src/languages/es.ts @@ -2563,7 +2563,6 @@ const translations = { return 'Miembro'; } }, - submitExpense: 'Envíe los gastos utilizando el chat de su espacio de trabajo:', defaultCategory: 'Categoría predeterminada', }, perDiem: { diff --git a/src/pages/workspace/WorkspaceInitialPage.tsx b/src/pages/workspace/WorkspaceInitialPage.tsx index 615d7d0bf7356..8c085d21e2db8 100644 --- a/src/pages/workspace/WorkspaceInitialPage.tsx +++ b/src/pages/workspace/WorkspaceInitialPage.tsx @@ -8,11 +8,9 @@ import ConfirmModal from '@components/ConfirmModal'; import HeaderWithBackButton from '@components/HeaderWithBackButton'; import HighlightableMenuItem from '@components/HighlightableMenuItem'; import * as Expensicons from '@components/Icon/Expensicons'; -import MenuItem from '@components/MenuItem'; import OfflineWithFeedback from '@components/OfflineWithFeedback'; import ScreenWrapper from '@components/ScreenWrapper'; import ScrollView from '@components/ScrollView'; -import Text from '@components/Text'; import useCurrentUserPersonalDetails from '@hooks/useCurrentUserPersonalDetails'; import useLocalize from '@hooks/useLocalize'; import useNetwork from '@hooks/useNetwork'; @@ -27,7 +25,7 @@ import getTopmostRouteName from '@libs/Navigation/getTopmostRouteName'; import Navigation from '@libs/Navigation/Navigation'; import type {PlatformStackScreenProps} from '@libs/Navigation/PlatformStackNavigation/types'; import * as PolicyUtils from '@libs/PolicyUtils'; -import {getDefaultWorkspaceAvatar, getIcons, getPolicyExpenseChat, getReportName, getReportOfflinePendingActionAndErrors} from '@libs/ReportUtils'; +import {getDefaultWorkspaceAvatar} from '@libs/ReportUtils'; import type {FullScreenNavigatorParamList} from '@navigation/types'; import * as App from '@userActions/App'; import * as Policy from '@userActions/Policy/Policy'; @@ -95,8 +93,6 @@ function WorkspaceInitialPage({policyDraft, policy: policyProp, route}: Workspac const [connectionSyncProgress] = useOnyx(`${ONYXKEYS.COLLECTION.POLICY_CONNECTION_SYNC_PROGRESS}${policy?.id}`); const [currentUserLogin] = useOnyx(ONYXKEYS.SESSION, {selector: (session) => session?.email}); const [policyCategories] = useOnyx(`${ONYXKEYS.COLLECTION.POLICY_CATEGORIES}${route.params?.policyID ?? '-1'}`); - const [personalDetails] = useOnyx(ONYXKEYS.PERSONAL_DETAILS_LIST); - const {login, accountID} = useCurrentUserPersonalDetails(); const hasSyncError = PolicyUtils.shouldShowSyncError(policy, isConnectionInProgress(connectionSyncProgress, policy)); const waitForNavigate = useWaitForNavigation(); const {singleExecution, isExecuting} = useSingleExecution(); @@ -104,9 +100,6 @@ function WorkspaceInitialPage({policyDraft, policy: policyProp, route}: Workspac const {translate} = useLocalize(); const {isOffline} = useNetwork(); const wasRendered = useRef(false); - const currentUserPolicyExpenseChatReportID = getPolicyExpenseChat(accountID, policy?.id ?? '-1')?.reportID ?? '-1'; - const [currentUserPolicyExpenseChat] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT}${currentUserPolicyExpenseChatReportID}`); - const {reportPendingAction} = getReportOfflinePendingActionAndErrors(currentUserPolicyExpenseChat); const prevPendingFields = usePrevious(policy?.pendingFields); const policyFeatureStates = useMemo( @@ -166,6 +159,7 @@ function WorkspaceInitialPage({policyDraft, policy: policyProp, route}: Workspac !isEmptyObject(policy?.errorFields?.avatarURL ?? {}) || !isEmptyObject(policy?.errorFields?.ouputCurrency ?? {}) || !isEmptyObject(policy?.errorFields?.address ?? {}); + const {login} = useCurrentUserPersonalDetails(); const shouldShowProtectedItems = PolicyUtils.isPolicyAdmin(policy, login); const isPaidGroupPolicy = PolicyUtils.isPaidGroupPolicy(policy); const [featureStates, setFeatureStates] = useState(policyFeatureStates); @@ -414,7 +408,7 @@ function WorkspaceInitialPage({policyDraft, policy: policyProp, route}: Workspac style={styles.headerBarDesktopHeight} /> - + dismissError(policyID, policy?.pendingAction)} @@ -446,20 +440,6 @@ function WorkspaceInitialPage({policyDraft, policy: policyProp, route}: Workspac ))} - - {translate('workspace.common.submitExpense')} - - Navigation.navigate(ROUTES.REPORT_WITH_ID.getRoute(currentUserPolicyExpenseChat?.reportID ?? '-1'))} - shouldShowRightIcon - wrapperStyle={[styles.br2, styles.pl2, styles.pr0, styles.pv3, styles.mt1, styles.alignItemsCenter]} - shouldShowSubscriptAvatar - /> - -