From 91cf7bb74c76a1eb7cfcf848a792430fd88356a0 Mon Sep 17 00:00:00 2001 From: kirillzyusko Date: Wed, 18 Dec 2024 11:35:35 +0100 Subject: [PATCH 1/8] fix: apply safe area padding for workspace screens --- src/pages/workspace/WorkspaceInitialPage.tsx | 5 +---- src/pages/workspace/WorkspaceMoreFeaturesPage.tsx | 1 - src/pages/workspace/rules/PolicyRulesPage.tsx | 1 + src/pages/workspace/workflows/WorkspaceWorkflowsPage.tsx | 1 + 4 files changed, 3 insertions(+), 5 deletions(-) diff --git a/src/pages/workspace/WorkspaceInitialPage.tsx b/src/pages/workspace/WorkspaceInitialPage.tsx index 95449e4c10ea3..bb2be6053c3d8 100644 --- a/src/pages/workspace/WorkspaceInitialPage.tsx +++ b/src/pages/workspace/WorkspaceInitialPage.tsx @@ -390,10 +390,7 @@ function WorkspaceInitialPage({policyDraft, policy: policyProp, route}: Workspac }, [policy]); return ( - + diff --git a/src/pages/workspace/workflows/WorkspaceWorkflowsPage.tsx b/src/pages/workspace/workflows/WorkspaceWorkflowsPage.tsx index f4d05a09fba6f..5503ab7a24428 100644 --- a/src/pages/workspace/workflows/WorkspaceWorkflowsPage.tsx +++ b/src/pages/workspace/workflows/WorkspaceWorkflowsPage.tsx @@ -341,6 +341,7 @@ function WorkspaceWorkflowsPage({policy, route}: WorkspaceWorkflowsPageProps) { isLoading={isLoading} shouldShowLoading={isLoading} shouldUseScrollView + includeSafeAreaPaddingBottom > {optionItems.map(renderOptionItem)} From a8b835ec514890b939dab938bc286945e173983d Mon Sep 17 00:00:00 2001 From: kirillzyusko Date: Thu, 19 Dec 2024 13:25:13 +0100 Subject: [PATCH 2/8] fix: partially resolve new eslint findings --- src/libs/PolicyUtils.ts | 6 +++++- src/libs/ReportUtils.ts | 6 +++++- src/pages/workspace/WorkspaceInitialPage.tsx | 8 ++++---- src/pages/workspace/WorkspaceMoreFeaturesPage.tsx | 6 +++--- 4 files changed, 17 insertions(+), 9 deletions(-) diff --git a/src/libs/PolicyUtils.ts b/src/libs/PolicyUtils.ts index 9bf68b2c5432e..3f06532df87d4 100644 --- a/src/libs/PolicyUtils.ts +++ b/src/libs/PolicyUtils.ts @@ -1072,7 +1072,11 @@ function getCurrentTaxID(policy: OnyxEntry, taxID: string): string | und return Object.keys(policy?.taxRates?.taxes ?? {}).find((taxIDKey) => policy?.taxRates?.taxes?.[taxIDKey].previousTaxCode === taxID || taxIDKey === taxID); } -function getWorkspaceAccountID(policyID: string) { +function getWorkspaceAccountID(policyID?: string) { + if (!policyID) { + return 0; + } + const policy = getPolicy(policyID); if (!policy) { diff --git a/src/libs/ReportUtils.ts b/src/libs/ReportUtils.ts index d2ec8fb3ac624..b5061b1a00cbf 100644 --- a/src/libs/ReportUtils.ts +++ b/src/libs/ReportUtils.ts @@ -6757,7 +6757,11 @@ function getInvoiceChatByParticipants(policyID: string, receiverID: string | num /** * Attempts to find a policy expense report in onyx that is owned by ownerAccountID in a given policy */ -function getPolicyExpenseChat(ownerAccountID: number, policyID: string): OnyxEntry { +function getPolicyExpenseChat(ownerAccountID: number, policyID?: string): OnyxEntry { + if (!policyID) { + return undefined; + } + return Object.values(allReports ?? {}).find((report: OnyxEntry) => { // If the report has been deleted, then skip it if (!report) { diff --git a/src/pages/workspace/WorkspaceInitialPage.tsx b/src/pages/workspace/WorkspaceInitialPage.tsx index bb2be6053c3d8..a20583838170d 100644 --- a/src/pages/workspace/WorkspaceInitialPage.tsx +++ b/src/pages/workspace/WorkspaceInitialPage.tsx @@ -86,7 +86,7 @@ function dismissError(policyID: string, pendingAction: PendingAction | undefined function WorkspaceInitialPage({policyDraft, policy: policyProp, route}: WorkspaceInitialPageProps) { const styles = useThemeStyles(); const policy = policyDraft?.id ? policyDraft : policyProp; - const workspaceAccountID = PolicyUtils.getWorkspaceAccountID(policy?.id ?? '-1'); + const workspaceAccountID = PolicyUtils.getWorkspaceAccountID(policy?.id); const [isCurrencyModalOpen, setIsCurrencyModalOpen] = useState(false); const hasPolicyCreationError = !!(policy?.pendingAction === CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD && !isEmptyObject(policy.errors)); const [cardFeeds] = useOnyx(`${ONYXKEYS.COLLECTION.SHARED_NVP_PRIVATE_DOMAIN_MEMBER}${workspaceAccountID}`); @@ -94,7 +94,7 @@ function WorkspaceInitialPage({policyDraft, policy: policyProp, route}: Workspac const [cardsList] = useOnyx(`${ONYXKEYS.COLLECTION.WORKSPACE_CARDS_LIST}${workspaceAccountID}_${CONST.EXPENSIFY_CARD.BANK}`); const [connectionSyncProgress] = useOnyx(`${ONYXKEYS.COLLECTION.POLICY_CONNECTION_SYNC_PROGRESS}${policy?.id}`); const [currentUserLogin] = useOnyx(ONYXKEYS.SESSION, {selector: (session) => session?.email}); - const [policyCategories] = useOnyx(`${ONYXKEYS.COLLECTION.POLICY_CATEGORIES}${route.params?.policyID ?? '-1'}`); + const [policyCategories] = useOnyx(`${ONYXKEYS.COLLECTION.POLICY_CATEGORIES}${route.params?.policyID}`); const [personalDetails] = useOnyx(ONYXKEYS.PERSONAL_DETAILS_LIST); const {login, accountID} = useCurrentUserPersonalDetails(); const hasSyncError = PolicyUtils.shouldShowSyncError(policy, isConnectionInProgress(connectionSyncProgress, policy)); @@ -104,7 +104,7 @@ function WorkspaceInitialPage({policyDraft, policy: policyProp, route}: Workspac const {translate} = useLocalize(); const {isOffline} = useNetwork(); const wasRendered = useRef(false); - const currentUserPolicyExpenseChatReportID = getPolicyExpenseChat(accountID, policy?.id ?? '-1')?.reportID ?? '-1'; + const currentUserPolicyExpenseChatReportID = getPolicyExpenseChat(accountID, policy?.id)?.reportID; const [currentUserPolicyExpenseChat] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT}${currentUserPolicyExpenseChatReportID}`); const {reportPendingAction} = getReportOfflinePendingActionAndErrors(currentUserPolicyExpenseChat); const isPolicyExpenseChatEnabled = !!policy?.isPolicyExpenseChatEnabled; @@ -385,7 +385,7 @@ function WorkspaceInitialPage({policyDraft, policy: policyProp, route}: Workspac source: avatar, name: policy?.name ?? '', type: CONST.ICON_TYPE_WORKSPACE, - id: policy.id ?? '-1', + id: policy.id, }; }, [policy]); diff --git a/src/pages/workspace/WorkspaceMoreFeaturesPage.tsx b/src/pages/workspace/WorkspaceMoreFeaturesPage.tsx index 53ab43832d0dc..3dc7ffa8a065f 100644 --- a/src/pages/workspace/WorkspaceMoreFeaturesPage.tsx +++ b/src/pages/workspace/WorkspaceMoreFeaturesPage.tsx @@ -74,9 +74,9 @@ function WorkspaceMoreFeaturesPage({policy, route}: WorkspaceMoreFeaturesPagePro !!policy?.connections?.xero?.config?.importTaxRates || !!policy?.connections?.netsuite?.options?.config?.syncOptions?.syncTax; const policyID = policy?.id; - const workspaceAccountID = policy?.workspaceAccountID ?? -1; - const [cardsList] = useOnyx(`${ONYXKEYS.COLLECTION.WORKSPACE_CARDS_LIST}${workspaceAccountID.toString()}_${CONST.EXPENSIFY_CARD.BANK}`); - const [cardFeeds] = useOnyx(`${ONYXKEYS.COLLECTION.SHARED_NVP_PRIVATE_DOMAIN_MEMBER}${workspaceAccountID.toString()}`); + const workspaceAccountID = policy?.workspaceAccountID; + const [cardsList] = useOnyx(`${ONYXKEYS.COLLECTION.WORKSPACE_CARDS_LIST}${workspaceAccountID}_${CONST.EXPENSIFY_CARD.BANK}`); + const [cardFeeds] = useOnyx(`${ONYXKEYS.COLLECTION.SHARED_NVP_PRIVATE_DOMAIN_MEMBER}${workspaceAccountID}`); const [isOrganizeWarningModalOpen, setIsOrganizeWarningModalOpen] = useState(false); const [isIntegrateWarningModalOpen, setIsIntegrateWarningModalOpen] = useState(false); const [isReportFieldsWarningModalOpen, setIsReportFieldsWarningModalOpen] = useState(false); From d766f3d3f234e0daa4cd705eb05a52fc150b0aea Mon Sep 17 00:00:00 2001 From: kirillzyusko Date: Thu, 19 Dec 2024 15:14:40 +0100 Subject: [PATCH 3/8] fix: two more lint violations --- src/libs/actions/Policy/Policy.ts | 5 ++++- src/pages/workspace/WorkspaceInitialPage.tsx | 7 ++++++- src/pages/workspace/workflows/WorkspaceWorkflowsPage.tsx | 2 +- 3 files changed, 11 insertions(+), 3 deletions(-) diff --git a/src/libs/actions/Policy/Policy.ts b/src/libs/actions/Policy/Policy.ts index f81539d1e9215..0b66c6ba8e8a2 100644 --- a/src/libs/actions/Policy/Policy.ts +++ b/src/libs/actions/Policy/Policy.ts @@ -623,7 +623,10 @@ function setWorkspacePayer(policyID: string, reimburserEmail: string) { API.write(WRITE_COMMANDS.SET_WORKSPACE_PAYER, params, {optimisticData, failureData, successData}); } -function clearPolicyErrorField(policyID: string, fieldName: string) { +function clearPolicyErrorField(policyID?: string, fieldName?: string) { + if (!policyID || !fieldName) { + return; + } Onyx.merge(`${ONYXKEYS.COLLECTION.POLICY}${policyID}`, {errorFields: {[fieldName]: null}}); } diff --git a/src/pages/workspace/WorkspaceInitialPage.tsx b/src/pages/workspace/WorkspaceInitialPage.tsx index a20583838170d..8fce856c2b9bc 100644 --- a/src/pages/workspace/WorkspaceInitialPage.tsx +++ b/src/pages/workspace/WorkspaceInitialPage.tsx @@ -451,7 +451,12 @@ function WorkspaceInitialPage({policyDraft, policy: policyProp, route}: Workspac title={getReportName(currentUserPolicyExpenseChat)} description={translate('workspace.common.workspace')} icon={getIcons(currentUserPolicyExpenseChat, personalDetails)} - onPress={() => Navigation.navigate(ROUTES.REPORT_WITH_ID.getRoute(currentUserPolicyExpenseChat?.reportID ?? '-1'), CONST.NAVIGATION.TYPE.UP)} + onPress={() => { + if (!currentUserPolicyExpenseChat?.reportID) { + return; + } + Navigation.navigate(ROUTES.REPORT_WITH_ID.getRoute(currentUserPolicyExpenseChat?.reportID), CONST.NAVIGATION.TYPE.UP) + }} shouldShowRightIcon wrapperStyle={[styles.br2, styles.pl2, styles.pr0, styles.pv3, styles.mt1, styles.alignItemsCenter]} shouldShowSubscriptAvatar diff --git a/src/pages/workspace/workflows/WorkspaceWorkflowsPage.tsx b/src/pages/workspace/workflows/WorkspaceWorkflowsPage.tsx index 5503ab7a24428..a9186d19d64a5 100644 --- a/src/pages/workspace/workflows/WorkspaceWorkflowsPage.tsx +++ b/src/pages/workspace/workflows/WorkspaceWorkflowsPage.tsx @@ -260,7 +260,7 @@ function WorkspaceWorkflowsPage({policy, route}: WorkspaceWorkflowsPageProps) { pendingAction={policy?.pendingFields?.reimburser} shouldDisableOpacity={isOffline && !!policy?.pendingFields?.reimbursementChoice && !!policy?.pendingFields?.reimburser} errors={ErrorUtils.getLatestErrorField(policy ?? {}, CONST.POLICY.COLLECTION_KEYS.REIMBURSER)} - onClose={() => Policy.clearPolicyErrorField(policy?.id ?? '', CONST.POLICY.COLLECTION_KEYS.REIMBURSER)} + onClose={() => Policy.clearPolicyErrorField(policy?.id, CONST.POLICY.COLLECTION_KEYS.REIMBURSER)} errorRowStyles={[styles.ml7]} > Date: Thu, 19 Dec 2024 15:32:15 +0100 Subject: [PATCH 4/8] fix: eslint --- src/pages/workspace/WorkspaceInitialPage.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/pages/workspace/WorkspaceInitialPage.tsx b/src/pages/workspace/WorkspaceInitialPage.tsx index 8fce856c2b9bc..b4fed1bf065ca 100644 --- a/src/pages/workspace/WorkspaceInitialPage.tsx +++ b/src/pages/workspace/WorkspaceInitialPage.tsx @@ -455,7 +455,7 @@ function WorkspaceInitialPage({policyDraft, policy: policyProp, route}: Workspac if (!currentUserPolicyExpenseChat?.reportID) { return; } - Navigation.navigate(ROUTES.REPORT_WITH_ID.getRoute(currentUserPolicyExpenseChat?.reportID), CONST.NAVIGATION.TYPE.UP) + Navigation.navigate(ROUTES.REPORT_WITH_ID.getRoute(currentUserPolicyExpenseChat?.reportID), CONST.NAVIGATION.TYPE.UP); }} shouldShowRightIcon wrapperStyle={[styles.br2, styles.pl2, styles.pr0, styles.pv3, styles.mt1, styles.alignItemsCenter]} From 366f4f91d3b943aad603f603e0bbdb9c7aeefb37 Mon Sep 17 00:00:00 2001 From: kirillzyusko Date: Fri, 20 Dec 2024 11:18:42 +0100 Subject: [PATCH 5/8] fix: changes after review --- src/libs/PolicyUtils.ts | 8 ++++---- src/libs/ReportUtils.ts | 2 +- src/libs/actions/Policy/Policy.ts | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/libs/PolicyUtils.ts b/src/libs/PolicyUtils.ts index 3f06532df87d4..ccc900fa9fa40 100644 --- a/src/libs/PolicyUtils.ts +++ b/src/libs/PolicyUtils.ts @@ -1072,17 +1072,17 @@ function getCurrentTaxID(policy: OnyxEntry, taxID: string): string | und return Object.keys(policy?.taxRates?.taxes ?? {}).find((taxIDKey) => policy?.taxRates?.taxes?.[taxIDKey].previousTaxCode === taxID || taxIDKey === taxID); } -function getWorkspaceAccountID(policyID?: string) { +function getWorkspaceAccountID(policyID: string | undefined) { if (!policyID) { - return 0; + return CONST.DEFAULT_NUMBER_ID; } const policy = getPolicy(policyID); if (!policy) { - return 0; + return CONST.DEFAULT_NUMBER_ID; } - return policy.workspaceAccountID ?? 0; + return policy.workspaceAccountID ?? CONST.DEFAULT_NUMBER_ID; } function hasVBBA(policyID: string) { diff --git a/src/libs/ReportUtils.ts b/src/libs/ReportUtils.ts index b5061b1a00cbf..5fd9bffd6d329 100644 --- a/src/libs/ReportUtils.ts +++ b/src/libs/ReportUtils.ts @@ -6757,7 +6757,7 @@ function getInvoiceChatByParticipants(policyID: string, receiverID: string | num /** * Attempts to find a policy expense report in onyx that is owned by ownerAccountID in a given policy */ -function getPolicyExpenseChat(ownerAccountID: number, policyID?: string): OnyxEntry { +function getPolicyExpenseChat(ownerAccountID: number, policyID: string | undefined): OnyxEntry { if (!policyID) { return undefined; } diff --git a/src/libs/actions/Policy/Policy.ts b/src/libs/actions/Policy/Policy.ts index 0b66c6ba8e8a2..ba9b8ed6c9873 100644 --- a/src/libs/actions/Policy/Policy.ts +++ b/src/libs/actions/Policy/Policy.ts @@ -623,7 +623,7 @@ function setWorkspacePayer(policyID: string, reimburserEmail: string) { API.write(WRITE_COMMANDS.SET_WORKSPACE_PAYER, params, {optimisticData, failureData, successData}); } -function clearPolicyErrorField(policyID?: string, fieldName?: string) { +function clearPolicyErrorField(policyID: string | undefined, fieldName: string | undefined) { if (!policyID || !fieldName) { return; } From d27e0bce0cfe15b471254c48e2ed12d0d7beea49 Mon Sep 17 00:00:00 2001 From: Christoph Pader Date: Wed, 22 Jan 2025 16:05:28 +0100 Subject: [PATCH 6/8] fix: add bottom safe area padding for more screens --- src/pages/settings/Preferences/PreferencesPage.tsx | 1 - src/pages/settings/Profile/ProfilePage.tsx | 1 - 2 files changed, 2 deletions(-) diff --git a/src/pages/settings/Preferences/PreferencesPage.tsx b/src/pages/settings/Preferences/PreferencesPage.tsx index 48cb8c99cf21e..6ddd8c6b6871c 100755 --- a/src/pages/settings/Preferences/PreferencesPage.tsx +++ b/src/pages/settings/Preferences/PreferencesPage.tsx @@ -36,7 +36,6 @@ function PreferencesPage() { return ( From 2144b059c3bdac9be407d4ef306d5c9dbb2b3d20 Mon Sep 17 00:00:00 2001 From: Christoph Pader Date: Wed, 22 Jan 2025 17:20:43 +0100 Subject: [PATCH 7/8] refactor: remove `includeSafeAreaPaddingBottom={false}` --- src/components/AddPaymentCard/PaymentCardCurrencyModal.tsx | 1 - src/components/AmountPicker/AmountSelectorModal.tsx | 1 - src/components/AvatarCropModal/AvatarCropModal.tsx | 1 - src/components/CountryPicker/CountrySelectorModal.tsx | 1 - src/components/CurrencyPicker.tsx | 1 - src/components/HeaderPageLayout.tsx | 1 - src/components/ImportSpreadsheet.tsx | 1 - src/components/PushRowWithModal/PushRowModal.tsx | 1 - src/components/StatePicker/StateSelectorModal.tsx | 1 - src/pages/Debug/Report/DebugReportPage.tsx | 1 - src/pages/Debug/ReportAction/DebugReportActionCreatePage.tsx | 1 - src/pages/Debug/ReportAction/DebugReportActionPage.tsx | 1 - src/pages/Debug/Transaction/DebugTransactionPage.tsx | 1 - .../DebugTransactionViolationCreatePage.tsx | 1 - .../TransactionViolation/DebugTransactionViolationPage.tsx | 1 - src/pages/EditReportFieldPage.tsx | 1 - src/pages/EnablePayments/AddBankAccount/AddBankAccount.tsx | 1 - src/pages/EnablePayments/EnablePayments.tsx | 2 -- src/pages/FlagCommentPage.tsx | 5 +---- src/pages/KeyboardShortcutsPage.tsx | 5 +---- .../MissingPersonalDetails/MissingPersonalDetailsContent.tsx | 1 - src/pages/NewChatSelectorPage.tsx | 1 - src/pages/OnboardingAccounting/BaseOnboardingAccounting.tsx | 1 - src/pages/OnboardingEmployees/BaseOnboardingEmployees.tsx | 1 - .../OnboardingPrivateDomain/BaseOnboardingPrivateDomain.tsx | 1 - src/pages/OnboardingWorkspaces/BaseOnboardingWorkspaces.tsx | 1 - src/pages/PrivateNotes/PrivateNotesListPage.tsx | 5 +---- src/pages/ReimbursementAccount/BankAccountStep.tsx | 5 +---- .../BusinessTypePicker/BusinessTypeSelectorModal.tsx | 1 - .../ConnectBankAccount/ConnectBankAccount.tsx | 1 - src/pages/ReimbursementAccount/ContinueBankAccountSetup.tsx | 5 +---- .../EnableBankAccount/EnableBankAccount.tsx | 1 - src/pages/ReimbursementAccount/NonUSD/Finish/index.tsx | 1 - src/pages/ReimbursementAccount/RequestorOnfidoStep.tsx | 1 - src/pages/ReportParticipantsPage.tsx | 1 - src/pages/RoomMembersPage.tsx | 1 - .../SearchFiltersExpenseTypePage.tsx | 1 - src/pages/TeachersUnite/SaveTheWorldPage.tsx | 1 - src/pages/Travel/MyTripsPage.tsx | 1 - src/pages/Travel/TravelTerms.tsx | 1 - src/pages/Travel/TripSummaryPage.tsx | 1 - src/pages/home/sidebar/AllSettingsScreen.tsx | 1 - src/pages/home/sidebar/SidebarScreen/BaseSidebarScreen.tsx | 1 - src/pages/iou/request/step/StepScreenDragAndDropWrapper.tsx | 1 - .../settings/AboutPage/ShareLogList/BaseShareLogList.tsx | 5 +---- src/pages/settings/InitialSettingsPage.tsx | 1 - src/pages/settings/Preferences/LanguagePage.tsx | 5 +---- src/pages/settings/Preferences/PriorityModePage.tsx | 5 +---- src/pages/settings/Preferences/ThemePage.tsx | 5 +---- .../Profile/PersonalDetails/CountrySelectionPage.tsx | 5 +---- .../settings/Profile/PersonalDetails/StateSelectionPage.tsx | 5 +---- src/pages/settings/Profile/PronounsPage.tsx | 5 +---- src/pages/settings/Profile/TimezoneSelectPage.tsx | 5 +---- src/pages/settings/Report/NotificationPreferencePage.tsx | 5 +---- src/pages/settings/Report/VisibilityPage.tsx | 5 +---- src/pages/settings/Report/WriteCapabilityPage.tsx | 5 +---- src/pages/settings/Security/AddDelegate/AddDelegatePage.tsx | 5 +---- .../settings/Security/AddDelegate/SelectDelegateRolePage.tsx | 5 +---- .../UpdateDelegateRole/UpdateDelegateMagicCodePage.tsx | 1 - .../UpdateDelegateRole/UpdateDelegateRolePage.tsx | 5 +---- src/pages/settings/Security/SecuritySettingsPage.tsx | 1 - .../settings/Security/TwoFactorAuth/TwoFactorAuthPage.tsx | 1 - .../settings/Subscription/CardAuthenticationModal/index.tsx | 1 - .../Subscription/DisableAutoRenewSurveyPage/index.tsx | 1 - .../Subscription/RequestEarlyCancellationPage/index.tsx | 1 - src/pages/settings/Subscription/SubscriptionSize/index.tsx | 1 - src/pages/settings/Wallet/AddDebitCardPage.tsx | 1 - src/pages/signin/SAMLSignInPage/index.native.tsx | 1 - src/pages/signin/SignInModal.tsx | 1 - src/pages/tasks/TaskAssigneeSelectorModal.tsx | 5 +---- src/pages/tasks/TaskShareDestinationSelectorModal.tsx | 1 - src/pages/wallet/WalletStatementPage.tsx | 1 - src/pages/workspace/WorkspaceInviteMessagePage.tsx | 1 - src/pages/workspace/WorkspaceProfileCurrencyPage.tsx | 5 +---- src/pages/workspace/WorkspacesListPage.tsx | 1 - src/pages/workspace/accounting/PolicyAccountingPage.tsx | 1 - .../accounting/netsuite/advanced/NetSuiteAutoSyncPage.tsx | 1 - .../NetSuiteCustomListSelectorModal.tsx | 1 - .../accounting/reconciliation/CardReconciliationPage.tsx | 1 - src/pages/workspace/categories/CategoryApproverPage.tsx | 1 - .../workspace/categories/CategoryDefaultTaxRatePage.tsx | 1 - .../workspace/categories/CategoryRequireReceiptsOverPage.tsx | 1 - src/pages/workspace/categories/CategorySettingsPage.tsx | 1 - .../ExpenseLimitTypeSelectorModal.tsx | 1 - src/pages/workspace/categories/WorkspaceCategoriesPage.tsx | 1 - .../workspace/categories/WorkspaceCategoriesSettingsPage.tsx | 1 - .../companyCards/WorkspaceCompanyCardDetailsPage.tsx | 5 +---- src/pages/workspace/companyCards/addNew/AddNewCardPage.tsx | 1 - src/pages/workspace/companyCards/addNew/AmexCustomFeed.tsx | 1 - .../companyCards/addNew/BankConnection/index.native.tsx | 1 - src/pages/workspace/companyCards/addNew/CardTypeStep.tsx | 1 - src/pages/workspace/companyCards/addNew/SelectBankStep.tsx | 1 - src/pages/workspace/companyCards/addNew/SelectFeedType.tsx | 1 - .../workspace/companyCards/assignCard/AssignCardFeedPage.tsx | 1 - .../companyCards/assignCard/BankConnection/index.native.tsx | 1 - .../workspace/companyCards/assignCard/CardSelectionStep.tsx | 1 - .../assignCard/TransactionStartDateSelectorModal.tsx | 1 - .../distanceRates/PolicyDistanceRateDetailsPage.tsx | 1 - .../distanceRates/PolicyDistanceRateTaxRateEditPage.tsx | 1 - .../workspace/distanceRates/PolicyDistanceRatesPage.tsx | 1 - .../distanceRates/PolicyDistanceRatesSettingsPage.tsx | 1 - .../distanceRates/UnitSelector/UnitSelectorModal.tsx | 1 - .../workspace/expensifyCard/WorkspaceCardSettingsPage.tsx | 1 - .../expensifyCard/WorkspaceExpensifyCardBankAccounts.tsx | 1 - .../expensifyCard/WorkspaceExpensifyCardDetailsPage.tsx | 5 +---- .../expensifyCard/WorkspaceSettlementAccountPage.tsx | 1 - .../expensifyCard/WorkspaceSettlementFrequencyPage.tsx | 1 - .../workspace/expensifyCard/issueNew/IssueNewCardPage.tsx | 1 - src/pages/workspace/perDiem/WorkspacePerDiemDetailsPage.tsx | 1 - src/pages/workspace/perDiem/WorkspacePerDiemPage.tsx | 1 - src/pages/workspace/perDiem/WorkspacePerDiemSettingsPage.tsx | 1 - .../InitialListValueSelectorModal.tsx | 1 - .../workspace/reportFields/ReportFieldsListValuesPage.tsx | 1 - .../workspace/reportFields/ReportFieldsSettingsPage.tsx | 1 - .../workspace/reportFields/ReportFieldsValueSettingsPage.tsx | 1 - .../reportFields/TypeSelector/TypeSelectorModal.tsx | 1 - .../workspace/reportFields/WorkspaceReportFieldsPage.tsx | 1 - src/pages/workspace/rules/RulesBillableDefaultPage.tsx | 1 - src/pages/workspace/tags/TagApproverPage.tsx | 1 - src/pages/workspace/tags/TagSettingsPage.tsx | 1 - src/pages/workspace/tags/WorkspaceTagsPage.tsx | 1 - src/pages/workspace/tags/WorkspaceTagsSettingsPage.tsx | 1 - src/pages/workspace/tags/WorkspaceViewTagsPage.tsx | 1 - src/pages/workspace/taxes/WorkspaceCreateTaxPage.tsx | 1 - src/pages/workspace/taxes/WorkspaceTaxesPage.tsx | 1 - .../taxes/WorkspaceTaxesSettingsForeignCurrency.tsx | 1 - .../taxes/WorkspaceTaxesSettingsWorkspaceCurrency.tsx | 1 - .../workflows/WorkspaceAutoReportingFrequencyPage.tsx | 5 +---- .../workflows/WorkspaceAutoReportingMonthlyOffsetPage.tsx | 5 +---- .../workspace/workflows/WorkspaceWorkflowsPayerPage.tsx | 5 +---- 130 files changed, 26 insertions(+), 209 deletions(-) diff --git a/src/components/AddPaymentCard/PaymentCardCurrencyModal.tsx b/src/components/AddPaymentCard/PaymentCardCurrencyModal.tsx index f7c3ca4e2b5e4..9231737ed9bc7 100644 --- a/src/components/AddPaymentCard/PaymentCardCurrencyModal.tsx +++ b/src/components/AddPaymentCard/PaymentCardCurrencyModal.tsx @@ -62,7 +62,6 @@ function PaymentCardCurrencyModal({isVisible, currencies, currentCurrency = CONS {shouldUseNarrowLayout && } diff --git a/src/components/CountryPicker/CountrySelectorModal.tsx b/src/components/CountryPicker/CountrySelectorModal.tsx index 2daa74dcb4e88..47a1042a771c4 100644 --- a/src/components/CountryPicker/CountrySelectorModal.tsx +++ b/src/components/CountryPicker/CountrySelectorModal.tsx @@ -70,7 +70,6 @@ function CountrySelectorModal({isVisible, currentCountry, onCountrySelected, onC diff --git a/src/pages/EnablePayments/AddBankAccount/AddBankAccount.tsx b/src/pages/EnablePayments/AddBankAccount/AddBankAccount.tsx index 55f19f8c35b9f..7ec3706a18fac 100644 --- a/src/pages/EnablePayments/AddBankAccount/AddBankAccount.tsx +++ b/src/pages/EnablePayments/AddBankAccount/AddBankAccount.tsx @@ -72,7 +72,6 @@ function AddBankAccount() { return ( diff --git a/src/pages/EnablePayments/EnablePayments.tsx b/src/pages/EnablePayments/EnablePayments.tsx index b55141fec2995..86c7486b14bc4 100644 --- a/src/pages/EnablePayments/EnablePayments.tsx +++ b/src/pages/EnablePayments/EnablePayments.tsx @@ -39,7 +39,6 @@ function EnablePaymentsPage() { return ( @@ -55,7 +54,6 @@ function EnablePaymentsPage() { return ( + {({safeAreaPaddingBottomStyle}) => ( + diff --git a/src/pages/MissingPersonalDetails/MissingPersonalDetailsContent.tsx b/src/pages/MissingPersonalDetails/MissingPersonalDetailsContent.tsx index e09c58b54d5eb..7e8085960d2ec 100644 --- a/src/pages/MissingPersonalDetails/MissingPersonalDetailsContent.tsx +++ b/src/pages/MissingPersonalDetails/MissingPersonalDetailsContent.tsx @@ -109,7 +109,6 @@ function MissingPersonalDetailsContent({privatePersonalDetails, draftValues}: Mi return ( diff --git a/src/pages/NewChatSelectorPage.tsx b/src/pages/NewChatSelectorPage.tsx index 9e167c2d51a77..fd26c19a70910 100755 --- a/src/pages/NewChatSelectorPage.tsx +++ b/src/pages/NewChatSelectorPage.tsx @@ -32,7 +32,6 @@ function NewChatSelectorPage() { return ( diff --git a/src/pages/OnboardingEmployees/BaseOnboardingEmployees.tsx b/src/pages/OnboardingEmployees/BaseOnboardingEmployees.tsx index 12722e87f05a0..778dcb58abcd2 100644 --- a/src/pages/OnboardingEmployees/BaseOnboardingEmployees.tsx +++ b/src/pages/OnboardingEmployees/BaseOnboardingEmployees.tsx @@ -114,7 +114,6 @@ function BaseOnboardingEmployees({shouldUseNativeStyles, route}: BaseOnboardingE return ( diff --git a/src/pages/OnboardingPrivateDomain/BaseOnboardingPrivateDomain.tsx b/src/pages/OnboardingPrivateDomain/BaseOnboardingPrivateDomain.tsx index 50d8b7f7ce2e2..d6bad730d7462 100644 --- a/src/pages/OnboardingPrivateDomain/BaseOnboardingPrivateDomain.tsx +++ b/src/pages/OnboardingPrivateDomain/BaseOnboardingPrivateDomain.tsx @@ -57,7 +57,6 @@ function BaseOnboardingPrivateDomain({shouldUseNativeStyles, route}: BaseOnboard return ( diff --git a/src/pages/OnboardingWorkspaces/BaseOnboardingWorkspaces.tsx b/src/pages/OnboardingWorkspaces/BaseOnboardingWorkspaces.tsx index c6d332f075ed2..1e19ec13aa044 100644 --- a/src/pages/OnboardingWorkspaces/BaseOnboardingWorkspaces.tsx +++ b/src/pages/OnboardingWorkspaces/BaseOnboardingWorkspaces.tsx @@ -113,7 +113,6 @@ function BaseOnboardingWorkspaces({shouldUseNativeStyles, route}: BaseOnboarding return ( diff --git a/src/pages/PrivateNotes/PrivateNotesListPage.tsx b/src/pages/PrivateNotes/PrivateNotesListPage.tsx index d2cdda140bb8b..36c94ed439fb2 100644 --- a/src/pages/PrivateNotes/PrivateNotesListPage.tsx +++ b/src/pages/PrivateNotes/PrivateNotesListPage.tsx @@ -87,10 +87,7 @@ function PrivateNotesListPage({report, accountID: sessionAccountID}: PrivateNote }, [report, personalDetailsList, sessionAccountID, translate, backTo]); return ( - + + diff --git a/src/pages/ReimbursementAccount/ContinueBankAccountSetup.tsx b/src/pages/ReimbursementAccount/ContinueBankAccountSetup.tsx index 9e1897348dabe..ddafb35cc9e56 100644 --- a/src/pages/ReimbursementAccount/ContinueBankAccountSetup.tsx +++ b/src/pages/ReimbursementAccount/ContinueBankAccountSetup.tsx @@ -39,10 +39,7 @@ function ContinueBankAccountSetup({policyName = '', onBackButtonPress, reimburse const pendingAction = reimbursementAccount?.pendingAction ?? null; return ( - + diff --git a/src/pages/ReimbursementAccount/RequestorOnfidoStep.tsx b/src/pages/ReimbursementAccount/RequestorOnfidoStep.tsx index 26197abd5f6cf..97e5e70ce3e02 100644 --- a/src/pages/ReimbursementAccount/RequestorOnfidoStep.tsx +++ b/src/pages/ReimbursementAccount/RequestorOnfidoStep.tsx @@ -60,7 +60,6 @@ function RequestorOnfidoStep({onBackButtonPress, reimbursementAccount, onfidoTok return ( diff --git a/src/pages/ReportParticipantsPage.tsx b/src/pages/ReportParticipantsPage.tsx index 1bb36bf89080c..b2490529eccf8 100755 --- a/src/pages/ReportParticipantsPage.tsx +++ b/src/pages/ReportParticipantsPage.tsx @@ -361,7 +361,6 @@ function ReportParticipantsPage({report, route}: ReportParticipantsPageProps) { return ( diff --git a/src/pages/RoomMembersPage.tsx b/src/pages/RoomMembersPage.tsx index a14ada3d3f003..4218d3ce2f009 100644 --- a/src/pages/RoomMembersPage.tsx +++ b/src/pages/RoomMembersPage.tsx @@ -353,7 +353,6 @@ function RoomMembersPage({report, policies}: RoomMembersPageProps) { return ( diff --git a/src/pages/Search/SearchAdvancedFiltersPage/SearchFiltersExpenseTypePage.tsx b/src/pages/Search/SearchAdvancedFiltersPage/SearchFiltersExpenseTypePage.tsx index f0e90912302dd..57ae26d6fa8f9 100644 --- a/src/pages/Search/SearchAdvancedFiltersPage/SearchFiltersExpenseTypePage.tsx +++ b/src/pages/Search/SearchAdvancedFiltersPage/SearchFiltersExpenseTypePage.tsx @@ -45,7 +45,6 @@ function SearchFiltersExpenseTypePage() { testID={SearchFiltersExpenseTypePage.displayName} shouldShowOfflineIndicatorInWideScreen offlineIndicatorStyle={styles.mtAuto} - includeSafeAreaPaddingBottom={false} shouldEnableMaxHeight > diff --git a/src/pages/Travel/MyTripsPage.tsx b/src/pages/Travel/MyTripsPage.tsx index 58db57685ab70..ebac98dd9fed0 100644 --- a/src/pages/Travel/MyTripsPage.tsx +++ b/src/pages/Travel/MyTripsPage.tsx @@ -13,7 +13,6 @@ function MyTripsPage() { return ( diff --git a/src/pages/Travel/TripSummaryPage.tsx b/src/pages/Travel/TripSummaryPage.tsx index 69926f0e443e9..95c399eb3d164 100644 --- a/src/pages/Travel/TripSummaryPage.tsx +++ b/src/pages/Travel/TripSummaryPage.tsx @@ -26,7 +26,6 @@ function TripSummaryPage({route}: TripSummaryPageProps) { return ( + {({didScreenTransitionEnd}) => ( <> diff --git a/src/pages/settings/Preferences/LanguagePage.tsx b/src/pages/settings/Preferences/LanguagePage.tsx index 0b23210b8ff14..25ac51b16c0bc 100644 --- a/src/pages/settings/Preferences/LanguagePage.tsx +++ b/src/pages/settings/Preferences/LanguagePage.tsx @@ -34,10 +34,7 @@ function LanguagePage() { }; return ( - + Navigation.goBack()} diff --git a/src/pages/settings/Preferences/PriorityModePage.tsx b/src/pages/settings/Preferences/PriorityModePage.tsx index 57f565e7dca73..3ee5acf890e7c 100644 --- a/src/pages/settings/Preferences/PriorityModePage.tsx +++ b/src/pages/settings/Preferences/PriorityModePage.tsx @@ -45,10 +45,7 @@ function PriorityModePage() { ); return ( - + Navigation.goBack()} diff --git a/src/pages/settings/Preferences/ThemePage.tsx b/src/pages/settings/Preferences/ThemePage.tsx index 274fbee38912f..5911cc880a42e 100644 --- a/src/pages/settings/Preferences/ThemePage.tsx +++ b/src/pages/settings/Preferences/ThemePage.tsx @@ -40,10 +40,7 @@ function ThemePage() { }; return ( - + Navigation.goBack()} diff --git a/src/pages/settings/Profile/PersonalDetails/CountrySelectionPage.tsx b/src/pages/settings/Profile/PersonalDetails/CountrySelectionPage.tsx index e0bf0e781e883..d899080037ac3 100644 --- a/src/pages/settings/Profile/PersonalDetails/CountrySelectionPage.tsx +++ b/src/pages/settings/Profile/PersonalDetails/CountrySelectionPage.tsx @@ -60,10 +60,7 @@ function CountrySelectionPage({route, navigation}: CountrySelectionPageProps) { ); return ( - + + + {isLoadingApp && !currentUserPersonalDetails.pronouns ? ( ) : ( diff --git a/src/pages/settings/Profile/TimezoneSelectPage.tsx b/src/pages/settings/Profile/TimezoneSelectPage.tsx index cee713065de71..ff0aac4e1bfb7 100644 --- a/src/pages/settings/Profile/TimezoneSelectPage.tsx +++ b/src/pages/settings/Profile/TimezoneSelectPage.tsx @@ -58,10 +58,7 @@ function TimezoneSelectPage({currentUserPersonalDetails}: TimezoneSelectPageProp }; return ( - + Navigation.goBack(ROUTES.SETTINGS_TIMEZONE)} diff --git a/src/pages/settings/Report/NotificationPreferencePage.tsx b/src/pages/settings/Report/NotificationPreferencePage.tsx index 434505ad473ef..0fed154d698d3 100644 --- a/src/pages/settings/Report/NotificationPreferencePage.tsx +++ b/src/pages/settings/Report/NotificationPreferencePage.tsx @@ -52,10 +52,7 @@ function NotificationPreferencePage({report}: NotificationPreferencePageProps) { ); return ( - + + + + + + diff --git a/src/pages/settings/Security/TwoFactorAuth/TwoFactorAuthPage.tsx b/src/pages/settings/Security/TwoFactorAuth/TwoFactorAuthPage.tsx index bc3dc588c1b16..ac61bd3eaf598 100644 --- a/src/pages/settings/Security/TwoFactorAuth/TwoFactorAuthPage.tsx +++ b/src/pages/settings/Security/TwoFactorAuth/TwoFactorAuthPage.tsx @@ -13,7 +13,6 @@ function TwoFactorAuthPage() { return ( diff --git a/src/pages/settings/Subscription/CardAuthenticationModal/index.tsx b/src/pages/settings/Subscription/CardAuthenticationModal/index.tsx index b323c668b0b5a..d05f74c1bfc25 100644 --- a/src/pages/settings/Subscription/CardAuthenticationModal/index.tsx +++ b/src/pages/settings/Subscription/CardAuthenticationModal/index.tsx @@ -68,7 +68,6 @@ function CardAuthenticationModal({headerTitle, policyID}: CardAuthenticationModa diff --git a/src/pages/settings/Subscription/RequestEarlyCancellationPage/index.tsx b/src/pages/settings/Subscription/RequestEarlyCancellationPage/index.tsx index 922293dc06512..abbadfb8233ce 100644 --- a/src/pages/settings/Subscription/RequestEarlyCancellationPage/index.tsx +++ b/src/pages/settings/Subscription/RequestEarlyCancellationPage/index.tsx @@ -124,7 +124,6 @@ function RequestEarlyCancellationPage() { return ( diff --git a/src/pages/settings/Subscription/SubscriptionSize/index.tsx b/src/pages/settings/Subscription/SubscriptionSize/index.tsx index 71febe24ca4c5..d0d5714cce6d3 100644 --- a/src/pages/settings/Subscription/SubscriptionSize/index.tsx +++ b/src/pages/settings/Subscription/SubscriptionSize/index.tsx @@ -55,7 +55,6 @@ function SubscriptionSizePage({route}: SubscriptionSizePageProps) { return ( nameOnCardRef.current?.focus()} - includeSafeAreaPaddingBottom={false} testID={DebitCardPage.displayName} > {showNavigation && ( diff --git a/src/pages/signin/SignInModal.tsx b/src/pages/signin/SignInModal.tsx index 8cfa3ba3dcc80..824a7c9bfba89 100644 --- a/src/pages/signin/SignInModal.tsx +++ b/src/pages/signin/SignInModal.tsx @@ -38,7 +38,6 @@ function SignInModal() { return ( + setDidScreenTransitionEnd(true)} > diff --git a/src/pages/wallet/WalletStatementPage.tsx b/src/pages/wallet/WalletStatementPage.tsx index 4a363e19e4903..b1a0ec5bc0134 100644 --- a/src/pages/wallet/WalletStatementPage.tsx +++ b/src/pages/wallet/WalletStatementPage.tsx @@ -89,7 +89,6 @@ function WalletStatementPage({route}: WalletStatementPageProps) { return ( - + Navigation.goBack()} diff --git a/src/pages/workspace/WorkspacesListPage.tsx b/src/pages/workspace/WorkspacesListPage.tsx index acd0b158fa677..5a9bc9ef80253 100755 --- a/src/pages/workspace/WorkspacesListPage.tsx +++ b/src/pages/workspace/WorkspacesListPage.tsx @@ -426,7 +426,6 @@ function WorkspacesListPage() { if (isEmptyObject(workspaces)) { return ( diff --git a/src/pages/workspace/categories/CategoryApproverPage.tsx b/src/pages/workspace/categories/CategoryApproverPage.tsx index 78f5f579bf932..9e6ce3ca86bef 100644 --- a/src/pages/workspace/categories/CategoryApproverPage.tsx +++ b/src/pages/workspace/categories/CategoryApproverPage.tsx @@ -35,7 +35,6 @@ function CategoryApproverPage({ featureName={CONST.POLICY.MORE_FEATURES.ARE_CATEGORIES_ENABLED} > diff --git a/src/pages/workspace/categories/ExpenseLimitTypeSelector/ExpenseLimitTypeSelectorModal.tsx b/src/pages/workspace/categories/ExpenseLimitTypeSelector/ExpenseLimitTypeSelectorModal.tsx index 7563bea7d031b..4e181f0e20077 100644 --- a/src/pages/workspace/categories/ExpenseLimitTypeSelector/ExpenseLimitTypeSelectorModal.tsx +++ b/src/pages/workspace/categories/ExpenseLimitTypeSelector/ExpenseLimitTypeSelectorModal.tsx @@ -50,7 +50,6 @@ function ExpenseLimitTypeSelectorModal({isVisible, currentExpenseLimitType, onEx diff --git a/src/pages/workspace/companyCards/WorkspaceCompanyCardDetailsPage.tsx b/src/pages/workspace/companyCards/WorkspaceCompanyCardDetailsPage.tsx index 6528d35b33747..19e87f5215b31 100644 --- a/src/pages/workspace/companyCards/WorkspaceCompanyCardDetailsPage.tsx +++ b/src/pages/workspace/companyCards/WorkspaceCompanyCardDetailsPage.tsx @@ -83,10 +83,7 @@ function WorkspaceCompanyCardDetailsPage({route}: WorkspaceCompanyCardDetailsPag policyID={policyID} featureName={CONST.POLICY.MORE_FEATURES.ARE_COMPANY_CARDS_ENABLED} > - + {({safeAreaPaddingBottomStyle}) => ( <> diff --git a/src/pages/workspace/companyCards/addNew/AmexCustomFeed.tsx b/src/pages/workspace/companyCards/addNew/AmexCustomFeed.tsx index d8ce6d6159d58..39956e388324c 100644 --- a/src/pages/workspace/companyCards/addNew/AmexCustomFeed.tsx +++ b/src/pages/workspace/companyCards/addNew/AmexCustomFeed.tsx @@ -71,7 +71,6 @@ function AmexCustomFeed() { return ( diff --git a/src/pages/workspace/companyCards/addNew/BankConnection/index.native.tsx b/src/pages/workspace/companyCards/addNew/BankConnection/index.native.tsx index 76bf9b2bd9674..b1553bf59a5b1 100644 --- a/src/pages/workspace/companyCards/addNew/BankConnection/index.native.tsx +++ b/src/pages/workspace/companyCards/addNew/BankConnection/index.native.tsx @@ -80,7 +80,6 @@ function BankConnection({policyID}: BankConnectionStepProps) { diff --git a/src/pages/workspace/companyCards/addNew/CardTypeStep.tsx b/src/pages/workspace/companyCards/addNew/CardTypeStep.tsx index 26899ed9e50f6..2c99334807bea 100644 --- a/src/pages/workspace/companyCards/addNew/CardTypeStep.tsx +++ b/src/pages/workspace/companyCards/addNew/CardTypeStep.tsx @@ -99,7 +99,6 @@ function CardTypeStep() { return ( diff --git a/src/pages/workspace/companyCards/addNew/SelectBankStep.tsx b/src/pages/workspace/companyCards/addNew/SelectBankStep.tsx index 15ead5b9a3238..c7309235c8f6b 100644 --- a/src/pages/workspace/companyCards/addNew/SelectBankStep.tsx +++ b/src/pages/workspace/companyCards/addNew/SelectBankStep.tsx @@ -71,7 +71,6 @@ function SelectBankStep() { return ( diff --git a/src/pages/workspace/companyCards/addNew/SelectFeedType.tsx b/src/pages/workspace/companyCards/addNew/SelectFeedType.tsx index 7fe8da2f99546..5123b3ef915c1 100644 --- a/src/pages/workspace/companyCards/addNew/SelectFeedType.tsx +++ b/src/pages/workspace/companyCards/addNew/SelectFeedType.tsx @@ -61,7 +61,6 @@ function SelectFeedType() { return ( diff --git a/src/pages/workspace/companyCards/assignCard/AssignCardFeedPage.tsx b/src/pages/workspace/companyCards/assignCard/AssignCardFeedPage.tsx index 7d6d415065242..169d0c524edcc 100644 --- a/src/pages/workspace/companyCards/assignCard/AssignCardFeedPage.tsx +++ b/src/pages/workspace/companyCards/assignCard/AssignCardFeedPage.tsx @@ -38,7 +38,6 @@ function AssignCardFeedPage({route, policy}: AssignCardFeedPageProps) { return ( diff --git a/src/pages/workspace/companyCards/assignCard/BankConnection/index.native.tsx b/src/pages/workspace/companyCards/assignCard/BankConnection/index.native.tsx index aec2c9ece0cdf..73aa2effdc03b 100644 --- a/src/pages/workspace/companyCards/assignCard/BankConnection/index.native.tsx +++ b/src/pages/workspace/companyCards/assignCard/BankConnection/index.native.tsx @@ -59,7 +59,6 @@ function BankConnection({policyID, feed}: BankConnectionStepProps) { diff --git a/src/pages/workspace/companyCards/assignCard/CardSelectionStep.tsx b/src/pages/workspace/companyCards/assignCard/CardSelectionStep.tsx index 616a74e17f1e1..b9cb9d5e01944 100644 --- a/src/pages/workspace/companyCards/assignCard/CardSelectionStep.tsx +++ b/src/pages/workspace/companyCards/assignCard/CardSelectionStep.tsx @@ -157,7 +157,6 @@ function CardSelectionStep({feed, policyID}: CardSelectionStepProps) { } shouldShowTextInputAfterHeader - includeSafeAreaPaddingBottom={false} shouldShowListEmptyContent={false} shouldUpdateFocusedIndex /> diff --git a/src/pages/workspace/companyCards/assignCard/TransactionStartDateSelectorModal.tsx b/src/pages/workspace/companyCards/assignCard/TransactionStartDateSelectorModal.tsx index 8c0990800bb4c..55cf60e1185a7 100644 --- a/src/pages/workspace/companyCards/assignCard/TransactionStartDateSelectorModal.tsx +++ b/src/pages/workspace/companyCards/assignCard/TransactionStartDateSelectorModal.tsx @@ -51,7 +51,6 @@ function TransactionStartDateSelectorModal({isVisible, date, handleSelectDate, o diff --git a/src/pages/workspace/distanceRates/PolicyDistanceRateTaxRateEditPage.tsx b/src/pages/workspace/distanceRates/PolicyDistanceRateTaxRateEditPage.tsx index 06a8faf29c1df..9c65dd23ab7c0 100644 --- a/src/pages/workspace/distanceRates/PolicyDistanceRateTaxRateEditPage.tsx +++ b/src/pages/workspace/distanceRates/PolicyDistanceRateTaxRateEditPage.tsx @@ -61,7 +61,6 @@ function PolicyDistanceRateTaxRateEditPage({route, policy}: PolicyDistanceRateTa featureName={CONST.POLICY.MORE_FEATURES.ARE_DISTANCE_RATES_ENABLED} > diff --git a/src/pages/workspace/distanceRates/UnitSelector/UnitSelectorModal.tsx b/src/pages/workspace/distanceRates/UnitSelector/UnitSelectorModal.tsx index 34eb21ce19c46..fad6fc69838c2 100644 --- a/src/pages/workspace/distanceRates/UnitSelector/UnitSelectorModal.tsx +++ b/src/pages/workspace/distanceRates/UnitSelector/UnitSelectorModal.tsx @@ -40,7 +40,6 @@ function UnitSelectorModal({isVisible, currentUnit, onUnitSelected, onClose, lab diff --git a/src/pages/workspace/expensifyCard/WorkspaceExpensifyCardBankAccounts.tsx b/src/pages/workspace/expensifyCard/WorkspaceExpensifyCardBankAccounts.tsx index 5da459be4a160..5ad27545a92af 100644 --- a/src/pages/workspace/expensifyCard/WorkspaceExpensifyCardBankAccounts.tsx +++ b/src/pages/workspace/expensifyCard/WorkspaceExpensifyCardBankAccounts.tsx @@ -185,7 +185,6 @@ function WorkspaceExpensifyCardBankAccounts({route}: WorkspaceExpensifyCardBankA > diff --git a/src/pages/workspace/expensifyCard/WorkspaceExpensifyCardDetailsPage.tsx b/src/pages/workspace/expensifyCard/WorkspaceExpensifyCardDetailsPage.tsx index fdef6ecdc481f..c98c298879030 100644 --- a/src/pages/workspace/expensifyCard/WorkspaceExpensifyCardDetailsPage.tsx +++ b/src/pages/workspace/expensifyCard/WorkspaceExpensifyCardDetailsPage.tsx @@ -86,10 +86,7 @@ function WorkspaceExpensifyCardDetailsPage({route}: WorkspaceExpensifyCardDetail policyID={policyID} featureName={CONST.POLICY.MORE_FEATURES.ARE_EXPENSIFY_CARDS_ENABLED} > - + {({safeAreaPaddingBottomStyle}) => ( <> diff --git a/src/pages/workspace/perDiem/WorkspacePerDiemDetailsPage.tsx b/src/pages/workspace/perDiem/WorkspacePerDiemDetailsPage.tsx index 3e53a1681274e..5acda2c9bf25c 100644 --- a/src/pages/workspace/perDiem/WorkspacePerDiemDetailsPage.tsx +++ b/src/pages/workspace/perDiem/WorkspacePerDiemDetailsPage.tsx @@ -67,7 +67,6 @@ function WorkspacePerDiemDetailsPage({route}: WorkspacePerDiemDetailsPageProps) featureName={CONST.POLICY.MORE_FEATURES.ARE_PER_DIEM_RATES_ENABLED} > diff --git a/src/pages/workspace/perDiem/WorkspacePerDiemPage.tsx b/src/pages/workspace/perDiem/WorkspacePerDiemPage.tsx index 1f51af583d8a9..24aae601e9153 100644 --- a/src/pages/workspace/perDiem/WorkspacePerDiemPage.tsx +++ b/src/pages/workspace/perDiem/WorkspacePerDiemPage.tsx @@ -335,7 +335,6 @@ function WorkspacePerDiemPage({route}: WorkspacePerDiemPageProps) { featureName={CONST.POLICY.MORE_FEATURES.ARE_PER_DIEM_RATES_ENABLED} > diff --git a/src/pages/workspace/reportFields/InitialListValueSelector/InitialListValueSelectorModal.tsx b/src/pages/workspace/reportFields/InitialListValueSelector/InitialListValueSelectorModal.tsx index fa6c5dc76bdbf..81f038ad76df0 100644 --- a/src/pages/workspace/reportFields/InitialListValueSelector/InitialListValueSelectorModal.tsx +++ b/src/pages/workspace/reportFields/InitialListValueSelector/InitialListValueSelectorModal.tsx @@ -47,7 +47,6 @@ function InitialListValueSelectorModal({isVisible, currentValue, label, subtitle diff --git a/src/pages/workspace/reportFields/ReportFieldsValueSettingsPage.tsx b/src/pages/workspace/reportFields/ReportFieldsValueSettingsPage.tsx index 08b94fcc4aee8..ee3edd159fa2a 100644 --- a/src/pages/workspace/reportFields/ReportFieldsValueSettingsPage.tsx +++ b/src/pages/workspace/reportFields/ReportFieldsValueSettingsPage.tsx @@ -94,7 +94,6 @@ function ReportFieldsValueSettingsPage({ featureName={CONST.POLICY.MORE_FEATURES.ARE_REPORT_FIELDS_ENABLED} > diff --git a/src/pages/workspace/reportFields/TypeSelector/TypeSelectorModal.tsx b/src/pages/workspace/reportFields/TypeSelector/TypeSelectorModal.tsx index ca64dda455a46..1331af715d103 100644 --- a/src/pages/workspace/reportFields/TypeSelector/TypeSelectorModal.tsx +++ b/src/pages/workspace/reportFields/TypeSelector/TypeSelectorModal.tsx @@ -45,7 +45,6 @@ function TypeSelectorModal({isVisible, currentType, label, subtitle, onTypeSelec diff --git a/src/pages/workspace/tags/TagApproverPage.tsx b/src/pages/workspace/tags/TagApproverPage.tsx index 9ad97a1738a75..585ebf3cf072d 100644 --- a/src/pages/workspace/tags/TagApproverPage.tsx +++ b/src/pages/workspace/tags/TagApproverPage.tsx @@ -38,7 +38,6 @@ function TagApproverPage({route}: TagApproverPageProps) { featureName={CONST.POLICY.MORE_FEATURES.ARE_RULES_ENABLED} > diff --git a/src/pages/workspace/tags/WorkspaceTagsPage.tsx b/src/pages/workspace/tags/WorkspaceTagsPage.tsx index cd3510cfffb58..a723affe12244 100644 --- a/src/pages/workspace/tags/WorkspaceTagsPage.tsx +++ b/src/pages/workspace/tags/WorkspaceTagsPage.tsx @@ -361,7 +361,6 @@ function WorkspaceTagsPage({route}: WorkspaceTagsPageProps) { featureName={CONST.POLICY.MORE_FEATURES.ARE_TAGS_ENABLED} > {({policy}) => ( diff --git a/src/pages/workspace/tags/WorkspaceViewTagsPage.tsx b/src/pages/workspace/tags/WorkspaceViewTagsPage.tsx index 173c89c415513..5010f122f04fa 100644 --- a/src/pages/workspace/tags/WorkspaceViewTagsPage.tsx +++ b/src/pages/workspace/tags/WorkspaceViewTagsPage.tsx @@ -252,7 +252,6 @@ function WorkspaceViewTagsPage({route}: WorkspaceViewTagsProps) { featureName={CONST.POLICY.MORE_FEATURES.ARE_TAGS_ENABLED} > diff --git a/src/pages/workspace/taxes/WorkspaceCreateTaxPage.tsx b/src/pages/workspace/taxes/WorkspaceCreateTaxPage.tsx index 4dddcb42265d5..e6baaadb01ad9 100644 --- a/src/pages/workspace/taxes/WorkspaceCreateTaxPage.tsx +++ b/src/pages/workspace/taxes/WorkspaceCreateTaxPage.tsx @@ -72,7 +72,6 @@ function WorkspaceCreateTaxPage({ > diff --git a/src/pages/workspace/taxes/WorkspaceTaxesPage.tsx b/src/pages/workspace/taxes/WorkspaceTaxesPage.tsx index e064c04878a13..27463416e77dc 100644 --- a/src/pages/workspace/taxes/WorkspaceTaxesPage.tsx +++ b/src/pages/workspace/taxes/WorkspaceTaxesPage.tsx @@ -290,7 +290,6 @@ function WorkspaceTaxesPage({ featureName={CONST.POLICY.MORE_FEATURES.ARE_TAXES_ENABLED} > - + - + - + Date: Mon, 17 Feb 2025 18:28:21 +0100 Subject: [PATCH 8/8] fix: remove `includeSafeAreaPaddingBottom={false}` on screens after merge main --- src/pages/Travel/TravelUpgrade.tsx | 1 - src/pages/workspace/accounting/MultiConnectionSelectorPage.tsx | 1 - 2 files changed, 2 deletions(-) diff --git a/src/pages/Travel/TravelUpgrade.tsx b/src/pages/Travel/TravelUpgrade.tsx index 78b8f8d7e4880..74247908ecf0a 100644 --- a/src/pages/Travel/TravelUpgrade.tsx +++ b/src/pages/Travel/TravelUpgrade.tsx @@ -55,7 +55,6 @@ function TravelUpgrade() {