From f3a1219ee83b1e8a2a1fbf1efdc4e53b5f5afd3d Mon Sep 17 00:00:00 2001 From: Shubham Agrawal Date: Tue, 18 Feb 2025 20:45:10 +0530 Subject: [PATCH 1/2] Fixed negative amount turns to positive amount after sorting duplicates --- src/libs/TransactionUtils/index.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libs/TransactionUtils/index.ts b/src/libs/TransactionUtils/index.ts index 5ab070a21db7d..18ae93fe3422f 100644 --- a/src/libs/TransactionUtils/index.ts +++ b/src/libs/TransactionUtils/index.ts @@ -1318,7 +1318,7 @@ function buildNewTransactionAfterReviewingDuplicates(reviewDuplicateTransaction: function buildTransactionsMergeParams(reviewDuplicates: OnyxEntry, originalTransaction: Partial): TransactionMergeParams { return { - amount: -getAmount(originalTransaction as OnyxEntry, false), + amount: getAmount(originalTransaction as OnyxEntry, true), reportID: originalTransaction?.reportID, receiptID: originalTransaction?.receipt?.receiptID ?? CONST.DEFAULT_NUMBER_ID, currency: getCurrency(originalTransaction as OnyxEntry), From acb1dc1bbb5d47507826797c91b04df892268f53 Mon Sep 17 00:00:00 2001 From: Shubham Agrawal Date: Tue, 18 Feb 2025 21:17:45 +0530 Subject: [PATCH 2/2] Fix sign of amount --- src/libs/TransactionUtils/index.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libs/TransactionUtils/index.ts b/src/libs/TransactionUtils/index.ts index 18ae93fe3422f..d5d60ba80ce0f 100644 --- a/src/libs/TransactionUtils/index.ts +++ b/src/libs/TransactionUtils/index.ts @@ -1318,7 +1318,7 @@ function buildNewTransactionAfterReviewingDuplicates(reviewDuplicateTransaction: function buildTransactionsMergeParams(reviewDuplicates: OnyxEntry, originalTransaction: Partial): TransactionMergeParams { return { - amount: getAmount(originalTransaction as OnyxEntry, true), + amount: -getAmount(originalTransaction as OnyxEntry, true), reportID: originalTransaction?.reportID, receiptID: originalTransaction?.receipt?.receiptID ?? CONST.DEFAULT_NUMBER_ID, currency: getCurrency(originalTransaction as OnyxEntry),