From 36e808aef0df0c359905714cc1a2c586a688b813 Mon Sep 17 00:00:00 2001 From: Ben Limpich Date: Thu, 20 Feb 2025 12:33:56 -0800 Subject: [PATCH 1/3] remove sideEffect --- src/libs/actions/PaymentMethods.ts | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/src/libs/actions/PaymentMethods.ts b/src/libs/actions/PaymentMethods.ts index 89d8ef741f144..1017996be2f1e 100644 --- a/src/libs/actions/PaymentMethods.ts +++ b/src/libs/actions/PaymentMethods.ts @@ -281,14 +281,7 @@ function addSubscriptionPaymentCard( * Updates verify3dsSubscription Onyx key with a new authentication link for 3DS. */ function addPaymentCardGBP(params: AddPaymentCardParams, onyxData: OnyxData = {}) { - // eslint-disable-next-line rulesdir/no-api-side-effects-method - API.makeRequestWithSideEffects(SIDE_EFFECT_REQUEST_COMMANDS.ADD_PAYMENT_CARD_GBP, params, onyxData).then((response) => { - if (response?.jsonCode !== CONST.JSON_CODE.SUCCESS) { - return; - } - // We are using this onyx key to open Modal and preview iframe. Potentially we can save the whole object which come from side effect - Onyx.set(ONYXKEYS.VERIFY_3DS_SUBSCRIPTION, (response as {authenticationLink: string}).authenticationLink); - }); + API.write(WRITE_COMMANDS.ADD_PAYMENT_CARD_GBP, params, onyxData); } /** From cab6abd7730fda4e61e76694ff11656d8cbb95ce Mon Sep 17 00:00:00 2001 From: Ben Limpich Date: Thu, 20 Feb 2025 12:34:57 -0800 Subject: [PATCH 2/3] remove from list of side effect commands --- src/libs/API/types.ts | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/libs/API/types.ts b/src/libs/API/types.ts index b8d150672e7c1..cc09719878bc5 100644 --- a/src/libs/API/types.ts +++ b/src/libs/API/types.ts @@ -1075,7 +1075,6 @@ const SIDE_EFFECT_REQUEST_COMMANDS = { OPEN_OLD_DOT_LINK: 'OpenOldDotLink', OPEN_REPORT: 'OpenReport', RECONNECT_APP: 'ReconnectApp', - ADD_PAYMENT_CARD_GBP: 'AddPaymentCardGBP', REVEAL_EXPENSIFY_CARD_DETAILS: 'RevealExpensifyCardDetails', TWO_FACTOR_AUTH_VALIDATE: 'TwoFactorAuth_Validate', CONNECT_AS_DELEGATE: 'ConnectAsDelegate', @@ -1099,7 +1098,6 @@ type SideEffectRequestCommandParameters = { [SIDE_EFFECT_REQUEST_COMMANDS.JOIN_POLICY_VIA_INVITE_LINK]: Parameters.JoinPolicyInviteLinkParams; [SIDE_EFFECT_REQUEST_COMMANDS.RECONNECT_APP]: Parameters.ReconnectAppParams; [SIDE_EFFECT_REQUEST_COMMANDS.GENERATE_SPOTNANA_TOKEN]: Parameters.GenerateSpotnanaTokenParams; - [SIDE_EFFECT_REQUEST_COMMANDS.ADD_PAYMENT_CARD_GBP]: Parameters.AddPaymentCardParams; [SIDE_EFFECT_REQUEST_COMMANDS.TWO_FACTOR_AUTH_VALIDATE]: Parameters.ValidateTwoFactorAuthParams; [SIDE_EFFECT_REQUEST_COMMANDS.CONNECT_AS_DELEGATE]: Parameters.ConnectAsDelegateParams; [SIDE_EFFECT_REQUEST_COMMANDS.DISCONNECT_AS_DELEGATE]: EmptyObject; From 47843ef2392198d2d10708e2aa7ab99f026f27f0 Mon Sep 17 00:00:00 2001 From: Ben Limpich Date: Thu, 20 Feb 2025 12:39:21 -0800 Subject: [PATCH 3/3] eslint --- src/libs/actions/PaymentMethods.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libs/actions/PaymentMethods.ts b/src/libs/actions/PaymentMethods.ts index 1017996be2f1e..1af21aa59397f 100644 --- a/src/libs/actions/PaymentMethods.ts +++ b/src/libs/actions/PaymentMethods.ts @@ -14,7 +14,7 @@ import type { TransferWalletBalanceParams, UpdateBillingCurrencyParams, } from '@libs/API/parameters'; -import {READ_COMMANDS, SIDE_EFFECT_REQUEST_COMMANDS, WRITE_COMMANDS} from '@libs/API/types'; +import {READ_COMMANDS, WRITE_COMMANDS} from '@libs/API/types'; import * as CardUtils from '@libs/CardUtils'; import GoogleTagManager from '@libs/GoogleTagManager'; import Navigation from '@libs/Navigation/Navigation';