From 6f39dbfbf8f9b3ece8f1f9fdf66e84fc4ed4556c Mon Sep 17 00:00:00 2001 From: nkdengineer Date: Tue, 25 Feb 2025 10:44:23 +0700 Subject: [PATCH 1/5] fix: Missing bookmark icon for saved --- src/components/Search/SearchPageHeader/SearchTypeMenuPopover.tsx | 1 + 1 file changed, 1 insertion(+) diff --git a/src/components/Search/SearchPageHeader/SearchTypeMenuPopover.tsx b/src/components/Search/SearchPageHeader/SearchTypeMenuPopover.tsx index 852d6c3748bc9..0afa1bb9559eb 100644 --- a/src/components/Search/SearchPageHeader/SearchTypeMenuPopover.tsx +++ b/src/components/Search/SearchPageHeader/SearchTypeMenuPopover.tsx @@ -113,6 +113,7 @@ function SearchTypeMenuPopover({queryJSON, searchName, shouldGroupByReports}: Se styles: [styles.textSupporting], isSelected: false, shouldCallAfterModalHide: true, + icon: Expensicons.Bookmark, }; }, [hash, getOverflowMenu, styles.textSupporting, personalDetails, reports, taxRates, allCards], From 63138ffbfb01289966f0a619aaf0b0c947ae396e Mon Sep 17 00:00:00 2001 From: nkdengineer Date: Thu, 27 Feb 2025 15:15:31 +0700 Subject: [PATCH 2/5] fix icon width --- .../Search/SearchPageHeader/SearchTypeMenuPopover.tsx | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/components/Search/SearchPageHeader/SearchTypeMenuPopover.tsx b/src/components/Search/SearchPageHeader/SearchTypeMenuPopover.tsx index 0afa1bb9559eb..e536d72b51d51 100644 --- a/src/components/Search/SearchPageHeader/SearchTypeMenuPopover.tsx +++ b/src/components/Search/SearchPageHeader/SearchTypeMenuPopover.tsx @@ -26,6 +26,7 @@ import CONST from '@src/CONST'; import ONYXKEYS from '@src/ONYXKEYS'; import ROUTES from '@src/ROUTES'; import type {SaveSearchItem} from '@src/types/onyx/SaveSearch'; +import variables from '@styles/variables'; type SavedSearchMenuItem = MenuItemWithLink & { key: string; @@ -114,6 +115,7 @@ function SearchTypeMenuPopover({queryJSON, searchName, shouldGroupByReports}: Se isSelected: false, shouldCallAfterModalHide: true, icon: Expensicons.Bookmark, + iconWidth: variables.iconSizeExtraLarge, }; }, [hash, getOverflowMenu, styles.textSupporting, personalDetails, reports, taxRates, allCards], From c402bec8b07f0663947b59f0d9186b58aa4a16df Mon Sep 17 00:00:00 2001 From: nkdengineer Date: Thu, 27 Feb 2025 15:24:01 +0700 Subject: [PATCH 3/5] fix lint --- .../Search/SearchPageHeader/SearchTypeMenuPopover.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/components/Search/SearchPageHeader/SearchTypeMenuPopover.tsx b/src/components/Search/SearchPageHeader/SearchTypeMenuPopover.tsx index e536d72b51d51..7f574bbc2c065 100644 --- a/src/components/Search/SearchPageHeader/SearchTypeMenuPopover.tsx +++ b/src/components/Search/SearchPageHeader/SearchTypeMenuPopover.tsx @@ -21,12 +21,12 @@ import Navigation from '@libs/Navigation/Navigation'; import {getAllTaxRates} from '@libs/PolicyUtils'; import {buildSearchQueryJSON, buildUserReadableQueryString, isCannedSearchQuery} from '@libs/SearchQueryUtils'; import {createBaseSavedSearchMenuItem, createTypeMenuItems, getOverflowMenu as getOverflowMenuUtil} from '@libs/SearchUIUtils'; +import variables from '@styles/variables'; import * as Expensicons from '@src/components/Icon/Expensicons'; import CONST from '@src/CONST'; import ONYXKEYS from '@src/ONYXKEYS'; import ROUTES from '@src/ROUTES'; import type {SaveSearchItem} from '@src/types/onyx/SaveSearch'; -import variables from '@styles/variables'; type SavedSearchMenuItem = MenuItemWithLink & { key: string; From d0029723a0a7a33c20ead8b7f1aa87173517f0bf Mon Sep 17 00:00:00 2001 From: nkdengineer Date: Thu, 27 Feb 2025 23:54:53 +0700 Subject: [PATCH 4/5] fix style --- src/components/Search/SearchPageHeader/SearchTypeMenuPopover.tsx | 1 + 1 file changed, 1 insertion(+) diff --git a/src/components/Search/SearchPageHeader/SearchTypeMenuPopover.tsx b/src/components/Search/SearchPageHeader/SearchTypeMenuPopover.tsx index 7f574bbc2c065..73d4b980a12d9 100644 --- a/src/components/Search/SearchPageHeader/SearchTypeMenuPopover.tsx +++ b/src/components/Search/SearchPageHeader/SearchTypeMenuPopover.tsx @@ -116,6 +116,7 @@ function SearchTypeMenuPopover({queryJSON, searchName, shouldGroupByReports}: Se shouldCallAfterModalHide: true, icon: Expensicons.Bookmark, iconWidth: variables.iconSizeExtraLarge, + iconHeight: variables.iconSizeExtraLarge, }; }, [hash, getOverflowMenu, styles.textSupporting, personalDetails, reports, taxRates, allCards], From ea2599b26ecaa47e4c7b0cbd418100bc141a7cc8 Mon Sep 17 00:00:00 2001 From: nkdengineer Date: Fri, 28 Feb 2025 00:26:46 +0700 Subject: [PATCH 5/5] fix style --- .../Search/SearchPageHeader/SearchTypeMenuPopover.tsx | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/components/Search/SearchPageHeader/SearchTypeMenuPopover.tsx b/src/components/Search/SearchPageHeader/SearchTypeMenuPopover.tsx index 73d4b980a12d9..e519a8a22c8cb 100644 --- a/src/components/Search/SearchPageHeader/SearchTypeMenuPopover.tsx +++ b/src/components/Search/SearchPageHeader/SearchTypeMenuPopover.tsx @@ -115,8 +115,9 @@ function SearchTypeMenuPopover({queryJSON, searchName, shouldGroupByReports}: Se isSelected: false, shouldCallAfterModalHide: true, icon: Expensicons.Bookmark, - iconWidth: variables.iconSizeExtraLarge, - iconHeight: variables.iconSizeExtraLarge, + iconWidth: variables.iconSizeNormal, + iconHeight: variables.iconSizeNormal, + shouldIconUseAutoWidthStyle: false, }; }, [hash, getOverflowMenu, styles.textSupporting, personalDetails, reports, taxRates, allCards],