From 4f4501d0b9b3747d2e8def15285a38552a513726 Mon Sep 17 00:00:00 2001 From: Alex Beaman Date: Fri, 7 Mar 2025 13:25:08 +0200 Subject: [PATCH 1/2] Remove invalid default for policyID --- src/pages/workspace/tags/TagSettingsPage.tsx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/pages/workspace/tags/TagSettingsPage.tsx b/src/pages/workspace/tags/TagSettingsPage.tsx index e312e82bd8c40..3c28de7bb579b 100644 --- a/src/pages/workspace/tags/TagSettingsPage.tsx +++ b/src/pages/workspace/tags/TagSettingsPage.tsx @@ -89,8 +89,8 @@ function TagSettingsPage({route, navigation}: TagSettingsPageProps) { policyID, CONST.UPGRADE_FEATURE_INTRO_MAPPING.glCodes.alias, isQuickSettingsFlow - ? ROUTES.SETTINGS_TAG_GL_CODE.getRoute(policy?.id ?? `${CONST.DEFAULT_NUMBER_ID}`, orderWeight, tagName, backTo) - : ROUTES.WORKSPACE_TAG_GL_CODE.getRoute(policy?.id ?? `${CONST.DEFAULT_NUMBER_ID}`, orderWeight, tagName), + ? ROUTES.SETTINGS_TAG_GL_CODE.getRoute(policy?.id ?? '', orderWeight, tagName, backTo) + : ROUTES.WORKSPACE_TAG_GL_CODE.getRoute(policy?.id ?? '', orderWeight, tagName), ), ); return; From a6bc094646c070db81becfdf0a0967841afe612c Mon Sep 17 00:00:00 2001 From: Alex Beaman Date: Fri, 7 Mar 2025 07:24:11 -0700 Subject: [PATCH 2/2] Update src/pages/workspace/tags/TagSettingsPage.tsx Co-authored-by: Shubham Agrawal <58412969+shubham1206agra@users.noreply.github.com> --- src/pages/workspace/tags/TagSettingsPage.tsx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/pages/workspace/tags/TagSettingsPage.tsx b/src/pages/workspace/tags/TagSettingsPage.tsx index 3c28de7bb579b..0e4352abe2300 100644 --- a/src/pages/workspace/tags/TagSettingsPage.tsx +++ b/src/pages/workspace/tags/TagSettingsPage.tsx @@ -89,8 +89,8 @@ function TagSettingsPage({route, navigation}: TagSettingsPageProps) { policyID, CONST.UPGRADE_FEATURE_INTRO_MAPPING.glCodes.alias, isQuickSettingsFlow - ? ROUTES.SETTINGS_TAG_GL_CODE.getRoute(policy?.id ?? '', orderWeight, tagName, backTo) - : ROUTES.WORKSPACE_TAG_GL_CODE.getRoute(policy?.id ?? '', orderWeight, tagName), + ? ROUTES.SETTINGS_TAG_GL_CODE.getRoute(policyID, orderWeight, tagName, backTo) + : ROUTES.WORKSPACE_TAG_GL_CODE.getRoute(policyID, orderWeight, tagName), ), ); return;