From dba1693fefaa45a32475bffe7e757bf2710648f5 Mon Sep 17 00:00:00 2001 From: jay Date: Wed, 19 Mar 2025 20:53:40 +0100 Subject: [PATCH 1/4] fix(translation): show correct error message for bank account flow --- .../VerifiedBankAccountFlowEntryPoint.tsx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/pages/ReimbursementAccount/VerifiedBankAccountFlowEntryPoint.tsx b/src/pages/ReimbursementAccount/VerifiedBankAccountFlowEntryPoint.tsx index d9a8a7c71c06f..74549ee121382 100644 --- a/src/pages/ReimbursementAccount/VerifiedBankAccountFlowEntryPoint.tsx +++ b/src/pages/ReimbursementAccount/VerifiedBankAccountFlowEntryPoint.tsx @@ -18,7 +18,7 @@ import ValidateCodeActionModal from '@components/ValidateCodeActionModal'; import useLocalize from '@hooks/useLocalize'; import useTheme from '@hooks/useTheme'; import useThemeStyles from '@hooks/useThemeStyles'; -import {getEarliestErrorField, getLatestError, getLatestErrorField} from '@libs/ErrorUtils'; +import {getEarliestErrorField, getLatestError, getLatestErrorField, getMicroSecondOnyxErrorWithTranslationKey} from '@libs/ErrorUtils'; import getPlaidDesktopMessage from '@libs/getPlaidDesktopMessage'; import {REIMBURSEMENT_ACCOUNT_ROUTE_NAMES} from '@libs/ReimbursementAccountUtils'; import WorkspaceResetBankAccountModal from '@pages/workspace/WorkspaceResetBankAccountModal'; @@ -219,7 +219,7 @@ function VerifiedBankAccountFlowEntryPoint({ )} {shouldShowContinueSetupButton === true ? ( From 1fbdf840da40eab1b8eff858ebdca33df94ec198 Mon Sep 17 00:00:00 2001 From: jay Date: Wed, 19 Mar 2025 21:26:44 +0100 Subject: [PATCH 2/4] prettier --- .../VerifiedBankAccountFlowEntryPoint.tsx | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/pages/ReimbursementAccount/VerifiedBankAccountFlowEntryPoint.tsx b/src/pages/ReimbursementAccount/VerifiedBankAccountFlowEntryPoint.tsx index 74549ee121382..19009731c8c73 100644 --- a/src/pages/ReimbursementAccount/VerifiedBankAccountFlowEntryPoint.tsx +++ b/src/pages/ReimbursementAccount/VerifiedBankAccountFlowEntryPoint.tsx @@ -219,7 +219,9 @@ function VerifiedBankAccountFlowEntryPoint({ )} {shouldShowContinueSetupButton === true ? ( From fda176f8f1a39fe907d0ff5c774bd5f2b9276432 Mon Sep 17 00:00:00 2001 From: jay Date: Wed, 26 Mar 2025 20:45:57 +0100 Subject: [PATCH 3/4] make max attempt error non dismissable --- .../ReimbursementAccount/VerifiedBankAccountFlowEntryPoint.tsx | 1 + 1 file changed, 1 insertion(+) diff --git a/src/pages/ReimbursementAccount/VerifiedBankAccountFlowEntryPoint.tsx b/src/pages/ReimbursementAccount/VerifiedBankAccountFlowEntryPoint.tsx index 19009731c8c73..56feaa0ea2f5f 100644 --- a/src/pages/ReimbursementAccount/VerifiedBankAccountFlowEntryPoint.tsx +++ b/src/pages/ReimbursementAccount/VerifiedBankAccountFlowEntryPoint.tsx @@ -223,6 +223,7 @@ function VerifiedBankAccountFlowEntryPoint({ reimbursementAccount?.maxAttemptsReached ? getMicroSecondOnyxErrorWithTranslationKey('connectBankAccountStep.maxAttemptsReached') : getLatestError(errors) } shouldShowErrorMessages + canDismissError={!reimbursementAccount?.maxAttemptsReached} onClose={resetReimbursementAccount} > Date: Mon, 31 Mar 2025 17:36:54 +0200 Subject: [PATCH 4/4] add margin for error message --- .../ReimbursementAccount/VerifiedBankAccountFlowEntryPoint.tsx | 1 + 1 file changed, 1 insertion(+) diff --git a/src/pages/ReimbursementAccount/VerifiedBankAccountFlowEntryPoint.tsx b/src/pages/ReimbursementAccount/VerifiedBankAccountFlowEntryPoint.tsx index 56feaa0ea2f5f..f8221a784a21e 100644 --- a/src/pages/ReimbursementAccount/VerifiedBankAccountFlowEntryPoint.tsx +++ b/src/pages/ReimbursementAccount/VerifiedBankAccountFlowEntryPoint.tsx @@ -222,6 +222,7 @@ function VerifiedBankAccountFlowEntryPoint({ errors={ reimbursementAccount?.maxAttemptsReached ? getMicroSecondOnyxErrorWithTranslationKey('connectBankAccountStep.maxAttemptsReached') : getLatestError(errors) } + errorRowStyles={styles.mt2} shouldShowErrorMessages canDismissError={!reimbursementAccount?.maxAttemptsReached} onClose={resetReimbursementAccount}