From dbd5678dc1e73ae44169e3884f7c1d35c4830ff9 Mon Sep 17 00:00:00 2001 From: Tim Golen Date: Wed, 26 Mar 2025 10:48:44 -0600 Subject: [PATCH 1/3] Add a testID to identify the not found page specifically in FullStory --- src/components/BlockingViews/FullPageNotFoundView.tsx | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/components/BlockingViews/FullPageNotFoundView.tsx b/src/components/BlockingViews/FullPageNotFoundView.tsx index 650005926b30e..dd580a787a61d 100644 --- a/src/components/BlockingViews/FullPageNotFoundView.tsx +++ b/src/components/BlockingViews/FullPageNotFoundView.tsx @@ -83,7 +83,10 @@ function FullPageNotFoundView({ if (shouldShow) { StatsCounter('FullPageNotFoundView'); return ( - + Date: Wed, 26 Mar 2025 11:04:54 -0600 Subject: [PATCH 2/3] Move the testID to a different element --- src/components/BlockingViews/BlockingView.tsx | 5 +++++ src/components/BlockingViews/ForceFullScreenView/types.ts | 1 + src/components/BlockingViews/FullPageNotFoundView.tsx | 6 ++---- tsconfig.json | 1 + 4 files changed, 9 insertions(+), 4 deletions(-) diff --git a/src/components/BlockingViews/BlockingView.tsx b/src/components/BlockingViews/BlockingView.tsx index 26253e6715a9c..ee800c400a933 100644 --- a/src/components/BlockingViews/BlockingView.tsx +++ b/src/components/BlockingViews/BlockingView.tsx @@ -57,6 +57,9 @@ type BaseBlockingViewProps = { /** Whether to add bottom safe area padding to the content. */ addOfflineIndicatorBottomSafeAreaPadding?: boolean; + + /** A testing ID that can be applied to the element on the page */ + testID?: string; }; type BlockingViewIconProps = { @@ -108,6 +111,7 @@ function BlockingView({ containerStyle: containerStyleProp, addBottomSafeAreaPadding = false, addOfflineIndicatorBottomSafeAreaPadding = addBottomSafeAreaPadding, + testID, }: BlockingViewProps) { const styles = useThemeStyles(); const {translate} = useLocalize(); @@ -151,6 +155,7 @@ function BlockingView({ {!!animation && ( + diff --git a/tsconfig.json b/tsconfig.json index 56c76035fb10e..c835cc69f5105 100644 --- a/tsconfig.json +++ b/tsconfig.json @@ -2,6 +2,7 @@ "$schema": "https://json.schemastore.org/tsconfig", "extends": "expo/tsconfig.base", "compilerOptions": { + "jsx": "react", "module": "commonjs", "types": ["react-native", "react-native-web", "jest", "node"], "lib": ["DOM", "DOM.Iterable", "ESNext"], From f6242d4b6b82616ec2f7d25e9ec13ce33f8fd25e Mon Sep 17 00:00:00 2001 From: Tim Golen Date: Mon, 31 Mar 2025 09:18:42 -0600 Subject: [PATCH 3/3] Remove conflg change --- tsconfig.json | 1 - 1 file changed, 1 deletion(-) diff --git a/tsconfig.json b/tsconfig.json index c835cc69f5105..56c76035fb10e 100644 --- a/tsconfig.json +++ b/tsconfig.json @@ -2,7 +2,6 @@ "$schema": "https://json.schemastore.org/tsconfig", "extends": "expo/tsconfig.base", "compilerOptions": { - "jsx": "react", "module": "commonjs", "types": ["react-native", "react-native-web", "jest", "node"], "lib": ["DOM", "DOM.Iterable", "ESNext"],