From e71a241340b2db16e854b2abba258be949b6c217 Mon Sep 17 00:00:00 2001 From: Bernhard Owen Josephus Date: Thu, 27 Mar 2025 12:06:19 +0800 Subject: [PATCH 1/2] fix clearing pending action add tag error doesn't delete the tag --- src/libs/actions/Policy/Tag.ts | 1 - 1 file changed, 1 deletion(-) diff --git a/src/libs/actions/Policy/Tag.ts b/src/libs/actions/Policy/Tag.ts index d792d9625b047..d5290ff41fa38 100644 --- a/src/libs/actions/Policy/Tag.ts +++ b/src/libs/actions/Policy/Tag.ts @@ -209,7 +209,6 @@ function createPolicyTag(policyID: string, tagName: string) { tags: { [newTagName]: { errors: ErrorUtils.getMicroSecondOnyxErrorWithTranslationKey('workspace.tags.genericFailureMessage'), - pendingAction: null, }, }, }, From 3a66e11b1087cb58cb39d5f3de0b47af3887eac5 Mon Sep 17 00:00:00 2001 From: Bernhard Owen Josephus Date: Thu, 27 Mar 2025 12:06:23 +0800 Subject: [PATCH 2/2] fix clearing pending action add category error doesn't delete the category --- src/libs/actions/Policy/Category.ts | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/libs/actions/Policy/Category.ts b/src/libs/actions/Policy/Category.ts index 3e98d564f5dd0..2e0a57c7e6f3b 100644 --- a/src/libs/actions/Policy/Category.ts +++ b/src/libs/actions/Policy/Category.ts @@ -107,7 +107,6 @@ function buildOptimisticPolicyCategories(policyID: string, categories: readonly const failureCategoryMap = categories.reduce>>((acc, category) => { acc[category] = { errors: ErrorUtils.getMicroSecondOnyxErrorWithTranslationKey('workspace.categories.createFailureMessage'), - pendingAction: null, }; return acc; }, {}); @@ -943,6 +942,13 @@ function clearCategoryErrors(policyID: string, categoryName: string) { return; } + if (category.pendingAction === CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD) { + Onyx.merge(`${ONYXKEYS.COLLECTION.POLICY_CATEGORIES}${policyID}`, { + [category.name]: null, + }); + return; + } + Onyx.merge(`${ONYXKEYS.COLLECTION.POLICY_CATEGORIES}${policyID}`, { [category.name]: { errors: null,