From f0909c5fde380f77153cd401676ca02d77e4673d Mon Sep 17 00:00:00 2001 From: thelullabyy Date: Thu, 17 Apr 2025 22:27:04 +0700 Subject: [PATCH 1/4] fix: cursor not move to end after select suggestion --- .../Search/SearchPageHeader/SearchPageHeaderInput.tsx | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/components/Search/SearchPageHeader/SearchPageHeaderInput.tsx b/src/components/Search/SearchPageHeader/SearchPageHeaderInput.tsx index 0be5ef0ae02ce..e0f4f83027cd6 100644 --- a/src/components/Search/SearchPageHeader/SearchPageHeaderInput.tsx +++ b/src/components/Search/SearchPageHeader/SearchPageHeaderInput.tsx @@ -258,6 +258,7 @@ function SearchPageHeaderInput({queryJSON, searchRouterListVisible, hideSearchRo { @@ -291,7 +292,7 @@ function SearchPageHeaderInput({queryJSON, searchRouterListVisible, hideSearchRo autocompleteQueryValue={autocompleteQueryValue} searchQueryItem={searchQueryItem} onListItemPress={onListItemPress} - setTextQuery={setTextInputValue} + setTextQuery={setTextAndUpdateSelection} updateAutocompleteSubstitutions={updateAutocompleteSubstitutions} ref={listRef} /> From dbc28f6d240a9b85c6f732bb8ef4f8708f6cff41 Mon Sep 17 00:00:00 2001 From: thelullabyy Date: Tue, 22 Apr 2025 14:40:07 +0700 Subject: [PATCH 2/4] fix ESlint canBeMissing --- .../Search/SearchPageHeader/SearchPageHeaderInput.tsx | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/components/Search/SearchPageHeader/SearchPageHeaderInput.tsx b/src/components/Search/SearchPageHeader/SearchPageHeaderInput.tsx index e0f4f83027cd6..515d6bad3a362 100644 --- a/src/components/Search/SearchPageHeader/SearchPageHeaderInput.tsx +++ b/src/components/Search/SearchPageHeader/SearchPageHeaderInput.tsx @@ -68,11 +68,11 @@ function SearchPageHeaderInput({queryJSON, searchRouterListVisible, hideSearchRo const theme = useTheme(); const {shouldUseNarrowLayout: displayNarrowHeader} = useResponsiveLayout(); const personalDetails = usePersonalDetails(); - const [reports] = useOnyx(ONYXKEYS.COLLECTION.REPORT); - const [policies] = useOnyx(ONYXKEYS.COLLECTION.POLICY); + const [reports] = useOnyx(ONYXKEYS.COLLECTION.REPORT, {canBeMissing: true}); + const [policies] = useOnyx(ONYXKEYS.COLLECTION.POLICY, {canBeMissing: true}); const taxRates = useMemo(() => getAllTaxRates(), []); - const [userCardList] = useOnyx(ONYXKEYS.CARD_LIST); - const [workspaceCardFeeds] = useOnyx(ONYXKEYS.COLLECTION.WORKSPACE_CARDS_LIST); + const [userCardList] = useOnyx(ONYXKEYS.CARD_LIST, {canBeMissing: false}); + const [workspaceCardFeeds] = useOnyx(ONYXKEYS.COLLECTION.WORKSPACE_CARDS_LIST, {canBeMissing: false}); const allCards = useMemo(() => mergeCardListWithWorkspaceFeeds(workspaceCardFeeds ?? CONST.EMPTY_OBJECT, userCardList), [userCardList, workspaceCardFeeds]); const cardFeedNamesWithType = useMemo(() => { return getCardFeedNamesWithType({workspaceCardFeeds, translate}); From 374bae8478dd06d92344db0cd5f86ca95e8d5003 Mon Sep 17 00:00:00 2001 From: thelullabyy Date: Wed, 23 Apr 2025 17:17:17 +0700 Subject: [PATCH 3/4] update canBeMissing value --- .../Search/SearchPageHeader/SearchPageHeaderInput.tsx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/components/Search/SearchPageHeader/SearchPageHeaderInput.tsx b/src/components/Search/SearchPageHeader/SearchPageHeaderInput.tsx index 515d6bad3a362..0885a00257358 100644 --- a/src/components/Search/SearchPageHeader/SearchPageHeaderInput.tsx +++ b/src/components/Search/SearchPageHeader/SearchPageHeaderInput.tsx @@ -71,8 +71,8 @@ function SearchPageHeaderInput({queryJSON, searchRouterListVisible, hideSearchRo const [reports] = useOnyx(ONYXKEYS.COLLECTION.REPORT, {canBeMissing: true}); const [policies] = useOnyx(ONYXKEYS.COLLECTION.POLICY, {canBeMissing: true}); const taxRates = useMemo(() => getAllTaxRates(), []); - const [userCardList] = useOnyx(ONYXKEYS.CARD_LIST, {canBeMissing: false}); - const [workspaceCardFeeds] = useOnyx(ONYXKEYS.COLLECTION.WORKSPACE_CARDS_LIST, {canBeMissing: false}); + const [userCardList] = useOnyx(ONYXKEYS.CARD_LIST, {canBeMissing: true}); + const [workspaceCardFeeds] = useOnyx(ONYXKEYS.COLLECTION.WORKSPACE_CARDS_LIST, {canBeMissing: true}); const allCards = useMemo(() => mergeCardListWithWorkspaceFeeds(workspaceCardFeeds ?? CONST.EMPTY_OBJECT, userCardList), [userCardList, workspaceCardFeeds]); const cardFeedNamesWithType = useMemo(() => { return getCardFeedNamesWithType({workspaceCardFeeds, translate}); From 852067110319676cd1f74d0e7827032a2f75d89f Mon Sep 17 00:00:00 2001 From: thelullabyy Date: Fri, 25 Apr 2025 08:40:57 +0700 Subject: [PATCH 4/4] fix canBeMissing --- .../Search/SearchPageHeader/SearchPageHeaderInput.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/components/Search/SearchPageHeader/SearchPageHeaderInput.tsx b/src/components/Search/SearchPageHeader/SearchPageHeaderInput.tsx index a0c89d9aa2444..90b272afa6bb8 100644 --- a/src/components/Search/SearchPageHeader/SearchPageHeaderInput.tsx +++ b/src/components/Search/SearchPageHeader/SearchPageHeaderInput.tsx @@ -72,7 +72,7 @@ function SearchPageHeaderInput({queryJSON, searchRouterListVisible, hideSearchRo const [reports] = useOnyx(ONYXKEYS.COLLECTION.REPORT, {canBeMissing: true}); const [policies] = useOnyx(ONYXKEYS.COLLECTION.POLICY, {canBeMissing: false}); const taxRates = useMemo(() => getAllTaxRates(), []); - const [userCardList] = useOnyx(ONYXKEYS.CARD_LIST, {canBeMissing: false}); + const [userCardList] = useOnyx(ONYXKEYS.CARD_LIST, {canBeMissing: true}); const [workspaceCardFeeds] = useOnyx(ONYXKEYS.COLLECTION.WORKSPACE_CARDS_LIST, {canBeMissing: true}); const allCards = useMemo(() => mergeCardListWithWorkspaceFeeds(workspaceCardFeeds ?? CONST.EMPTY_OBJECT, userCardList), [userCardList, workspaceCardFeeds]); const cardFeedNamesWithType = useMemo(() => {